unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: James Smith via Guix-patches via <guix-patches@gnu.org>
To: Christopher Baines <mail@cbaines.net>
Cc: iyzsong@envs.net, 70971@debbugs.gnu.org, adam.faiz@disroot.org,
	liliana.prikler@gmail.com
Subject: [bug#70971] [PATCH v2 1/3] gnu: dhewm3: Use git repository.
Date: Tue, 11 Jun 2024 05:45:19 -0700	[thread overview]
Message-ID: <864j9zzm00.fsf@disroot.org> (raw)
In-Reply-To: <87a5jrbw83.fsf@cbaines.net> (Christopher Baines's message of "Tue, 11 Jun 2024 11:38:20 +0100")

Christopher Baines <mail@cbaines.net> writes:

> James Smith via Guix-patches via <guix-patches@gnu.org> writes:
>
>> * gnu/packages/game-development.scm (dhewm3) [source]: Use git repository
>> instead of downloading a tarball from GitHub.
>>
>> Change-Id: I81ff5de0687221d7eec64b0165dbf10c2d041260
>> ---
>>  gnu/packages/game-development.scm | 12 ++++++------
>>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> I'm missing why you're making this change? I don't see anything wrong
> with using these upstream release tarballs.

I noticed that the package was using a tarball from GitHub and assumed
that it was one that was autogenerated. Upon closer inspection, I see
that it's a manually pack tarball instead. I can send a new set of
patches that excludes switching to the git repository if needed.




  reply	other threads:[~2024-06-11 15:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-16  0:42 [bug#70971] [PATCH 0/3] Update dhewm3 James Smith via Guix-patches via
2024-05-16  0:46 ` [bug#70971] [PATCH 1/3] gnu: dhewm3: Use git repository James Smith via Guix-patches via
2024-05-16  0:46 ` [bug#70971] [PATCH 2/3] gnu: dhewm3: Use gexps James Smith via Guix-patches via
2024-05-16  0:46 ` [bug#70971] [PATCH 3/3] gnu: dhewm3: Update to 1.5.3 James Smith via Guix-patches via
2024-06-07  5:45 ` [bug#70971] [PATCH v2 0/3] Update dhewm3 James Smith via Guix-patches via
2024-06-07  5:45   ` [bug#70971] [PATCH v2 1/3] gnu: dhewm3: Use git repository James Smith via Guix-patches via
2024-06-11 10:38     ` Christopher Baines
2024-06-11 12:45       ` James Smith via Guix-patches via [this message]
2024-06-22 16:33         ` Christopher Baines
2024-06-07  5:45   ` [bug#70971] [PATCH v2 2/3] gnu: dhewm3: Use gexps James Smith via Guix-patches via
2024-06-07  5:45   ` [bug#70971] [PATCH v2 3/3] gnu: dhewm3: Update to 1.5.3 James Smith via Guix-patches via
2024-06-30 10:46 ` bug#70971: Close Andreas Enge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=864j9zzm00.fsf@disroot.org \
    --to=guix-patches@gnu.org \
    --cc=70971@debbugs.gnu.org \
    --cc=adam.faiz@disroot.org \
    --cc=iyzsong@envs.net \
    --cc=jsubuntuxp@disroot.org \
    --cc=liliana.prikler@gmail.com \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).