From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47408)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d6FDv-0006Zv-Uv
	for guix-patches@gnu.org; Thu, 04 May 2017 07:47:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d6FDr-0006Ez-0G
	for guix-patches@gnu.org; Thu, 04 May 2017 07:47:08 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:55450)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1d6FDq-0006Es-Sh
	for guix-patches@gnu.org; Thu, 04 May 2017 07:47:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1d6FDq-0003jL-J0
	for guix-patches@gnu.org; Thu, 04 May 2017 07:47:02 -0400
Subject: bug#26652: [PATCH 2/2] scripts: refresh: Add -m manifest option.
Resent-Message-ID: <handler.26652.B26652.149389838214289@debbugs.gnu.org>
References: <20170425130024.9481-1-m.othacehe@gmail.com>
	<20170425130024.9481-2-m.othacehe@gmail.com> <87r305r9kn.fsf@gnu.org>
From: Mathieu Othacehe <m.othacehe@gmail.com>
In-reply-to: <87r305r9kn.fsf@gnu.org>
Date: Thu, 04 May 2017 13:46:47 +0200
Message-ID: <8637ck6dzs.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 26652@debbugs.gnu.org


Hi Ludo,

Thanks for the review :)

>>    (display (_ "
>> +  -m, --manifest=FILE    select all the packages in FILE manifest"))
>
> “select all the package from the manifest in FILE” maybe?

Ok.

> Also, maybe s/get-manifest-packages/packages-from-manifest/, because
> ‘get-’ is quite unusual.  :-)

Seems better !

>
>> +         (packages
>> +          (or manifest-packages args-packages)))
>
> Maybe (append (match (assoc-ref opts 'manifest)
>                 (#f '())
>                 ((? string? file) (packages-from-manifest file)))
>               args-packages)

Mmh, I dont think we want to append manifest packages and args-packages.
We want only manifest packages if a manifest is specified IMO.

>
> ?
>
> Could you also update guix.texi to mention this option and the intended
> use case?

Sure.

I sent an updated patch taking your remarks into account.

Mathieu