From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6EhcDq1yfmDpWgAAgWs5BA (envelope-from ) for ; Tue, 20 Apr 2021 08:20:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 6GbyCa1yfmCgWwAAB5/wlQ (envelope-from ) for ; Tue, 20 Apr 2021 06:20:29 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8398016A69 for ; Tue, 20 Apr 2021 08:20:28 +0200 (CEST) Received: from localhost ([::1]:55484 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYjkI-0004wb-C0 for larch@yhetil.org; Tue, 20 Apr 2021 02:20:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48924) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYjju-0004wQ-58 for guix-patches@gnu.org; Tue, 20 Apr 2021 02:20:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41222) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lYjjt-000479-UT for guix-patches@gnu.org; Tue, 20 Apr 2021 02:20:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lYjjt-0000iy-Q8 for guix-patches@gnu.org; Tue, 20 Apr 2021 02:20:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47768] [PATCH 07/37] gnu: Add ocaml-gen. Resent-From: pukkamustard Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 20 Apr 2021 06:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47768 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 47768@debbugs.gnu.org Received: via spool by 47768-submit@debbugs.gnu.org id=B47768.16188995462713 (code B ref 47768); Tue, 20 Apr 2021 06:20:01 +0000 Received: (at 47768) by debbugs.gnu.org; 20 Apr 2021 06:19:06 +0000 Received: from localhost ([127.0.0.1]:52768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYjiz-0000hh-Rr for submit@debbugs.gnu.org; Tue, 20 Apr 2021 02:19:06 -0400 Received: from mout02.posteo.de ([185.67.36.66]:47105) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYjix-0000hC-8x for 47768@debbugs.gnu.org; Tue, 20 Apr 2021 02:19:04 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 24FE32400E5 for <47768@debbugs.gnu.org>; Tue, 20 Apr 2021 08:18:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1618899536; bh=UtmY64bnKdnOZER7qc/oAUDiUhJvQCGbDo4cOJ+1hnI=; h=From:To:Cc:Subject:Date:From; b=mR4A8DUSn8MEiqo/PNHUXnNhgCcIfxalFA9w2SVsdW1UoUkA/Qmym+lvrXLejS4Z8 9WRxI1RyZGgDaGl1JchBaEIUKkOf3KlnQODQ+8/S/Ib4NRjImI19SqNCXveNbdb5N6 PtYJwgOcZvyGYQXJ75NmznpY7cCIohccb3B4xK9p4oFabMZmRWN+yvQHzqVHRe1f9y fjGB1/+kPWOhYvigJOTmrQ0yBxpGNPReCpJkjkEfBv6YvikTB94/op6uL7wJVSM6KS y5iA8Dh66zzighaGz/I3UN+sl6LZIDc7l7lkx04xJaySqNDO8tQaETPNpI4iF7jXVC B+ll3tRaEeP2A== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4FPYRL4HwBz9rxL; Tue, 20 Apr 2021 08:18:54 +0200 (CEST) References: <20210414091303.6990-1-pukkamustard@posteo.net> <20210414091303.6990-7-pukkamustard@posteo.net> <561883a08955c370309c5149812950d6387d5df5.camel@telenet.be> From: pukkamustard Date: Tue, 20 Apr 2021 06:11:29 +0000 In-reply-to: <561883a08955c370309c5149812950d6387d5df5.camel@telenet.be> Message-ID: <8635vlfpgy.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618899628; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=fDFGFvE3Cirm3I/AuD4RIjxvgUW+ye+FWtsuGlbYP/g=; b=tv2yK05VMDLKGu1kpnV//AcYv91iIjQXiFpej5eogTGNz1Fa6pbDHQdyfa8LpB0SnehaCj NilBSWun7/ysYdhTi8dRMbte/A5K9eMtlMPU+cf/+P9orbP8h2Zk/YiciD/GnhBqYS07RP pp9nXs5MeUQBi305XjP8gq0jyhd9C5G4dnqI6Wo6yy0mvQy7KlVDo7vAScbs3VFU4F5XmT 70bHas5Ww6y3W/NsTKDr/XFHR07LSm84TPJI/IxMK2cQpbabiLyNCezBRAZzPhRv+DYubT IodBcSIs796yY3pazhGYp5sbe32kgawoyQugLq+oyh+h5jwJnjn1xyATp/U1vQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618899628; a=rsa-sha256; cv=none; b=ov/gLayKCWPj8ZqjP7GVX6zsY+7POVPF6kD/nGA/WjXcQS6s+89qNieGrL3f1bNHMKt+HA YNLbeg8pfHJK6sHOQwWT0h9YjuzBmz/i7QV5HG19g5BOyk9NLZiTB+kobzOkoDqhtVIlaX nlq44XX+rjU5bup1IjxB7H7OBqT10pOY/+o9YPPFNXLaq7uBuemluA6iQtAw5g9gqZ2L/I mL0SkMltN6WG8jnOPbgnKM1S5KosutjrrTb8a8Vgqc/1G6/DHBNCidvzm8SMh+IB+RC2Vd Gj4wWVLjWWW40jpKnVTeD5nypMDjxH3HygPu6UYCS7fqoHgfjnO4hhZe648XQg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=mR4A8DUS; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.34 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=mR4A8DUS; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 8398016A69 X-Spam-Score: -1.34 X-Migadu-Scanner: scn0.migadu.com X-TUID: MNqS50szMCSG --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Maxime Devos writes: >> -(define-public ocaml4.07-gen >> +(define-public ocaml-gen >> [...] >> `(#:tests? #f; no tests >> - #:package "gen" >> - #:ocaml ,ocaml-4.07 >> - #:findlib ,ocaml4.07-findlib >> - #:dune ,ocaml4.07-dune)) >> + #:package "gen")) >> (propagated-inputs >> - `(("ocaml-odoc" ,(package-with-ocaml4.07=20 >> ocaml4.07-odoc)))) >> + `(("ocaml-odoc" ,ocaml-odoc))) >> (native-inputs >> - `(("ocaml-qtest" ,(package-with-ocaml4.07 ocaml-qtest)) >> - ("ocaml-qcheck" ,(package-with-ocaml4.07=20 >> ocaml-qcheck)))) >> + `(("ocaml-qtest" ,ocaml-qtest) >> + ("ocaml-qcheck" ,ocaml-qcheck))) > > I'm confused what's going on here. > ocaml-qtest is for unit tests=20 > (https://opam.ocaml.org/packages/qtest/qtest.2.1.0/), > but for this package we have =E2=80=98#:tests? #f; no tests?=E2=80=99? Excellent catch! There are in fact tests and they also pass.=20 Please find attached updated patch that enables tests (I can also resend the=20 entire patch series as v2 if that is easier). The `#tests? #f` was introduced with commit 5a4003f453ee8afdfe21d959e105250bfc876063 in 2019 and I blindly=20 copied it. -pukkamustard --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-Add-ocaml-gen.patch >From 3036a81329f65c6c9ffe2117744590a7e52aee01 Mon Sep 17 00:00:00 2001 From: pukkamustard Date: Fri, 9 Apr 2021 14:59:36 +0200 Subject: [PATCH] gnu: Add ocaml-gen. * gnu/packages/ocaml.scm (ocaml-gen): New variable. (ocaml4.07-gen): Remove variable. (ocaml4.07-sedlex): Replace ocaml4.07-gen with ocaml-gen. --- gnu/packages/ocaml.scm | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/gnu/packages/ocaml.scm b/gnu/packages/ocaml.scm index 503913c8fd..1acde9c0ee 100644 --- a/gnu/packages/ocaml.scm +++ b/gnu/packages/ocaml.scm @@ -2508,9 +2508,9 @@ format. It can process XML documents without a complete in-memory representation of the data.") (license license:isc))) -(define-public ocaml4.07-gen +(define-public ocaml-gen (package - (name "ocaml4.07-gen") + (name "ocaml-gen") (version "0.5.3") (source (origin (method git-fetch) @@ -2523,16 +2523,13 @@ representation of the data.") "1jzrs0nsdk55annkd2zrk5svi61i3b1nk6qyqdc2y26vnzqvzfg8")))) (build-system dune-build-system) (arguments - `(#:tests? #f; no tests - #:package "gen" - #:ocaml ,ocaml-4.07 - #:findlib ,ocaml4.07-findlib - #:dune ,ocaml4.07-dune)) + `(#:package "gen" + #:test-target ".")) (propagated-inputs - `(("ocaml-odoc" ,(package-with-ocaml4.07 ocaml4.07-odoc)))) + `(("ocaml-odoc" ,ocaml-odoc))) (native-inputs - `(("ocaml-qtest" ,(package-with-ocaml4.07 ocaml-qtest)) - ("ocaml-qcheck" ,(package-with-ocaml4.07 ocaml-qcheck)))) + `(("ocaml-qtest" ,ocaml-qtest) + ("ocaml-qcheck" ,ocaml-qcheck))) (home-page "https://github.com/c-cube/gen/") (synopsis "Iterators for OCaml, both restartable and consumable") (description "Gen implements iterators of OCaml, that are both restartable @@ -2577,7 +2574,7 @@ and consumable.") (native-inputs `(("ocamlbuild" ,(package-with-ocaml4.07 ocamlbuild)))) (propagated-inputs - `(("ocaml-gen" ,ocaml4.07-gen) + `(("ocaml-gen" ,(package-with-ocaml4.07 ocaml-gen)) ("ocaml-ppx-tools-versioned" ,(package-with-ocaml4.07 ocaml-ppx-tools-versioned)) ("ocaml-uchar" ,(package-with-ocaml4.07 ocaml-uchar)))) -- 2.31.1 --=-=-=--