From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cCraK+tY3mFd8gAAgWs5BA (envelope-from ) for ; Wed, 12 Jan 2022 05:28:27 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id eNZgKOtY3mFzdQAAauVa8A (envelope-from ) for ; Wed, 12 Jan 2022 05:28:27 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 24BDA35A0E for ; Wed, 12 Jan 2022 05:28:27 +0100 (CET) Received: from localhost ([::1]:54948 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7VFJ-0008MI-PY for larch@yhetil.org; Tue, 11 Jan 2022 23:28:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37396) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7VEx-0008Ln-6f for guix-patches@gnu.org; Tue, 11 Jan 2022 23:28:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:34831) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n7VEv-0001yb-UT for guix-patches@gnu.org; Tue, 11 Jan 2022 23:28:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n7VEv-0000T4-LW for guix-patches@gnu.org; Tue, 11 Jan 2022 23:28:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51747] [PATCH]: gnu: nix: Update to 2.4. Resent-From: Zhu Zihao Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 12 Jan 2022 04:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51747 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: Oleg Pykhalov , 51747@debbugs.gnu.org Received: via spool by 51747-submit@debbugs.gnu.org id=B51747.16419616251692 (code B ref 51747); Wed, 12 Jan 2022 04:28:01 +0000 Received: (at 51747) by debbugs.gnu.org; 12 Jan 2022 04:27:05 +0000 Received: from localhost ([127.0.0.1]:55967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7VE0-0000RD-Mt for submit@debbugs.gnu.org; Tue, 11 Jan 2022 23:27:04 -0500 Received: from mail-m974.mail.163.com ([123.126.97.4]:29756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7VDw-0000QV-Qi for 51747@debbugs.gnu.org; Tue, 11 Jan 2022 23:27:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=8zMmi 3nJmfulfO3L4/9glS/groHhVbqg7GXPpR5sIrA=; b=XBeFLkNxOkSE+3/wYtI2e EiSuAaUBpOORY+gOBQKvJ+cSk951GvCbxbSbbUP/TtWtbUCY+490tVeboPUlcqi8 pM8v9DQlMLwBp4GcLHg+gmqbM3vcmZoewPeQCdJacwNWPQjGv/ho8ACaQFQQBVsV e7OQbilYTf/bvwOHwkgDgI= Received: from asus-laptop (unknown [27.46.80.3]) by smtp4 (Coremail) with SMTP id HNxpCgA3qkuKWN5hk2F+FA--.1055S2; Wed, 12 Jan 2022 12:26:51 +0800 (CST) References: <86sfw4chme.fsf@163.com> <864k8kcdzu.fsf@163.com> <861r3oau4u.fsf@163.com> <86lf1njad0.fsf@163.com> <86ilw4e6av.fsf@163.com> <87y23mheag.fsf_-_@gmail.com> <86pmoyrxyy.fsf@163.com> <190ec030edbca1c16fb030c51acd60ffc6bae269.camel@telenet.be> User-agent: mu4e 1.6.10; emacs 27.2 From: Zhu Zihao Date: Wed, 12 Jan 2022 12:21:47 +0800 In-reply-to: <190ec030edbca1c16fb030c51acd60ffc6bae269.camel@telenet.be> Message-ID: <8635lto9z3.fsf@163.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-CM-TRANSID: HNxpCgA3qkuKWN5hk2F+FA--.1055S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7Ww4DtrWDCFWxGFWxGw1Utrb_yoW8Xr4kpw 4xJFyqyrs8Xr4Ikrsak3WayFWfZwn3Z3sIgFy5tr95urs8tFyxKr4Fkw4qkasxZrs29w1j vF4qyryvgFW2kFDanT9S1TB71UUUUUUqnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0zEdgAcUUUUU= X-Originating-IP: [27.46.80.3] X-CM-SenderInfo: pdoosuxxwbztlvw6il2tof0z/xtbBLwuGr1UMPqXheAAAsW X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641961707; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=8zMmi3nJmfulfO3L4/9glS/groHhVbqg7GXPpR5sIrA=; b=sXRMmrAKapE6VIB9FZpGs2hfnxRfJHxzCGlEHTknCan/s3Q2oZfP1jiS8iun5LTcde3No4 LwwQiqb0Drga3ZwBLiPR7VKosJHxwpX3MJUqK9qbZBDhiXgPRYkrAmurXYf4/CLAaA+lOc OsCfTlrFNi407RUanYTKIRvjoAZf42bSFhjSjIJw75b8Z8VnFW81TXfdG9BvlWHtywSAUR WUzqFuRqTwkV0RHMILIikExg3sXMJ5KKI91NpNxBsdveBVFwmHnq/AtXqh9W2FB7V/mQm8 nuPvRRjDLHh97lfwkIHjurlk9aSwOZagrhg0ZikQ/tO0ynvMPnHyfQxaO4zLwA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641961707; a=rsa-sha256; cv=none; b=HXEgqhnqTeoYXzNFBZ4iyvFli4JGPlT7Y4AS+Vod2xAC39RryP2SZu4FpTfZHhcYvZuYP2 eMkR+KFGkLuhrzXqzwzGzXvdhUKOFRIXlbZIl+7uOg+n1Ej//fm/RoNrd8XkV6/lK5kaj5 BDhFksSDbAJZuLAnT1q52Su6kA80d8cGQoEkQgrCe9v0VE7JSGeK3KpfNpDWuaEHp4jlKp l6QZbr3hZayVfTquXSCoiTf3EOFT8AL17QQPZ/oFTTHovjn6x6zTRucXP4QXxV/+4Y363f YJdEvb4sDlX9JneRqvJT/IjqmFqkqNHqbgZQGXsmkvnajxJ6y8lCiO66WjvBgA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=163.com header.s=s110527 header.b=XBeFLkNx; dmarc=fail reason="SPF not aligned (relaxed)" header.from=163.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.62 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=163.com header.s=s110527 header.b=XBeFLkNx; dmarc=fail reason="SPF not aligned (relaxed)" header.from=163.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 24BDA35A0E X-Spam-Score: -4.62 X-Migadu-Scanner: scn0.migadu.com X-TUID: eWsZkbsBi133 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Maxime Devos writes: > [[PGP Signed Part:Undecided]] > Zhu Zihao schreef op wo 12-01-2022 om 01:19 [+0800]: >> + (name "libcpuid") [...] >> +=C2=A0=C2=A0=C2=A0 (supported-systems '("x86_64-linux" "i686-linux")) > > Given that 'cpuid' is a CPU instruction, I don't think > this is Linux-specific; presumably it works on the Hurd > as well. =C2=A0According to the README, it also supports some BSDs, > Mac OS and Windows! > > Could you change it to > > (filter (lambda (t) (or (x86-64-target? t) (or (x86-32-target? t)))) > %supported-systems) > > instead (untested)? > > Also, the source code contains a blob > , > could you remove it in an origin snippet? > > There might be more blobs, I didn't look at all files. > > Greetings, > Maxime. > > [[End of PGP Signed Part]] Interesting, It looks that these blobs are for Windows system. I don't care about MS Windows, but blobs are tightly integrated in the source. The source reports that they're compiled from the source in contrib/MSR Driver/Kernel. They're PE COFF format, If we want to compile it ourself, we have to use mingw cross compiler. This increase the complexity of build script. AFAIK, nix use libcpuid only in linux context. My idea is replace these blobs with empty bytes. Maybe leave a note for who want mingw cross build.= =20 =2D-=20 Retrieve my PGP public key: gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F Zihao --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIsEARYIADMWIQRefA5qkqvnKdl/GTlmOX+E92aT+QUCYd5YgBUcYWxsX2J1dF9s YXN0QDE2My5jb20ACgkQZjl/hPdmk/nLOgD8DnCTU7XPupgij02SnBBpLP4TzErg /OLR9nlEMfSQlGUBAOCoZ7D8pmpg4+T+iOR1pXRNDtu9nSuSmJaYQ5Xs2ZQM =qq0U -----END PGP SIGNATURE----- --=-=-=--