From: pukkamustard <pukkamustard@posteo.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 53901@debbugs.gnu.org
Subject: [bug#53901] [PATCH] publish: Sign only normative narinfo fields.
Date: Thu, 10 Feb 2022 09:00:12 +0000 [thread overview]
Message-ID: <8635kr84ge.fsf@posteo.net> (raw)
In-Reply-To: <20220209175224.26851-1-ludo@gnu.org>
Ludovic Courtès <ludo@gnu.org> writes:
> This will allow mirror operators to alter the non-normative bits of a
> narinfo, such as nar URLs and compression methods, without requiring
> them to resign narinfos.
>
> [...]
>
> Thoughts?
Sounds good to me.
Maybe we can take the opportunity to do some cleanup?
For example: We could get rid of the narinfo-contents field as we only
sign the fixed normative fields (in a strict order). This would also
allow us to remove the verify-everything-above-signature logic.
I recently tripped over the narinfo verification logic
(https://issues.guix.gnu.org/52555#43) and think the changes you propose
plus the simplifications above should make this security-critical code a
bit easier to understand.
-pukkamustard
next prev parent reply other threads:[~2022-02-10 9:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 17:52 [bug#53901] [PATCH] publish: Sign only normative narinfo fields Ludovic Courtès
2022-02-09 18:29 ` Christopher Baines
2022-02-09 21:49 ` Ludovic Courtès
2022-02-10 9:00 ` pukkamustard [this message]
2022-02-10 21:09 ` Ludovic Courtès
2022-02-11 10:30 ` pukkamustard
2022-02-14 10:29 ` bug#53901: " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8635kr84ge.fsf@posteo.net \
--to=pukkamustard@posteo.net \
--cc=53901@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).