From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id eH/dICWcY2TeeAEASxT56A (envelope-from ) for ; Tue, 16 May 2023 17:07:17 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id sLz6HyWcY2Q+hAAAG6o9tA (envelope-from ) for ; Tue, 16 May 2023 17:07:17 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 12511A56D for ; Tue, 16 May 2023 17:07:17 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pywGW-0001pA-EH; Tue, 16 May 2023 11:07:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pywGU-0001od-Pv for guix-patches@gnu.org; Tue, 16 May 2023 11:07:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pywGU-0002pB-Hs for guix-patches@gnu.org; Tue, 16 May 2023 11:07:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pywGU-0001tU-Du for guix-patches@gnu.org; Tue, 16 May 2023 11:07:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#61363] [PATCH v3] self: Apply grafts to the outputs of the guix derivation. Resent-From: Simon Tournier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 16 May 2023 15:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61363 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Christopher Baines , 61363@debbugs.gnu.org Cc: Christopher Baines Received: via spool by 61363-submit@debbugs.gnu.org id=B61363.16842496017224 (code B ref 61363); Tue, 16 May 2023 15:07:02 +0000 Received: (at 61363) by debbugs.gnu.org; 16 May 2023 15:06:41 +0000 Received: from localhost ([127.0.0.1]:46921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pywG8-0001sQ-V8 for submit@debbugs.gnu.org; Tue, 16 May 2023 11:06:41 -0400 Received: from mail-wm1-f49.google.com ([209.85.128.49]:41280) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pywFy-0001ql-Li for 61363@debbugs.gnu.org; Tue, 16 May 2023 11:06:31 -0400 Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-3f475364065so14833815e9.1 for <61363@debbugs.gnu.org>; Tue, 16 May 2023 08:06:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684249585; x=1686841585; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=eq0vtNrtSRniouaCKk5q6iDiEAw2l1f1DG9TyiHhkUY=; b=k2jACkb3v5zUalvMVdKj0FAWx20k+TXngMPMt9zndBABz3/63bNRpBrmDj5rf8Qqvh 1DZeIfAFIBsRUaYmdWBAo42cVg5wEmFKt1gmtu00XBlx85GkwqcpSR7pOng0B2tdeu4D g/5PRTzjMm2Sf34BDHFfAn96oxfnoLiizNOZGeRONJa9bc8y4N438dLIU7TXoA7klPSk D3nbZsxOvwlXUkRrTec/+XGj7/iJUP3cai3pM7oQcU0Gy+fORcNKVGEHa497vZNpQ08z aCihWv11eJpdvTwQEPh8Ko8LWnc+OO8bCWFryU+UtwCDT87R043HRG6sRFjZqhsTTlss iEBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684249585; x=1686841585; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eq0vtNrtSRniouaCKk5q6iDiEAw2l1f1DG9TyiHhkUY=; b=kfxsHsn6AQBtZKPW9rHQ7cG0S4xt7rLxprVttehLwT8ShsvUJ8CFOc7uROxE9Q6pgn X6hR3RXj/wQqqUGEuGDQt3mDLZh1Uv0qVOnXO7VAuQGnKkyEWxs1Q+ZzRlxxpJdPY1jn AD5OcZXzzIL5tTuxYGiZurto77sS8y4vS4UBo8snqWGFFvyT8n6562VE/XPcoScEsrmi y1Hw88XgGWD5VcEM89nNu0rjXRfHYDi3a6ZlwbGJjEvVChO93ABb1/Sh1TRYSqG+gMnK Xomqwohx9Mij43tqZfTZPRY9+fQi8Y4B8b+KsIIHTcINMRbC6XLFNJO9kxHiU27CrcI+ PW8Q== X-Gm-Message-State: AC+VfDwQFvEXHyc+c4oKpgs5SuctOR8nHYTPW+X8iSPp8PGspg5oVrOE knm6K2+0dJVHMf9XGBYopDI= X-Google-Smtp-Source: ACHHUZ5HebFanQhk6sZ3CLDtK4FFS0ICrnsWgRkaFBK3G/aYfSLXtz5wz2qYdpPEC3cNkaWklJKs7w== X-Received: by 2002:a05:600c:3514:b0:3f4:e426:e0b7 with SMTP id h20-20020a05600c351400b003f4e426e0b7mr2764647wmq.3.1684249584283; Tue, 16 May 2023 08:06:24 -0700 (PDT) Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e]) by smtp.gmail.com with ESMTPSA id m7-20020a7bcb87000000b003f4290720d0sm2562061wmi.47.2023.05.16.08.06.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 May 2023 08:06:24 -0700 (PDT) From: Simon Tournier In-Reply-To: <20230417145928.16693-1-mail@cbaines.net> References: <871qn08uo7.fsf@cbaines.net> <20230417145928.16693-1-mail@cbaines.net> Date: Tue, 16 May 2023 15:25:37 +0200 Message-ID: <86353w76i6.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1684249637; a=rsa-sha256; cv=none; b=V65Zi+EhVpcFQm1tcE9ggtegGbpflvFj1yC8OWdxzTXqAQM7Rpu+so7Tm+KEQzvZ6nzeaN JxAQL0YJYZk5h0Q3osSgB3SvOzWvARDOKJ/KtL8Pd6TvcPF1OPWnureXYG8Yg1XuVP0KnP EbHybFfUejab3R1OsFL/WpxwhNg69sABDm2n5pfj2kym/rV2QT+6hpr0MJlQxHe1bc5YoU ui3R4CjQumLh4LvL5MjuoZsDB7OoFLjCwVkS6zi0lqKRs4ebnQ8d32BGYy7iT2mfA9CCku 2pGOsbRa+S2Ga0qmgHk3NVYCOYm2jlvAP+3wEvAr1Ve6MFYjgQKqmdnwTJ8IKw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=k2jACkb3; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1684249637; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=eq0vtNrtSRniouaCKk5q6iDiEAw2l1f1DG9TyiHhkUY=; b=ZtsVDBN4+7NXwYtb3c0XJhCETiBte4A+dIyGlRVgDK4YtIEVwtEhwjCaG4SzEakBjOdBlM k4LlEGy7yajPSoG19ZCWqQ1/F0qQI8g1jyP2ef+dF1phOiGtpzXw/H+x4B1jkCWcZoiBIc w1ji3bsjB+pAMbbkp3sCCNxFgrfrnZh9DMwnXuqObZK2UDTU5yI/e0JEl+AUk1I28Fqzfx dzLNhgnKEtQPVgKa0Cm9dFAKsKlsQWyIhI+8kJLoYrsHYxJuaum7VBg91dLUz5fTGXi2Qq 8Sykmnr/38GKpwpKfAOcKxoCgbKTbfkI4BwPh5UM6USxMoJKqFt1IKD4oQgUEw== X-Migadu-Spam-Score: -1.81 X-Spam-Score: -1.81 X-Migadu-Queue-Id: 12511A56D X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=k2jACkb3; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-TUID: oF2pY0K1lO0t Hi Chris, I am late to the party and probably do not well understand all that part. Just a quick comment in the same direction as Ludo. On Mon, 17 Apr 2023 at 15:59, Christopher Baines wrote: > diff --git a/guix/self.scm b/guix/self.scm > index 74c953bd50..bbc0beaca8 100644 > --- a/guix/self.scm > +++ b/guix/self.scm [...] > + (if graft? > + (explicit-grafting obj > + (map (compose force cdr) %packages)) > + obj))) [...] > + (if graft? > + (explicit-grafting obj > + (map (compose force cdr) %packages)) > + obj))) It means that the grafts are only applied to %packages, right? Other said, defined by: --8<---------------cut here---------------start------------->8--- (define %packages (let ((ref (lambda (module variable) (delay (module-ref (resolve-interface `(gnu packages ,module)) variable))))) `(("guile" . ,(ref 'guile 'guile-3.0-latest)) ("guile-avahi" . ,(ref 'guile-xyz 'guile-avahi)) ("guile-json" . ,(ref 'guile 'guile-json-4)) ("guile-ssh" . ,(ref 'ssh 'guile-ssh)) ("guile-git" . ,(ref 'guile 'guile-git)) ("guile-semver" . ,(ref 'guile-xyz 'guile-semver)) ("guile-lib" . ,(ref 'guile-xyz 'guile-lib)) ("guile-sqlite3" . ,(ref 'guile 'guile-sqlite3)) ("guile-zlib" . ,(ref 'guile 'guile-zlib)) ("guile-lzlib" . ,(ref 'guile 'guile-lzlib)) ("guile-zstd" . ,(ref 'guile 'guile-zstd)) ("guile-gcrypt" . ,(ref 'gnupg 'guile-gcrypt)) ("guile-gnutls" . ,(ref 'tls 'guile-gnutls)) ("guix-daemon" . ,(ref 'package-management 'guix-daemon)) ("disarchive" . ,(ref 'backup 'disarchive)) ("guile-lzma" . ,(ref 'guile 'guile-lzma)) ("gzip" . ,(ref 'compression 'gzip)) ("bzip2" . ,(ref 'compression 'bzip2)) ("xz" . ,(ref 'compression 'xz)) ("po4a" . ,(ref 'gettext 'po4a)) ("gettext-minimal" . ,(ref 'gettext 'gettext-minimal)) ("gcc-toolchain" . ,(ref 'commencement 'gcc-toolchain)) ("glibc-utf8-locales" . ,(ref 'base 'glibc-utf8-locales)) ("graphviz" . ,(ref 'graphviz 'graphviz)) ("texinfo" . ,(ref 'texinfo 'texinfo))))) --8<---------------cut here---------------end--------------->8--- tweaked by e5c33837cbee98d460d9ae09b463501de6f15d97. And there is a slippery slope: the manual addition. These had been added with e5c33837cbee98d460d9ae09b463501de6f15d97: + ("glibc-utf8-locales" . ,(ref 'base 'glibc-utf8-locales)) + ("graphviz" . ,(ref 'graphviz 'graphviz)) + ("guix-daemon" . ,(ref 'package-management 'guix-daemon)) + ("texinfo" . ,(ref 'texinfo 'texinfo))))) Other said, what does it happen if we forget to manually update this list? Cheers, simon