[bug#71944] [PATCH 0/2] gnu: lollypop: Update version and package style

[bug#71944] [PATCH 0/2] gnu: lollypop: Update version and package style

[James Smith via Guix-patches via]

This patch series updates lollypop to the latest version, as well as update the
package style to use a list of G-Expressions.

James Smith (2):
  gnu: lollypop: Update to 1.4.40.
  gnu: lollypop: Update package style.

 gnu/packages/gnome.scm | 41 +++++++++++++++++++++--------------------
 1 file changed, 21 insertions(+), 20 deletions(-)


base-commit: eeb24a50d2f1f78095bdb16b40ddb93bb51474bc
-- 
2.45.1

[bug#71944] [PATCH 1/2] gnu: lollypop: Update to 1.4.40.

[James Smith via Guix-patches via]

* gnu/packages/gnome.scm: (lollypop): Update to 1.4.40.

Change-Id: I8803c04f7ac2b8597920cc3e2a8371ada6a1dbab
---
 gnu/packages/gnome.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index b4caaf29a7..6a4d1babe3 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -78,6 +78,7 @@
 ;;; Copyright © 2023 Dominik Delgado Steuter <d@delgado.nrw>
 ;;; Copyright © 2023 Zhu Zihao <all_but_last@163.com>
 ;;; Copyright © 2024 Dariqq <dariqq@posteo.net>
+;;; Copyright © 2024 James Smith <jsubuntuxp@disroot.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -11555,14 +11556,14 @@ (define-public gnome-planner
 (define-public lollypop
   (package
     (name "lollypop")
-    (version "1.4.35")
+    (version "1.4.40")
     (source
      (origin
        (method url-fetch)
        (uri (string-append "https://adishatz.org/lollypop/"
                            "lollypop-" version ".tar.xz"))
        (sha256
-        (base32 "0rvwj18x1gs7fgvniijzvlmgmzcgr7il22zclzsn5nkl8xbwgzk0"))))
+        (base32 "1laj5xwfz2bz29scga2ahhnhlgll4a0n21wwy8mlr4jsl81g0jsa"))))
     (build-system meson-build-system)
     (arguments
      `(#:imported-modules (,@%meson-build-system-modules
-- 
2.45.1

[bug#71944] [PATCH 2/2] gnu: lollypop: Update package style.

[James Smith via Guix-patches via]

* gnu/packages/gnome.scm (lollypop)[arguments]: Convert to list of
G-Expressions.

Change-Id: I2f7e0157f65bdd6776fbf15214093a837c5b0fd6
---
 gnu/packages/gnome.scm | 36 ++++++++++++++++++------------------
 1 file changed, 18 insertions(+), 18 deletions(-)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 6a4d1babe3..3b95b20eef 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -11566,24 +11566,24 @@ (define-public lollypop
         (base32 "1laj5xwfz2bz29scga2ahhnhlgll4a0n21wwy8mlr4jsl81g0jsa"))))
     (build-system meson-build-system)
     (arguments
-     `(#:imported-modules (,@%meson-build-system-modules
-                           (guix build python-build-system))
-       #:modules ((guix build meson-build-system)
-                  ((guix build python-build-system) #:prefix python:)
-                  (guix build utils))
-       #:glib-or-gtk? #t
-       #:phases
-       (modify-phases %standard-phases
-         (add-after 'unpack 'disable-gtk-update-icon-cache
-           (lambda _
-             (setenv "DESTDIR" "/")))
-         (add-after 'install 'wrap-program
-           (lambda* (#:key outputs #:allow-other-keys)
-             (wrap-program (search-input-file outputs "bin/lollypop")
-               `("GI_TYPELIB_PATH" ":" prefix
-                 (,(getenv "GI_TYPELIB_PATH"))))))
-         (add-after 'install 'wrap-python
-           (assoc-ref python:%standard-phases 'wrap)))))
+     (list #:imported-modules `(,@%meson-build-system-modules
+                                (guix build python-build-system))
+           #:modules '((guix build meson-build-system)
+                       ((guix build python-build-system) #:prefix python:)
+                       (guix build utils))
+           #:glib-or-gtk? #t
+           #:phases
+           #~(modify-phases %standard-phases
+               (add-after 'unpack 'disable-gtk-update-icon-cache
+                 (lambda _
+                   (setenv "DESTDIR" "/")))
+               (add-after 'install 'wrap-program
+                 (lambda* (#:key outputs #:allow-other-keys)
+                   (wrap-program (search-input-file outputs "bin/lollypop")
+                     (list "GI_TYPELIB_PATH" ":" 'prefix
+                           (list (getenv "GI_TYPELIB_PATH"))))))
+               (add-after 'install 'wrap-python
+                 (assoc-ref python:%standard-phases 'wrap)))))
     (native-inputs
      (list gettext-minimal
            `(,glib "bin")               ; For glib-compile-resources
-- 
2.45.1

[bug#71944] [PATCH 0/2] gnu: lollypop: Update version and package style

[James Smith via Guix-patches via]

Hi,

I noticed that this patch series were pushed to master as
947d44f1b3e7dd312f69847d2b7ecb1fd3ac7a4a and
aaf157deb36880e6f7fe8c057b98302dca04c1dc, but this issue hasn't been
closed yet. Do I need to close it or is that the responsibility of the
committer?

James Smith

bug#71944: [PATCH 0/2] gnu: lollypop: Update version and package style

[Liliana Marie Prikler]

Am Samstag, dem 13.07.2024 um 06:21 -0700 schrieb James Smith:
> Hi,
> 
> I noticed that this patch series were pushed to master as
> 947d44f1b3e7dd312f69847d2b7ecb1fd3ac7a4a and
> aaf157deb36880e6f7fe8c057b98302dca04c1dc, but this issue hasn't been
> closed yet. Do I need to close it or is that the responsibility of
> the committer?
Rather than speak of responsibilities, I'd like to note that anyone
*may* close it.  For personal reasons, I just didn't find the time
directly after the push.

Cheers