From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id +PBcAED71mLF7wAAbAwnHQ (envelope-from ) for ; Tue, 19 Jul 2022 20:43:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id WAOBAED71mIi4wAA9RJhRA (envelope-from ) for ; Tue, 19 Jul 2022 20:43:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9E3D310608 for ; Tue, 19 Jul 2022 20:43:11 +0200 (CEST) Received: from localhost ([::1]:37910 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oDsBa-0006uI-Qu for larch@yhetil.org; Tue, 19 Jul 2022 14:43:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52050) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oDsBS-0006tu-1z for guix-patches@gnu.org; Tue, 19 Jul 2022 14:43:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:57383) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oDsBR-0007nv-PC for guix-patches@gnu.org; Tue, 19 Jul 2022 14:43:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oDsBR-0006t7-Jb for guix-patches@gnu.org; Tue, 19 Jul 2022 14:43:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#51427] [PATCH] nix: libstore: Do not remove unused links when deleting specific items. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 19 Jul 2022 18:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51427 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 51427@debbugs.gnu.org, Maxim Cournoyer , zimoun Received: via spool by 51427-submit@debbugs.gnu.org id=B51427.165825617626465 (code B ref 51427); Tue, 19 Jul 2022 18:43:01 +0000 Received: (at 51427) by debbugs.gnu.org; 19 Jul 2022 18:42:56 +0000 Received: from localhost ([127.0.0.1]:55142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDsBM-0006sm-FV for submit@debbugs.gnu.org; Tue, 19 Jul 2022 14:42:56 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:38458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oDsBH-0006sX-2p for 51427@debbugs.gnu.org; Tue, 19 Jul 2022 14:42:54 -0400 Received: by mail-ed1-f65.google.com with SMTP id m13so10665296edc.5 for <51427@debbugs.gnu.org>; Tue, 19 Jul 2022 11:42:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=fQhSnKBuF4ErKEQYGDwBUlwsidGnm3cm59Srzb5POms=; b=Dd1ZhRL/gKjvo+Tu6+7xjwUTryMn1K/rT2J1FsQibs2eZcxpzPPOLT2yNvU3ehVQpM mk7qa+dgp1r5jyR9IUs8bq6zwvEyLMrH+A0bDoDFNKQ2rDSFlIPC+QyjuqPEqXMZd2tb Qgqdj8HzMufE9rUVf1a/soFSHaKdLuhmIOey7zaSzfBAZtcTKa4UtoYFVZl5LfS/ZuY2 +Ne/LyGkjZMTppriLVeOZJ8VHfwnPEkkbPyyi7OyM6RMzXvnxTq3I87zLi5Ia9KuWME+ ekigjksdQ3Pezx1GDWNBDgxAiLOz0MLeCdmE68b5GLKObVSZeReLm1+sREiJd+YVOjfI l/ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=fQhSnKBuF4ErKEQYGDwBUlwsidGnm3cm59Srzb5POms=; b=F+GJhW0cB69KKQjG5VeM4Pro0TgTUiN6TtOkcM4xJtR3r9AzFwXpz0Zb9XaQIBV00x Ly2Ga2GXf8IDEba417vJrGeUtYfluuVSsW84/J2mMul2ynWTfsx9CEJ3M2MmLbuA+Z65 qW7vaXMke/bl73kkMoKg2B2f9RD6LRSjzHInfCBb25dw4dOcTnSIDQ0mWx+FL5CUm1yn W8yGDCDjtzC9juBOxiwOwvaYgUsl3TkBWtZas9hnDsJCtoNlg+PcXPyG8YaaLwHkmwsm V7rJl55zPAvjTl6TzK1qZvFNGG2ohwU7DFAm9oa9K49gQ6nCqNgFPhUJtYUmcPNbqBR5 WqMA== X-Gm-Message-State: AJIora+JiXtYMxgZJYTsUShaudF/kLz9QD5Hatp4m1py4yLs7YtdoFAU KfSJSCNN87UJMh1pThQinys= X-Google-Smtp-Source: AGRyM1tZqFRG5LnZyaAeQEqqBoi19Lb1tFAD5hJNy4eTda1YKC8OPNt6TjusGDM7fft2/l/aW2dBow== X-Received: by 2002:a05:6402:430f:b0:43a:d521:bda with SMTP id m15-20020a056402430f00b0043ad5210bdamr46831751edc.69.1658256163731; Tue, 19 Jul 2022 11:42:43 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id b18-20020a1709063cb200b00722f069fd40sm6929200ejh.159.2022.07.19.11.42.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Jul 2022 11:42:43 -0700 (PDT) Message-ID: <8538dc9925eb499ea2b728e349d98296eedeb14d.camel@gmail.com> From: Liliana Marie Prikler Date: Tue, 19 Jul 2022 20:42:42 +0200 In-Reply-To: <87sfmxv6ue.fsf@gnu.org> References: <20211027034918.4591-1-maxim.cournoyer@gmail.com> <87o8795j61.fsf@gnu.org> <5c2dd60acfaa7d74b7554babb3e223bc855bac8a.camel@gmail.com> <87h7cxp9tl.fsf@gnu.org> <87sfwg7w9z.fsf@gmail.com> <87ee7tmdbd.fsf@gnu.org> <86k0hhnqss.fsf@gmail.com> <871r3f2j7y.fsf@gnu.org> <867dd7roi2.fsf@gmail.com> <87o7xmy14l.fsf_-_@gnu.org> <2441c768fea8faee800947a17aef896c35173845.camel@gmail.com> <87sfmxv6ue.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1658256191; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=fQhSnKBuF4ErKEQYGDwBUlwsidGnm3cm59Srzb5POms=; b=BCuc682PqQBWOb2a7eKPxNglw06B+T3sNo0eZY5VHQGSs0QBS+jYCKNdUq0VzRrrUhovxn swS5v4cofQdToSw0u2urPvkXGlLLFJJPlkZRhhQmN1VNvV5gTUFLyjU4rr3QJK5mM1oLbG cFEW1rZxkRLMPfhxt2QTbzTwpD7TL9Zadb25Zzu2vPOPdnFaD36/TzqoRLTXrS5/9LvIn8 fI/UcOtZf/P6D8aHl476AzFvMhQ0MlzPIsXAHnksm9EoFBWvB+1TD32KWhs40uzGj4p5o4 mEW40Mr+OXeYy83b2VzyBCO5dwVJHvP5b1w49oiOdUgYhzTWfK2B0gXAs/5u9A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1658256191; a=rsa-sha256; cv=none; b=RDwN0zphQxVTluFePBf4Z0fdLY/CkBNVQHKvnPej+MZurOF14Gja5liVX3oK78cYa1I8TT ZbT/roUpxqetr5x2e/Jqj4UO2aKOrpN8KD0Jt3/1IqUsCGwaThNUrl8ahBL5FaBjXfC9Sm vF4rZhJLuTrnRCmovOMiY6ofDeGwLLY+pp3NhL+0ltPmQ5U9R0UlmKOHW/DTZQ5/fnS5zr mSwvxZbrZ7MjGH3kSToAR6KqPGrNvJhS8xgeRnXBto5W5dgDzMgygLiRaJ7l20KtQZZOWX u3xDVdOZ2Lq1XOqNIA2J6flOi2hN6eLlyL/8lpTg4QeOKlezIZ6heoTXlxZ5ig== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="Dd1ZhRL/"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 7.57 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="Dd1ZhRL/"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 9E3D310608 X-Spam-Score: 7.57 X-Migadu-Scanner: scn1.migadu.com X-TUID: z8LV6BwsDJt3 Am Dienstag, dem 19.07.2022 um 10:34 +0200 schrieb Ludovic Courtès: > Hi, > > Liliana Marie Prikler skribis: > > > Am Montag, dem 18.07.2022 um 15:57 +0200 schrieb Ludovic Courtès: > > > Hello, > > > > > > With commit 472a0e82a52a3d5d841e1dfad6b13e26082a5750 (Nov. 2021), > > > partially fixing , there is > > > hopefully less pressure to skip the remove-unused-links phase. > > > > > > Should we close this issue? > > As a hard disk user, I'm leaning towards "no". > > At the REPL, could you do: > >   ,use(ice-9 ftw) >   ,t (length (scandir "/gnu/store/.links")) > > ? > > On my SSD I get: > >   $4 = 438356 >   ;; 24.613712s real time, 10.195698s run time.  1.805636s spent in GC. scheme@(guile-user)> ,use (ice-9 ftw) scheme@(guile-user)> ,t (length (scandir "/gnu/store/.links")) $1 = 213027 ;; 1417.872747s real time, 28.514293s run time. 1.284866s spent in GC. scheme@(guile-user)> (/ 1417.872747 60) $2 = 23.63121245 So yeah, assuming that scandir scales linearly, if my store was as big as yours, I could eat lunch and GC still wouldn't be finished (for context, lunch breaks in my country are only 30 minutes).