unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: levenson@mmer.org
To: Leo Famulari <leo@famulari.name>
Cc: 39747@debbugs.gnu.org, Alexey Abramov <levenson@mmer.org>
Subject: [bug#39747] [PATCH 3/7] gnu: java-openjfx-graphics: Implement a complete compilation.
Date: Mon, 09 Mar 2020 14:08:02 +0100	[thread overview]
Message-ID: <84y2s9smkt.fsf@delta.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <20200304030012.GB1199@jasmine.lan> (Leo Famulari's message of "Tue, 3 Mar 2020 22:00:12 -0500")


I have updated the patch. 

Leo Famulari <leo@famulari.name> writes:

> On Sat, Feb 22, 2020 at 09:17:51PM +0100, Alexey Abramov wrote:
>> +           (name "java-openjfx-graphics")
>> +           (arguments
>> +            `(#:jar-name "java-openjfx-graphics.jar"
>
>> +              #:source-dir "modules/graphics/src/main/java"
>> +              #:tests? #f               ; requires X
>> +              #:test-dir "modules/graphics/src/test"
>> +              #:test-include (list "**/*Test.*")
>> +              #:modules ((guix build ant-build-system)
>> +                         (guix build utils)
>> +                         (srfi srfi-1)
>> +                         (srfi srfi-26)
>> +                         (ice-9 regex)
>> +                         (ice-9 match))
>
> [...]
>
> Wow, this might be one of the longest package definitions in Guix :)

Yeah, OpenJDK has two build instruction procedures for u8 and u9. I was
thinking about some helpers to reduce the amount of code but wasn't sure
if it's going to work/help for u9. My goal was to package davmail, so I
started packaging what I had been using to run it.

> I can't review it in detail but if it's working for you, okay. Just make
> sure to run `./pre-inst-env guix lint java-openjfx-graphics` and fix any
> cosmetic issues.

In my case it complains about:

1. Patch file name, which is added to the java-openjfx-build package. I
can rename it, but I am guessing it will start complaining on
java-openjfx-build. Bug? Or am I doing something wrong?

2. java-openjfx-build is not under Software Heritage, hence the
message.

3. Lines are too long, All lines are shorter than 120 for
sure. I would prefer to keep them as it is. It is easier to read. 

> Maybe some of the Guix Java experts can give it a closer review...

That would be great, cause I did build a lot of native libraries, but
not all of them. fontT2k for example which is a fallback library for
some fonts engines.

-- 
Alexey

  reply	other threads:[~2020-03-09 13:09 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-22 20:17 [bug#39742] [PATCH 1/7] gnu: java-openjfx-build: Add helpful patch Alexey Abramov
2020-02-22 20:17 ` [bug#39744] [PATCH 2/7] gnu: java-openjfx-build: Fix indentation Alexey Abramov
2020-02-22 20:17 ` [bug#39747] [PATCH 3/7] gnu: java-openjfx-graphics: Implement a complete compilation Alexey Abramov
2020-03-04  3:00   ` Leo Famulari
2020-03-09 13:08     ` levenson [this message]
2020-03-09 12:46   ` [bug#39747] [v2] " Alexey Abramov
2020-02-22 20:17 ` [bug#39745] [PATCH 4/7] gnu: java-openjfx-swing: Add new variable Alexey Abramov
2020-03-04  3:04   ` Leo Famulari
2020-03-09 22:08     ` [bug#39741] " levenson
2020-03-09 16:15   ` [bug#39745] [v2] gnu: java-openjfx-build: Fix openjfx-swing component build for JDKu8 Alexey Abramov
2020-03-09 16:36   ` [bug#39745] [v3 1/2] " Alexey Abramov
2020-03-09 16:36     ` [bug#39745] [v3 2/2] gnu: java-openjfx-swing: Add new variable Alexey Abramov
2020-03-11 10:36   ` [bug#39745] [v4 1/2] gnu: java-openjfx-build: Fix openjfx-swing component build for JDKu8 Alexey Abramov
2020-03-11 10:36     ` [bug#39745] [v4 2/2] gnu: java-openjfx-swing: Add new variable Alexey Abramov
2020-02-22 20:17 ` [bug#39741] [PATCH 5/7] gnu: java-openjfx-swt: " Alexey Abramov
2020-03-09 16:41   ` [bug#39741] [v2] " Alexey Abramov
2020-02-22 20:17 ` [bug#39743] [PATCH 6/7] gnu: java-openjfx-controls: " Alexey Abramov
2020-03-09 16:54   ` [bug#39743] [v2] " Alexey Abramov
2020-02-22 20:17 ` [bug#39746] [PATCH 7/7] gnu: java-openjfx-web: " Alexey Abramov
2020-03-04  3:07   ` Leo Famulari
2020-03-09 22:13     ` [bug#39741] " levenson
2020-03-17 22:17       ` Tobias Geerinckx-Rice via Guix-patches via
2020-03-09 21:41   ` [bug#39746] [v2 1/2] gnu: java-openjfx-build: Prepare a patch to build openjfx-web Alexey Abramov
2020-03-09 21:41     ` [bug#39746] [v2 2/2] gnu: java-openjfx-web: Add new variable Alexey Abramov
2020-03-14  6:10   ` [bug#39746] [v3 1/2] gnu: java-openjfx-build: Prepare a patch to build openjfx-web Alexey Abramov
2020-03-14  6:10     ` [bug#39746] [v3 2/2] gnu: java-openjfx-web: Add new variable Alexey Abramov
2020-03-04  2:56 ` [bug#39742] [PATCH 1/7] gnu: java-openjfx-build: Add helpful patch Leo Famulari
2020-03-05 20:42   ` Alexey Abramov
2020-03-05 19:09 ` Björn Höfling
2020-03-05 20:10   ` Alexey Abramov
2020-03-05 21:35   ` Björn Höfling
2020-03-08 19:40 ` [bug#39742] [v2] " Alexey Abramov
2020-03-15 18:19   ` bug#39742: " Leo Famulari
2020-03-17 21:12     ` [bug#39742] " Björn Höfling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84y2s9smkt.fsf@delta.i-did-not-set--mail-host-address--so-tickle-me \
    --to=levenson@mmer.org \
    --cc=39747@debbugs.gnu.org \
    --cc=leo@famulari.name \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).