From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:50471)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jBQa7-0003MB-DG
 for guix-patches@gnu.org; Mon, 09 Mar 2020 18:09:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jBQa6-0004ts-Cg
 for guix-patches@gnu.org; Mon, 09 Mar 2020 18:09:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:45587)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jBQa6-0004tj-9P
 for guix-patches@gnu.org; Mon, 09 Mar 2020 18:09:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jBQa6-0001aJ-4u
 for guix-patches@gnu.org; Mon, 09 Mar 2020 18:09:02 -0400
Subject: [bug#39741] [bug#39745] [PATCH 4/7] gnu: java-openjfx-swing: Add new
 variable.
Resent-Message-ID: <handler.39741.B39741.15837917066033@debbugs.gnu.org>
From: levenson@mmer.org
In-Reply-To: <20200304030417.GC1199@jasmine.lan> (Leo Famulari's message of
 "Tue, 3 Mar 2020 22:04:17 -0500")
References: <20200222201755.50425-1-levenson@mmer.org>
 <20200222201755.50425-4-levenson@mmer.org>
 <20200304030417.GC1199@jasmine.lan>
Date: Mon, 09 Mar 2020 23:08:14 +0100
Message-ID: <84v9ndp4fl.fsf@delta.i-did-not-set--mail-host-address--so-tickle-me>
MIME-Version: 1.0
Content-Type: text/plain
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: 39745@debbugs.gnu.org, 39741@debbugs.gnu.org, Alexey Abramov <levenson@mmer.org>


Thank you!

Leo Famulari <leo@famulari.name> writes:

> On Sat, Feb 22, 2020 at 09:17:52PM +0100, Alexey Abramov wrote:
>> * gnu/packages/java.scm (java-openjfx-build): Add patch to the base package.
>> * gnu/packages/patches/java-openjfx-build-swing-compile-JFXPanel-with-JDK-8.patch: Fix swing compilation for jdk8.
>
> This commit adds the patch file but also makes a new package
> java-openjfx-swing. Adding the patch to java-openjfx-build and adding
> the new package should be done in separate commits.

I split the change into two separated commits. v3

> Also remember to add the patch to 'gnu/local.mk'.
>
>> +From 173e65937d9e76872df51f7ba39c9d58986dc38f Mon Sep 17 00:00:00 2001
>> +From: Alexey Abramov <levenson@mmer.org>
>> +Date: Fri, 3 Jan 2020 01:17:45 +0100
>> +Subject: [PATCH] java-openjfx-build: Cannot compile JFXPanel with JDK 8
>> +
>> +For more info please see https://bugs.openjdk.java.net/browse/JDK-8149967
>
> This link is great but please add a brief summary of why we need the
> patch and what it does (one or two sentences is enough).

--
Alexey