unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Arun Isaac <arunisaac@systemreboot.net>, 54635@debbugs.gnu.org
Cc: Efraim Flashner <efraim@flashner.co.il>
Subject: [bug#54635] [PATCH 4/5] gnu: atomic-queue: Do not depend on boost when cross-compiling.
Date: Wed, 30 Mar 2022 13:49:35 +0200	[thread overview]
Message-ID: <848708b853ca9e04c6aa92f14021724dd23af025.camel@telenet.be> (raw)
In-Reply-To: <20220330092313.23584-4-arunisaac@systemreboot.net>

[-- Attachment #1: Type: text/plain, Size: 682 bytes --]

Arun Isaac schreef op wo 30-03-2022 om 14:53 [+0530]:
> * gnu/packages/cpp.scm (atomic-queue)[arguments]: When cross-compiling, add
> do-not-check-for-boost phase and delete the build phase.
> [native-inputs]: Do not include boost when cross-compiling.

I think it's simpler and less tedious to just always include test
dependencies in native-inputs, without special-casing cross-
compilation.  WYDT?

Also, being header-only does not per-se mean ‘no building’.  E.g., what
if some of the headers are generated?  I think it's a bit simpler and
less likely to cause trouble to just always run the build phase, even
if sometimes it is a no-op.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  reply	other threads:[~2022-03-30 11:51 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-30  9:19 [bug#54635] [PATCH 0/5] Add wfmash Arun Isaac
2022-03-30  9:23 ` [bug#54635] [PATCH 1/5] gnu: gsl: Force bootstrap when cross-compiling to riscv64-linux Arun Isaac
2022-03-30  9:23   ` [bug#54635] [PATCH 2/5] gnu: htslib: Add bzip2 and xz to inputs Arun Isaac
2022-03-30  9:23   ` [bug#54635] [PATCH 3/5] gnu: atomic-queue: Run tests correctly Arun Isaac
2022-03-30  9:23   ` [bug#54635] [PATCH 4/5] gnu: atomic-queue: Do not depend on boost when cross-compiling Arun Isaac
2022-03-30 11:49     ` Maxime Devos [this message]
2022-03-31  7:24       ` Arun Isaac
2022-03-30  9:23   ` [bug#54635] [PATCH 5/5] gnu: Add wfmash Arun Isaac
2022-03-30 11:33   ` [bug#54635] [PATCH 1/5] gnu: gsl: Force bootstrap when cross-compiling to riscv64-linux Maxime Devos
2022-03-31  6:14     ` Arun Isaac
2022-03-30 11:36   ` Maxime Devos
2022-03-30 11:39     ` Efraim Flashner
2022-03-31  6:33       ` Arun Isaac
2022-03-31 11:29         ` Maxime Devos
2022-03-31 12:35         ` Efraim Flashner
2022-03-31  7:28       ` [bug#54635] [PATCH v2 " Arun Isaac
2022-03-31  7:28       ` [bug#54635] [PATCH v2 2/5] gnu: htslib: Add bzip2 and xz to inputs Arun Isaac
2022-03-31  7:28       ` [bug#54635] [PATCH v2 3/5] gnu: atomic-queue: Run tests correctly Arun Isaac
2022-03-31  7:28       ` [bug#54635] [PATCH v2 4/5] gnu: atomic-queue: Do not look for boost when cross-compiling Arun Isaac
2022-03-31  7:28       ` [bug#54635] [PATCH v2 5/5] gnu: Add wfmash Arun Isaac
2022-03-31 11:34         ` Maxime Devos
2022-03-31 12:18           ` Efraim Flashner
2022-03-31 13:07             ` Maxime Devos
2022-03-31 13:09               ` Efraim Flashner
2022-03-31 13:31               ` bug#54635: " Efraim Flashner
2022-04-01  7:40                 ` [bug#54635] " Arun Isaac
2022-04-01  9:39                   ` Maxime Devos
2022-04-04 18:01                     ` Arun Isaac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=848708b853ca9e04c6aa92f14021724dd23af025.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=54635@debbugs.gnu.org \
    --cc=arunisaac@systemreboot.net \
    --cc=efraim@flashner.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).