From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id sBLbGz4DGmNTuwAAbAwnHQ (envelope-from ) for ; Thu, 08 Sep 2022 16:59:10 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id kDT4Gj4DGmNapgAAG6o9tA (envelope-from ) for ; Thu, 08 Sep 2022 16:59:10 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2463ADC25 for ; Thu, 8 Sep 2022 16:59:10 +0200 (CEST) Received: from localhost ([::1]:39676 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oWIzj-00035M-40 for larch@yhetil.org; Thu, 08 Sep 2022 10:59:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48580) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWIvn-0004nz-4s for guix-patches@gnu.org; Thu, 08 Sep 2022 10:55:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42918) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oWIvm-0001n2-Rf for guix-patches@gnu.org; Thu, 08 Sep 2022 10:55:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oWIvm-0005QX-GY for guix-patches@gnu.org; Thu, 08 Sep 2022 10:55:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#57655] [PATCH 5/5] gnu: telegram-desktop: Update to 4.1.1. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 08 Sep 2022 14:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57655 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Hilton Chain , 57655@debbugs.gnu.org Received: via spool by 57655-submit@debbugs.gnu.org id=B57655.166264885520798 (code B ref 57655); Thu, 08 Sep 2022 14:55:02 +0000 Received: (at 57655) by debbugs.gnu.org; 8 Sep 2022 14:54:15 +0000 Received: from localhost ([127.0.0.1]:59850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWIv0-0005PO-LS for submit@debbugs.gnu.org; Thu, 08 Sep 2022 10:54:14 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:34813) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWIuy-0005PB-7E for 57655@debbugs.gnu.org; Thu, 08 Sep 2022 10:54:13 -0400 Received: by mail-ed1-f65.google.com with SMTP id z21so14730937edi.1 for <57655@debbugs.gnu.org>; Thu, 08 Sep 2022 07:54:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date; bh=xi8bOpWcQaYez/z6o5gCPmKBqkyzbNfjXR1O+VoL9qI=; b=C/uOoXRYRQFd9XluqcRl418LSx3RX/dRmReLpcEIByXBRa6zYD2nV7l4xP3jMKaE/1 vryRvk58OJINj99bE7NffTEYNPBC0bQsobBjMHdPm+wCk9VbBOO+qLi+MQUpFnpEidFx EtiWNk/c5dXWLk3rmHCR18xvsX2lWI3m3I9ea4COfW+xHqaGp99IcOUfV2W6OH8JLQWd QK0nhNPF74nvMnfQKaEcCvaK4ZDQ5Ilz2C1l3i8/SPnQkrpObjrZtwUCBi92wMM23q1k dWxgAEjDtpycOLbxZYiASfKrpa9MfiSIc5/xPAAiivud6KU3ft5DzFF2AU606WXKhvFa 7Qdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date; bh=xi8bOpWcQaYez/z6o5gCPmKBqkyzbNfjXR1O+VoL9qI=; b=j6lU/Gt1zjzhBnxuqxvGAglVZaHfc/pKyZJdeYBsKawmndqeZFs6kuZW99YWl/Vwno KPt8/r8k76RSMZWkUN47K4Q37ExG2M9cYAkAVHYKsR7RPs+ujfv8GYCLjzF1Dgrx/dNm X0rQAz/RhT4x6At0u5yA+d4aX1QeHZeXNCkPM8Uq8GWvXKeSSHTEmQuh27ROIjcVWBWo knmiR6Ki8+PL1yn5emZLNq+ew8qBGbBP+8pJwAtxQtQ0P+eUIDVHA1zTc3MHJ+kPQy7C CAZFQLGip531h3SQrlLzmRcFm8zQzMw5oahV43npb2BBnifeTJa+LUBqP1C8pPnfG9he OxHg== X-Gm-Message-State: ACgBeo0SFG3OPiU0921Fy2+w2VfHkeYSLcF30IgL0t5qW6Qpk1SwLu9R R3jc1vdXFyFQMDUy+PZKPDY= X-Google-Smtp-Source: AA6agR7i+t2JzmZgv2M3/qTJR69rDVdY4gYK908nIbAZs9gcBuLhfrB5dyfPtgfFnAmgAzRgdk8pEA== X-Received: by 2002:aa7:c74d:0:b0:44f:d34:affb with SMTP id c13-20020aa7c74d000000b0044f0d34affbmr7124057eds.143.1662648846232; Thu, 08 Sep 2022 07:54:06 -0700 (PDT) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id f6-20020a0564021e8600b0043cc66d7accsm12411377edf.36.2022.09.08.07.54.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Sep 2022 07:54:05 -0700 (PDT) Message-ID: <8425a0cccd764c06a64580fd68cc85dc9722437a.camel@gmail.com> From: Liliana Marie Prikler Date: Thu, 08 Sep 2022 16:54:05 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1662649150; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=xi8bOpWcQaYez/z6o5gCPmKBqkyzbNfjXR1O+VoL9qI=; b=SK/QLCe66/pVvm8eQOnuCcgZ0RtnbN2TJRJTE6uGVVLkbqwaWe7R9chEfFGq+xHXyJrA3J MCgjyRsTgJMHtd5F1z1hl44QDdTOYkizuy6j/G6blZt2YnWpgXzeHHxEArIbz8XUqe1/Z5 RSm0N1Mlrg3dlJlxPNB9eHwZ+g5ispqMO/WmS7BcPETzNlBJjdDH0k7jsil6vLzIK3ChV5 EIO1Bq5jkNib74C8JpEnlrcBp6F1/5aatPfydcV03Hn08fBieYQ3OPN1wFbvXpQtOG5Skj UPZIruqimfZEwKt6S4wAwwRhf05RZbaMWdud66heLm5pLRaJqroROfuvTX6auw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1662649150; a=rsa-sha256; cv=none; b=YFtiOCHfTvNj4Rotb6khlHlfiTlMyMOmgI+ec3H+KbNVx5JMmghTUNqDg9PaIyEHe2jRLQ Aic53h2j32zi0CBvwPpvtehC0duYE/9OVOqkk3oUT4ulFVDLjG/kO2iTCEeFoiuNqIMExM M2yivwrEO5humXxXjWqx8AJcwsOBUBEBaZ7RouoB5HZdA6FHrmRLfk6X9jQMCAXHpbu1YP NZ2224x8FUF4mdVO6iD/RY4mLi43O3dHwYpomj6l2OtNu/PIlikqjKts6BatVTAVs+YP1q n2mDe0dipTFPT2ARub90u6KWEDVEU1aPpOXqJI/tJaSuARb2zJ1dKl/NEMhrzQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="C/uOoXRY"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 6.22 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b="C/uOoXRY"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 2463ADC25 X-Spam-Score: 6.22 X-Migadu-Scanner: scn1.migadu.com X-TUID: MvuZ32n/fQSc Am Donnerstag, dem 08.09.2022 um 08:59 +0800 schrieb Hilton Chain: > > * gnu/packages/telegram.scm (telegram-desktop): Update to 4.1.1. > [snippet]: > Don't keep SPMediaKeyTap and statusnotifieritem as they'd got removed > from > upstream. > Keep rlottie, libtgvoip and dispatch. Why keep rlottie and libtgvoip? We had packages for those (which fair enough, you removed, but still...) > [#:configure-flags]: > Comment out to default value > Use API id from official Snap builds. SGTM. > Enable DESKTOP_APP_USE_PACKAGED_LAZY, which is suitable for default > configuration as it'll bundle as many features as possible. > [#:phases]: > Copy dispatch, fcitx-qt5, fcitx5-qt, hime, nimf, rlottie and > libtgvoip. We should *unbundle* those, not make the bundling worse. > Remove phase patch-cxx-flags, as that string's not there any more. > Replace build and install phases with ones that use cmake tools. Like with webrtc, use ninja if you like it better, but prefer invoking it as ninja :) > [native-inputs] > Add variable external-sources for managing recursive checkouts. > Bump cmake-helpers to source checkout-ed commit. > Add ninja and clang-toolchain. > [inputs] > Add variable external-sources for managing recursive checkouts. > Add dispatch, fcitx-qt5, fcitx5-qt, hime, nimf, rlottie, libtgvoip to > external-sources. > Bump codegen, lib_base, lib_crl, lib_lottie, lib_qr, lib_rpl, > lib_spellcheck, > lib_storage, lib_tl, lib_ui, lib_waylandshells, lib_webrtc, > lib_webview and > tgcalls to source checkout-ed commit. > Add patch for lib_base to support musl compilation. > Style adjustment. I didn't mention this in 2/5, but try separating style changes from code changes. > [license] > Update with source tree changes. > > * gnu/packages/patches/lib-base-for-telegram-desktop-support- > musl.patch: New > file. > * gnu/local.mk: Add patch. > --- Again, avoid gratuitous vertical spaces, mention patches by name, yadda yadda. So I'm aware you're going to do a v2 anyway due to some tabs vs spaces issue, but I wanted you to know that there are more things to fix :) Cheers