unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Hartmut Goebel <h.goebel@crazy-compilers.com>
To: Thomas Danckaert <post@thomasdanckaert.be>
Cc: 28720@debbugs.gnu.org
Subject: [bug#28720] [PATCH 08/23] gnu: phonon: Enable building the Qt Designer plugin.
Date: Fri, 6 Oct 2017 16:31:13 +0200	[thread overview]
Message-ID: <8420006b-e275-c59f-4353-e6d581c56c25@crazy-compilers.com> (raw)
In-Reply-To: <cuc8tgobcht.fsf@thomasdanckaert.be>

Hallo Thomas,

thanks for reviewing to quickly :-)

Am 06.10.2017 um 16:02 schrieb Thomas Danckaert:
> Hartmut Goebel <h.goebel@crazy-compilers.com> writes:
>
>> * gnu/packages/kde-frameworks.scm (phonon): [native-inputs]: Add pkg-config,
>>   qttools.  [arguments]<#configure-flags>: Remove
>>   PHONON_INSTALL_QT_EXTENSIONS_INTO_SYSTEM_QT
> I'm not sure what this does (or: used to do), so I don't know if this
> removal needs a further comment.

Without this change the Phonon Qt-Extension would be installed into
/gnu/store/…-qtbase-…/. I'll add this to the change
>> +     ;; TODO: Add bulding the super experimental QML support
> There's a typo in your TODO ;-)

Well spotted.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

  reply	other threads:[~2017-10-06 14:32 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-06 12:14 [bug#28720] [PATCH 00/23] Enhance building KDE Frameworks Hartmut Goebel
2017-10-06 12:16 ` Hartmut Goebel
2017-10-06 12:16   ` [bug#28720] [PATCH 01/23] gnu: grantlee: Enable all tests Hartmut Goebel
2017-10-06 12:16   ` [bug#28720] [PATCH 02/23] gnu: qtkeychain: Reduce the number of warnings when configuring Hartmut Goebel
2017-10-06 12:16   ` [bug#28720] [PATCH 03/23] gnu: Update prison to 5.37.0 Hartmut Goebel
2017-10-06 12:16   ` [bug#28720] [PATCH 04/23] gnu: kcoreaddons: Add native-input shared-mime-info and a comment Hartmut Goebel
2017-10-06 12:16   ` [bug#28720] [PATCH 05/23] gnu: kconfigwidgets: Add optional native-input kdoctools Hartmut Goebel
2017-10-06 12:16   ` [bug#28720] [PATCH 06/23] gnu: kwallet: Add optional input qgpgme Hartmut Goebel
2017-10-06 12:16   ` [bug#28720] [PATCH 07/23] gnu: kdesignerplugin: Add optional inputs Hartmut Goebel
2017-10-06 14:12     ` Thomas Danckaert
2017-10-06 14:37       ` Hartmut Goebel
2017-10-06 12:16   ` [bug#28720] [PATCH 08/23] gnu: phonon: Enable building the Qt Designer plugin Hartmut Goebel
2017-10-06 14:02     ` Thomas Danckaert
2017-10-06 14:31       ` Hartmut Goebel [this message]
2017-10-06 12:16   ` [bug#28720] [PATCH 09/23] gnu: kdnssd: Enable service discovery on local network via avahi Hartmut Goebel
2017-10-06 12:16   ` [bug#28720] [PATCH 10/23] gnu: kfilemetadata: Enable support for PDF files and audio files Hartmut Goebel
2017-10-06 14:04     ` Thomas Danckaert
2017-10-06 14:32       ` Hartmut Goebel
2017-10-06 12:16   ` [bug#28720] [PATCH 11/23] gnu: bluez-qt: Install udev-rules Hartmut Goebel
2017-10-06 12:16   ` [bug#28720] [PATCH 12/23] gnu: bluez-qt: Add comment about status of tests Hartmut Goebel
2017-10-06 12:16   ` [bug#28720] [PATCH 13/23] gnu: kparts: Make tests pass again Hartmut Goebel
2017-10-06 12:16   ` [bug#28720] [PATCH 14/23] gnu: kio: Remove unused input Hartmut Goebel
2017-10-06 12:16   ` [bug#28720] [PATCH 15/23] gnu: kio: Adopt a patch from Nix Hartmut Goebel
2017-10-06 12:16   ` [bug#28720] [PATCH 16/23] gnu: kio: Symlink some files referred to by different names Hartmut Goebel
2017-10-06 12:16   ` [bug#28720] [PATCH 17/23] gnu: kidletime: Enable fallback mode to X-Screensaver based poller Hartmut Goebel
2017-10-06 14:08     ` Thomas Danckaert
2017-10-06 14:35       ` Hartmut Goebel
2017-10-07 17:40         ` Thomas Danckaert
2017-10-06 12:16   ` [bug#28720] [PATCH 18/23] gnu: sonnet: Reduce the number of warnings when configuring Hartmut Goebel
2017-10-06 12:16   ` [bug#28720] [PATCH 19/23] gnu: kglobalaccel: " Hartmut Goebel
2017-10-06 12:16   ` [bug#28720] [PATCH 20/23] gnu: kdeclarative: " Hartmut Goebel
2017-10-06 12:16   ` [bug#28720] [PATCH 21/23] gnu: Add kdewebkit Hartmut Goebel
2017-10-06 12:16   ` [bug#28720] [PATCH 22/23] gnu: ktexteditor: Symlink some files referred to by different names Hartmut Goebel
2017-10-06 12:16   ` [bug#28720] [PATCH 23/23] gnu: kdoctools: " Hartmut Goebel
2017-10-06 14:16   ` [bug#28720] [PATCH 00/23] Enhance building KDE Frameworks Thomas Danckaert
2017-10-06 14:59     ` Hartmut Goebel
2017-10-10  6:47       ` Thomas Danckaert
2017-10-13 13:42 ` bug#28720: merged Hartmut Goebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8420006b-e275-c59f-4353-e6d581c56c25@crazy-compilers.com \
    --to=h.goebel@crazy-compilers.com \
    --cc=28720@debbugs.gnu.org \
    --cc=post@thomasdanckaert.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).