From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YPCYJc+Il2FJUQAAgWs5BA (envelope-from ) for ; Fri, 19 Nov 2021 12:21:51 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id KD50IM+Il2ElFAAAB5/wlQ (envelope-from ) for ; Fri, 19 Nov 2021 11:21:51 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DE4F93748E for ; Fri, 19 Nov 2021 12:21:50 +0100 (CET) Received: from localhost ([::1]:54980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mo1xm-0000Iu-3T for larch@yhetil.org; Fri, 19 Nov 2021 06:21:50 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46794) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mo1x1-0000Fb-3p for guix-patches@gnu.org; Fri, 19 Nov 2021 06:21:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54912) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mo1x0-0001IH-RS for guix-patches@gnu.org; Fri, 19 Nov 2021 06:21:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mo1x0-0005Zg-N1 for guix-patches@gnu.org; Fri, 19 Nov 2021 06:21:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51091] [PATCH v3] guix: opam: Do not fail when refreshing. Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 19 Nov 2021 11:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51091 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 51091@debbugs.gnu.org, Xinglu Chen Received: via spool by 51091-submit@debbugs.gnu.org id=B51091.163732081221322 (code B ref 51091); Fri, 19 Nov 2021 11:21:02 +0000 Received: (at 51091) by debbugs.gnu.org; 19 Nov 2021 11:20:12 +0000 Received: from localhost ([127.0.0.1]:38223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mo1wC-0005Xq-Dh for submit@debbugs.gnu.org; Fri, 19 Nov 2021 06:20:12 -0500 Received: from lepiller.eu ([89.234.186.109]:39260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mo1w9-0005XY-Uo for 51091@debbugs.gnu.org; Fri, 19 Nov 2021 06:20:11 -0500 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 12b20705; Fri, 19 Nov 2021 11:20:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:in-reply-to:references:message-id:mime-version :content-type:content-transfer-encoding; s=dkim; bh=FY5R0bS+lXt4 w0eRVHzkxGeGeiCGSNWGeIvkDrFZ19k=; b=BRXoZI9Xn/w4DYwmrhR0O33dvRmT 3n7lf3zfLf/9C5mGrZFwt35vvOe7ydSOWVtBPNSIXVLDWEjrn1Y94+l0EqpOiigm SP8/lg/rnRDUhks+JdupEvqL57INeC5Ockj1Z35TyxmkaXCxS7BzSruAfMs+qj73 0ziTii+AZmyP2lLFQKTu3oLKs7yOuVn5dowdjIJmUEG+1wNZeQmI5JUkIRg/vsoK 2H05ZY8K4hUpUcRo5WlaBPtPYD26GdZA4LNwdkhor4ltucVk4R6tQorYYa4cGldg BiHnNUV/y91uHr2Ur1rbFLVSrdYKh/zNjk9PgQRdCmqwtfeOqaljog84+g== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 531bcd0c (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Fri, 19 Nov 2021 11:20:06 +0000 (UTC) Date: Fri, 19 Nov 2021 06:19:56 -0500 From: Julien Lepiller User-Agent: K-9 Mail for Android In-Reply-To: <87czmwo68f.fsf@gnu.org> References: <20211008050310.407d6b23@tachikoma.lepiller.eu> <87y272lepg.fsf@yoctocell.xyz> <871r4nrc9t.fsf_-_@gnu.org> <20211016041009.5b4ddff0@tachikoma.lepiller.eu> <87sfwybuc7.fsf@gnu.org> <20211119021646.03e85542@tachikoma.lepiller.eu> <87czmwo68f.fsf@gnu.org> Message-ID: <83620617-04DC-472D-80B8-300044832A37@lepiller.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1637320911; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=twIcfw6E/+xN6yqikwGIxb/3sDlSubwlBUWXvdI2w/w=; b=nx6jQtpuXeeIG5VaDiwHM/1e1G7om4fTwr26/BoA2AKQq+JHfBe9Apw7lRkkmknQJmv5BK f69tkln7c/uiHuDXM+QdK+5GqGtVlovG3ODuCUUGZFftemk6/jQeYs/q2XcK+C2bhFOY/3 qFnEe6JSCKhYwL28lGZUaNKnw6+S7BgmdbtU9in/2961kWefxAAK2vSRkZYNlb+nEBvF0Q OBNMA3NS8JYsCUsbzY8TjNfRv9fCm8kXDo0OFpar0Hnm0o+sBniwHsA3UVMOtB9CCdkUKZ Ybeaso3979H3Q1+w8Lq7CpyR68dhQCDbYu82wN3KE8A3E2EklRNXhwJ+D0vZxA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1637320911; a=rsa-sha256; cv=none; b=WAbeupEnlQNhFPzoL3ScOtR2jh5j+/cGz6JVftQLCZXFAp/myYwZro2ruT/+W+RK8vuV8H 8mHfgrjZcnHaOq8WeDJ6DtYM8cEusrZ2XKqLsD9Sw395LZcZmA6I8s+4lV5BHYgi16nImV bqyqYJYzi//kXclPtaizs84ndwsQLw6BTB7fL5RbQJ+u6Hn0YUDCrJDBQkbjdVYcI4ighn GAiSJ5DfEC08PLOQL2yrDs5B21BVznTjBnKUwKvCuJWeairZXHpKVXs78vXZ9Yl6cYMDCQ DUG4r2lszMnnVfzcTRzQcMCLDOoR6+MXdDTWoEFtczZHNAwyMYCRUBQmAcAosA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=BRXoZI9X; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.76 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=BRXoZI9X; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: DE4F93748E X-Spam-Score: -1.76 X-Migadu-Scanner: scn1.migadu.com X-TUID: FJMGqtHizpvh Le 19 novembre 2021 04:16:32 GMT-05:00, "Ludovic Court=C3=A8s" a =C3=A9crit=C2=A0: >Hi, > >Julien Lepiller skribis: > >> I forgot to remove the catch #t around the whole body of the function= =2E >> I noticed that guard* was raising &non-continuable so I tried to fix it >> by using raise-continuable from (ice-9 exceptions)=2E Is this the corre= ct >> solution? > >I suppose, though I=E2=80=99m not sure why it needs to be continuable: yo= u could >just catch the exception and move on to the next package? I don't understand how to catch the exception though, unless you mean wrap= everything with catch #t, which kinda defeats the purpose of having a cond= ition in the first pjace=2E guard* raises &non-continuable unless the condi= tion is continuable, or I'm missing something in the way I use it=2E I have= no idea what a continuable exception is, so let me just push the other pat= ch=2E (guard* (c ((opam-error? c) #f))) (raise (condition (&opam-error =E2=80=A6)))) Doesn't return #f as I expect, but raises &non-continuable=2E > >> From a60e2ca645f4f8a6da72111d047f8cbb41ebe3e6 Mon Sep 17 00:00:00 2001 >> Message-Id: >> From: Julien Lepiller >> Date: Fri, 8 Oct 2021 04:58:27 +0200 >> Subject: [PATCH] import: opam: Do not fail when refreshing=2E >> >> Because we throw an error when a package is not in the opam repository, >> the updater would crash when encountering a package that is not in opam >> but uses the ocaml-build-system, such as opam itself=2E This catches t= he >> error and continues without updating said package, and lets us update >> the rest of the packages=2E >> >> * guix/scripts/import/opam=2Escm (guix-import-opam): Catch not-found >> condition and leave=2E >> * guix/import/opam=2Escm (&opam-not-found-error): New condition type=2E >> (opam-fetch): Raise condition instead of leaving=2E >> (latest-release): Catch not-found condition and warn=2E >> (conditional): Rename from `condition'=2E >> * tests/opam=2Escm (parse-conditions): Change accordingly=2E > >[=2E=2E=2E] > >zimoun skribis: > >> I think is simpler and fix the= same thing=2E > >I=E2=80=99m fine either way=2E I think there=E2=80=99s value longer-term= in having >structured exceptions in importers, though=2E > >Julien: your call! Hopefully someone smarter than me can figure it out=2E I'll push the other= patch, although I don't like the double warning in the updater=2E > >Thanks, >Ludo=E2=80=99=2E