From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id SeU4HCnNk2A4JAEAgWs5BA (envelope-from ) for ; Thu, 06 May 2021 13:04:09 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id sIRjFynNk2ClFAAA1q6Kng (envelope-from ) for ; Thu, 06 May 2021 11:04:09 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2A79521413 for ; Thu, 6 May 2021 13:04:08 +0200 (CEST) Received: from localhost ([::1]:51082 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lebnb-0004hh-9I for larch@yhetil.org; Thu, 06 May 2021 07:04:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37120) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lebnW-0004h6-GX for guix-patches@gnu.org; Thu, 06 May 2021 07:04:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54074) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lebnW-0007TY-6Z for guix-patches@gnu.org; Thu, 06 May 2021 07:04:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lebnW-00057m-2V for guix-patches@gnu.org; Thu, 06 May 2021 07:04:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47824] [PATCH 0/3] Happy hacking in the Spring 2021 LGJ Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 06 May 2021 11:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47824 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 47824@debbugs.gnu.org, efraim@flashner.co.il Received: via spool by 47824-submit@debbugs.gnu.org id=B47824.162029901419685 (code B ref 47824); Thu, 06 May 2021 11:04:02 +0000 Received: (at 47824) by debbugs.gnu.org; 6 May 2021 11:03:34 +0000 Received: from localhost ([127.0.0.1]:37387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lebn4-00057R-20 for submit@debbugs.gnu.org; Thu, 06 May 2021 07:03:34 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:12263) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lebn0-00057L-9E for 47824@debbugs.gnu.org; Thu, 06 May 2021 07:03:31 -0400 Received: from nijino.local (91-114-247-246.adsl.highway.telekom.at [91.114.247.246]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4FbW0F5mzWz3xMn; Thu, 6 May 2021 13:03:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1620299006; bh=Vcvk4ora6rVw/se4HofFwBx4KW4I26QpXrP7ETtsKyQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=r/mpms/Mswks4EwN6jecxnfCj5HZIHeag6MPywcNuQRgOnyVBXkSkNLHqWZVC9KUF sboKe3PEe8KCQw+WVjaXGshch3fZtabo2CIr0t2mD8B8AwT2qsCpE4TPAIelxKu/Nj vmteJdN5pnDHp6x4nt/gJ+G5xEEjAI1QclDTLnyU= Message-ID: <82ad8a0c2757ff74694e8c83eb528cf84c59855e.camel@student.tugraz.at> From: Leo Prikler Date: Thu, 06 May 2021 13:03:24 +0200 In-Reply-To: <875yzwgmmg.fsf@gnu.org> References: <20210419081744.7247-1-leo.prikler@student.tugraz.at> <20210419081744.7247-3-leo.prikler@student.tugraz.at> <874kfhjmfd.fsf_-_@gnu.org> <867322166b5492fe1964df02db2b4d148ade29dd.camel@student.tugraz.at> <875yzwgmmg.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620299048; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=Vcvk4ora6rVw/se4HofFwBx4KW4I26QpXrP7ETtsKyQ=; b=XdxYa6rbdrWpjeSqaAJdyf1Qn9ow54mbT6mW+F1LL1ZHZsuCpMeDhCDQUyHMhMqXus4+yO yO6+X6AOsQ6d6PrQ3t/LmnPDm/S9F1cdYC5Wiq6KncDp0XTt7yX/kLYNdtAvFWotlub4N9 2nhDTuK1c6aneTgNpQ2AtJaIbJ0LQvvg4j178BWKvLk3sLKqzTYuot+tMdQFFRzDqqTJc8 LEaqPcJPjTgyt4/uUR+7qWOHXYi7wJK9g3bKSJBw0G+3zKs1byFxWG6V4Xx0nvPCxm1DUk VwvplWPnZT3Ey4oiuR5snpphzAMAMJRJ2p6saE8cpngAzNjGwAuG0IvMrO9RxQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620299048; a=rsa-sha256; cv=none; b=PBVZhRPN41vxZrrf2Z5Qq45rKW67wgWFlLvsG9k5B6xMhSa+alDtYTe2P4qrzReSmIH9st SzPNpRgP42W9BynxgoYHVI4zv8pnkk6Pkb+XnxJczGmwf19thiHwoUk24Fegb2ulN6i9lZ S6DHkta3veCu9yG0s+WFKdGsh5FGmfBpX8nOvpSDMS0KpwGaZ53p77etWUBVQkz9fwIJl5 00UNjBYms+Xb3snhkEuDg5+yCoXZVzK4IQO1sWtEZJ1MSjX0Si9XyRd7gbVn7+MI41miHW xS9tGQjrdakcSb3etDoGVPLq2gMfFjyZ5uhv2z2mLbuGJmC54OQGhQ7O/TBtnQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b="r/mpms/M"; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.14 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b="r/mpms/M"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 2A79521413 X-Spam-Score: 0.14 X-Migadu-Scanner: scn0.migadu.com X-TUID: 5wYhYD/Hn/+P Am Donnerstag, den 06.05.2021, 12:52 +0200 schrieb Ludovic Courtès: > Hi, > > Leo Prikler skribis: > > > Am Mittwoch, den 05.05.2021, 16:16 +0200 schrieb Ludovic Courtès: > > > Hi Leo, > > > > > > On a cursory look, all three patches LGTM. > > > > > > One nit: > > > > > > > + "exec " > > > > + (assoc-ref inputs "guile-runtime") > > > > + "/bin/guile " args))) > > > > > > [...] > > > > > > > ("guile" ,guile-3.0) > > > > ("pkg-config" ,pkg-config) > > > > ("texinfo" ,texinfo))) > > > > - (propagated-inputs > > > > - `(("guile-sdl2" ,guile3.0-sdl2))) > > > > + (inputs > > > > + `(("guile-sdl2" ,guile3.0-sdl2) > > > > + ("guile-runtime" ,guile-3.0))) > > > > > > I think it’s best to not play trick with labels, and to always > > > use > > > the > > > package name as the label (to facilitate migration on the day > > > where > > > we > > > get rid of labels, who knows…). > > > > > > A common pattern for the case above is to provide “guile” both as > > > native > > > input and input, and to write: > > > > > > (assoc-ref (or native-inputs inputs) "guile") > > What I'm doing here is the exact opposite. I don't want the > > omnipresent native-input guile to shadow the guile I use as input, > > In that case, you can unconditionally do: > > (assoc-ref inputs "guile") > > Unless I’m mistaken, it won’t be shadowed by the native input “guile” > when cross-compiling. > > Or am I missing something? Perhaps it's an implementation detail, that when performing native builds, inputs are merged as (append inputs native-inputs), but they could as well be (append native-inputs inputs). I'd have to check, and I'm not sure whether I want to rely on that detail. Regards, Leo