unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: antlers <autumnalantlers@gmail.com>,
	56057@debbugs.gnu.org, antlers@luris.net
Subject: [bug#56057] [gnu: Add dua-cli. 23/27] gnu: Add rust-clap-derive-3.
Date: Sat, 18 Jun 2022 22:17:42 +0200	[thread overview]
Message-ID: <829df0f0a945554d749c9dfbcf2524da281903c4.camel@telenet.be> (raw)
In-Reply-To: <20220618195656.10108-24-antlers@luris.net>

[-- Attachment #1: Type: text/plain, Size: 1605 bytes --]

A patch has already been written for rust-clap-derive-3:
<https://issues.guix.gnu.org/56037>.  That patch series also adds rust-
clap-lex, so some inheritance may be in order.

On rust-windows-... crates: these crates are unnecessary in Guix.
If a package complains about not finding the dependencies, you can just
remove the dependency declaration from the Cargo.toml

Likewise, #56037 already updates rust-textwrap.

Also, rust-adler is already in Guix, so you can use inheritance there.

Why is there a separate rust-autocfg-1.1, instead of updating
rust-autocfg@1.0 to rust-autocfg@1.1?

In rust-object: why change the inheritance?

In rust-once-cell-1: Why remove the skip-build?  Also, you removed some
dependencies (rust-crossbeam-utils, rust-lazy-static and rust-regex),
but they are still used, according to
<https://github.com/matklad/once_cell/blob/v1.12.0/Cargo.toml>.

Also, if you're willing to wait a bit or help out, I've been working on
simplifying the Rust packaging system in
<https://notabug.org/maximed/cargoless-rust-experiments/>.

(TBC: only some quick comments, didn't look in any detail)

> +     `(#:tests? #f ; missing files

Then you can add the missing files.

> +    (synopsis
> +     "Tool to conveniently learn about the disk usage of
> directories, fast!")
> +    (description
> +     "This package provides a tool to conveniently learn about the
> disk usage of
> +directories, fast!")

Is markety, and the synopsis and description just contain the same
information.  See (guix)Synopses and Descriptions.

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  reply	other threads:[~2022-06-18 20:21 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-18 19:56 [bug#56057] [PATCH 00/27] gnu: Add dua-cli antlers
2022-06-18 19:56 ` [bug#56056] [gnu: Add dua-cli. 01/27] gnu: Add rust-addr2line-0.17 antlers
2022-06-18 19:56 ` [bug#56061] [gnu: Add dua-cli. 02/27] gnu: Add rust-adler-1 antlers
2022-06-18 19:56 ` [bug#56059] [gnu: Add dua-cli. 03/27] gnu: Add rust-crossterm-0.22 antlers
2022-06-18 19:56 ` [bug#56062] [gnu: Add dua-cli. 04/27] gnu: rust-clap-3: Update to 3.2.4 antlers
2022-06-18 19:56 ` [bug#56058] [gnu: Add dua-cli. 05/27] gnu: Add rust-autocfg-1.1 antlers
2022-06-18 19:56 ` [bug#56060] [gnu: Add dua-cli. 06/27] gnu: Add rust-parking-lot-0.12 antlers
2022-06-18 19:56 ` [bug#56063] [gnu: Add dua-cli. 07/27] gnu: rust-lock-api-0.4: Update to 0.4.7 antlers
2022-06-18 19:56 ` [bug#56064] [gnu: Add dua-cli. 08/27] gnu: Add rust-crossterm-winapi-0.8 antlers
2022-06-18 19:56 ` [bug#56065] [gnu: Add dua-cli. 09/27] gnu: Add rust-crosstemion-0.9 antlers
2022-06-18 19:56 ` [bug#56066] [gnu: Add dua-cli. 10/27] gnu: Add rust-gimli-0.26 antlers
2022-06-18 19:56 ` [bug#56069] [gnu: Add dua-cli. 11/27] gnu: Add rust-jwalk-0.6 antlers
2022-06-18 19:56 ` [bug#56067] [gnu: Add dua-cli. 12/27] gnu: Add rust-miniz-oxide-0.5 antlers
2022-06-18 19:56 ` [bug#56074] [gnu: Add dua-cli. 13/27] gnu: Add rust-object-0.28 antlers
2022-06-18 19:56 ` [bug#56068] [gnu: Add dua-cli. 14/27] gnu: rust-once-cell-1: Update to 1.12.0 antlers
2022-06-18 19:56 ` [bug#56073] [gnu: Add dua-cli. 15/27] gnu: Add rust-open-3 antlers
2022-06-18 19:56 ` [bug#56072] [gnu: Add dua-cli. 16/27] gnu: Add rust-parking-lot-core-0.9 antlers
2022-06-18 19:56 ` [bug#56070] [gnu: Add dua-cli. 17/27] gnu: Add rust-pretty-assertions-1.2 antlers
2022-06-18 19:56 ` [bug#56071] [gnu: Add dua-cli. 18/27] gnu: Add rust-simd-adler32-0.3 antlers
2022-06-18 19:56 ` [bug#56057] [gnu: Add dua-cli. 19/27] gnu: rust-sysctl-0.23: Update to 0.23.15 antlers
2022-06-18 19:56 ` [bug#56057] [gnu: Add dua-cli. 20/27] gnu: Add rust-textwrap-0.15 antlers
2022-07-24 21:59   ` [bug#56074] " Aleksandr Vityazev
2022-06-18 19:56 ` [bug#56057] [gnu: Add dua-cli. 21/27] gnu: Add rust-tui-0.17 antlers
2022-06-18 19:56 ` [bug#56057] [gnu: Add dua-cli. 22/27] gnu: Add rust-tui-react-0.18 antlers
2022-06-18 19:56 ` [bug#56057] [gnu: Add dua-cli. 23/27] gnu: Add rust-clap-derive-3 antlers
2022-06-18 20:17   ` Maxime Devos [this message]
2022-06-18 19:56 ` [bug#56057] [gnu: Add dua-cli. 24/27] gnu: Add rust-clap-lex-3 antlers
2022-06-18 19:56 ` [bug#56057] [gnu: Add dua-cli. 25/27] gnu: Add rust-windows-sys-0.36 & per-target varitations antlers
2022-06-20 11:15   ` Maxime Devos
2022-06-20 11:15   ` Maxime Devos
2022-06-20 11:17   ` Maxime Devos
2022-06-21 16:56     ` antlers
2022-06-18 19:56 ` [bug#56057] [gnu: Add dua-cli. 26/27] gnu: rust-backtrace-0.3: Update to 0.3.65 antlers
2022-06-18 19:56 ` [bug#56057] [gnu: Add dua-cli. 27/27] gnu: Add dua-cli antlers
2022-06-18 20:01 ` [bug#56057] " antlers
2022-06-19  8:10 ` [bug#56057] [PATCH 00/27] " ( via Guix-patches via
2022-06-19  8:51 ` Maxime Devos
2022-06-19  9:04 ` Maxime Devos
2022-06-19 17:26   ` [bug#56057] [bug #56057] " antlers
2022-06-19 17:26     ` [bug#56057] [bug #56057] [PATCH v2 01/21] gnu: Add rust-addr2line-0.17 antlers
2022-06-19 17:26     ` [bug#56057] [bug #56057] [PATCH v2 02/21] gnu: Add rust-adler-1 antlers
2022-06-19 17:26     ` [bug#56057] [bug #56057] [PATCH v2 03/21] gnu: Add rust-crossterm-0.22 antlers
2022-06-19 17:26     ` [bug#56057] [bug #56057] [PATCH v2 04/21] gnu: rust-autocfg-1: Update to 1.1 antlers
2022-06-19 17:26     ` [bug#56057] [bug #56057] [PATCH v2 05/21] gnu: Add rust-parking-lot-0.12 antlers
2022-06-19 17:26     ` [bug#56057] [bug #56057] [PATCH v2 06/21] gnu: rust-lock-api-0.4: Update to 0.4.7 antlers
2022-06-19 17:26     ` [bug#56057] [bug #56057] [PATCH v2 07/21] gnu: Add rust-crossterm-winapi-0.8 antlers
2022-06-19 17:26     ` [bug#56057] [bug #56057] [PATCH v2 08/21] gnu: Add rust-crosstemion-0.9 antlers
2022-06-19 17:26     ` [bug#56057] [bug #56057] [PATCH v2 09/21] gnu: Add rust-gimli-0.26 antlers
2022-06-19 17:27     ` [bug#56057] [bug #56057] [PATCH v2 10/21] gnu: Add rust-jwalk-0.6 antlers
2022-06-19 17:27     ` [bug#56057] [bug #56057] [PATCH v2 11/21] gnu: Add rust-miniz-oxide-0.5 antlers
2022-06-19 17:27     ` [bug#56057] [bug #56057] [PATCH v2 12/21] gnu: Add rust-object-0.28 antlers
2022-06-19 17:27     ` [bug#56057] [bug #56057] [PATCH v2 13/21] gnu: rust-once-cell-1: Update to 1.12.0 antlers
2022-06-19 17:27     ` [bug#56057] [bug #56057] [PATCH v2 14/21] gnu: Add rust-open-3 antlers
2022-06-19 17:49       ` EHarding830
2022-06-20  5:22         ` antlers
2022-06-19 17:27     ` [bug#56057] [bug #56057] [PATCH v2 15/21] gnu: Add rust-parking-lot-core-0.9 antlers
2022-06-19 17:27     ` [bug#56057] [bug #56057] [PATCH v2 16/21] gnu: Add rust-pretty-assertions-1.2 antlers
2022-06-19 17:27     ` [bug#56057] [bug #56057] [PATCH v2 17/21] gnu: Add rust-simd-adler32-0.3 antlers
2022-06-19 17:27     ` [bug#56057] [bug #56057] [PATCH v2 18/21] gnu: rust-sysctl-0.23: Update to 0.23.15 antlers
2022-06-19 17:56       ` Antlers
2022-06-19 17:27     ` [bug#56057] [bug #56057] [PATCH v2 19/21] gnu: Add rust-tui-0.17 antlers
2022-06-19 17:27     ` [bug#56057] [bug #56057] [PATCH v2 20/21] gnu: Add rust-tui-react-0.18 antlers
2022-06-19 17:27     ` [bug#56057] [bug #56057] [PATCH v2 21/21] gnu: rust-backtrace-0.3: Update to 0.3.65 antlers
2022-06-19 18:09 ` [bug#56057] [bug #56057] [PATCH v2 14/21] gnu: Add rust-open-3 Antlers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=829df0f0a945554d749c9dfbcf2524da281903c4.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=56057@debbugs.gnu.org \
    --cc=antlers@luris.net \
    --cc=autumnalantlers@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).