From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id EMUnA/kPLGHtDQAAgWs5BA (envelope-from ) for ; Mon, 30 Aug 2021 00:53:45 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id ENFSOvgPLGH9TgAA1q6Kng (envelope-from ) for ; Sun, 29 Aug 2021 22:53:44 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C33B818F7F for ; Mon, 30 Aug 2021 00:53:44 +0200 (CEST) Received: from localhost ([::1]:45070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mKTgN-0001gj-MZ for larch@yhetil.org; Sun, 29 Aug 2021 18:53:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51638) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKTfi-0001fC-G8 for guix-patches@gnu.org; Sun, 29 Aug 2021 18:53:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:46133) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mKTfi-0001HA-8E for guix-patches@gnu.org; Sun, 29 Aug 2021 18:53:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mKTfi-00020Z-2M for guix-patches@gnu.org; Sun, 29 Aug 2021 18:53:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#49834] Add dynaconf Resent-From: paul Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 29 Aug 2021 22:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 49834 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Sarah Morgensen Cc: 49834@debbugs.gnu.org Received: via spool by 49834-submit@debbugs.gnu.org id=B49834.16302775717694 (code B ref 49834); Sun, 29 Aug 2021 22:53:02 +0000 Received: (at 49834) by debbugs.gnu.org; 29 Aug 2021 22:52:51 +0000 Received: from localhost ([127.0.0.1]:57678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKTfW-000201-Mg for submit@debbugs.gnu.org; Sun, 29 Aug 2021 18:52:51 -0400 Received: from devianza.investici.org ([198.167.222.108]:27033) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mKTfT-0001zs-Nc for 49834@debbugs.gnu.org; Sun, 29 Aug 2021 18:52:49 -0400 Received: from mx2.investici.org (unknown [127.0.0.1]) by devianza.investici.org (Postfix) with ESMTP id 4GyTHf20DFz6xXp; Sun, 29 Aug 2021 22:52:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=autistici.org; s=stigmate; t=1630277566; bh=I6Jn/rrt1r1m1ojVJOQNLkmJvj78R44uSV1yKV2T03Y=; h=To:Cc:References:From:Subject:Date:In-Reply-To:From; b=WLhhofk9m2hdtdJx9KJ1gEu60dcQ/ZoUo005k09h88w9mGRddrEEJEeANXMDHdth6 s2Tmk+LD8SgFmgykJmlfRhUdqTEuuEVIGb4Ga1lm+ZCnvmD7HSb7QasKdYPnnuyMib axHXxpQOgwonEr4NWJGUBCi8EPw9AuPlRwdCmfAk= Received: from [198.167.222.108] (mx2.investici.org [198.167.222.108]) (Authenticated sender: goodoldpaul@autistici.org) by localhost (Postfix) with ESMTPSA id 4GyTHf10YFz6xXh; Sun, 29 Aug 2021 22:52:46 +0000 (UTC) References: <86a6l12nnt.fsf@mgsn.dev> From: paul Message-ID: <81dc5a57-e02a-4701-eb52-37eb378d7fcc@autistici.org> Date: Mon, 30 Aug 2021 00:52:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Icedove/78.12.0 MIME-Version: 1.0 In-Reply-To: <86a6l12nnt.fsf@mgsn.dev> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: C33B818F7F X-Spam-Score: -4.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: daqRUWJNLOVX Dear Sarah, On 8/29/21 12:46 AM, Sarah Morgensen wrote: > Did you receive my other email? I found that in fact none of the flake= 8 > packages, as well as some others, are actually required. I apologise i= f > merging these bugs caused it to get lost! I'll quote it below. No I did not :( . Also I'm sorry about the confusion with the multiple=20 bug reports, I forgot to send the patches directly to the ticket address.= > * gnu/packages/python-xyz.scm (python-colorama-0.4.1): New variable, > (python-dotenv-0.13.0): New variable, > (dynaconf): New variable. >> Packages typically get one commit per package (so this would be three >> commits). I wasn't sure about this because right now those exact versions are only = needed by dynaconf. Anyway I divided them in three commits. >>> * gnu/packages/patches/dynaconf-Unvendor-dependencies.patch: New fi= le. >> ^ an extra space slipped in here. >> >>> [...] >>> + (arguments >>> + `(#:phases >>> + (modify-phases %standard-phases >>> + (replace 'check >>> + (lambda* (#:key tests? outputs #:allow-other-keys) >>> + (when tests? >>> + (setenv "PATH" >>> + (string-append (assoc-ref outputs "out") "/bi= n:" >>> + (getenv "PATH"))) >>> + ;; These tests depend on hvac and a >>> + ;; live Vault process. >>> + (delete-file "tests/test_vault.py") >>> + (invoke "make" "test_only")) >>> + #t))))) >> ^ Nitpick: phases no longer have to end in #t, though= it >> doesn't hurt. Thank you I didn't know it, fixed! >> >>> + (propagated-inputs >>> + `(("python-click" ,python-click) >>> + ("python-dotenv" ,python-dotenv-0.13.0) >>> + ("python-ruamel.yaml" ,python-ruamel.yaml) >>> + ("python-toml" ,python-toml))) >>> + (native-inputs >>> + `(("make" ,gnu-make) >>> + ("python-codecov" ,python-codecov) >>> + ("python-configobj" ,python-configobj) >>> + ("python-colorama" ,python-colorama-0.4.1) >>> + ("python-django" ,python-django) >>> + ("python-flake8" ,python-flake8) >>> + ("python-flake8-debugger" ,python-flake8-debugger) >>> + ("python-flake8-print" ,python-flake8-print) >>> + ("python-flake8-todo" ,python-flake8-todo) >>> + ("python-flask" ,python-flask) >>> + ("python-future" ,python-future) >>> + ("python-pep8-naming" ,python-pep8-naming) >>> + ("python-pytest" ,python-pytest-6) >>> + ("python-pytest-cov" ,python-pytest-cov) >>> + ("python-pytest-forked" ,python-pytest-forked) >>> + ("python-pytest-mock" ,python-pytest-mock) >>> + ("python-pytest-xdist" ,python-pytest-xdist) >>> + ("python-radon" ,python-radon))) >> With the test_only target, I think only a few of these are actually >> required. Also, configobj should probably be a propagated input as >> dynaconf uses it for ini files. I've attached a patch below. >> >> Notably, this seems to make python-flake8-debugger, python-flake8-todo= , >> python-pep8-naming and python-colorama-0.4.1 unneccessary (I think >> because they are used for code linting, and the test_only target doesn= 't >> do linting). WDYT? >> >> (Even if they aren't necessary for packaging dynaconf, you're still >> welcome to send them as separate patches :) I definitely agree, I'll send them as separate patches. >> >>> + (home-page >>> + "https://github.com/rochacbruno/dynaconf") >> ^ Nitpick: this can go on one line >> =20 >>> + (synopsis >>> + "The dynamic configurator for your Python Project") >> ^ Likewise >> =20 >>> + (description >>> + "This package provides @code{dynaconf} the dynamic configurator= for >>> +your Python Project.") >> Even as someone who has used python a lot before, this doesn't tell me= >> anything about what dynaconf actually does or why I might want to >> install it. (Or, is it even an end-user package?) For examples, take a= >> look at pretty much any package which has more than two lines in its >> description (like, say, python-seaborn). I know writing a good >> description can be difficult, but they tend to stick around and read b= y >> lots of people, so getting it right the first time is important! I updated the description with the feature set provided on the main=20 website, it should be a little more clear now . I'm sending an updated patchset, thank you for your time :) Giacomo