From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id p5zCNfF2UGBGXgAA0tVLHw (envelope-from ) for ; Tue, 16 Mar 2021 09:14:25 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 4S8TMfF2UGC7CwAAB5/wlQ (envelope-from ) for ; Tue, 16 Mar 2021 09:14:25 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 135F215506 for ; Tue, 16 Mar 2021 10:14:23 +0100 (CET) Received: from localhost ([::1]:39246 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lM5mQ-0007rE-0o for larch@yhetil.org; Tue, 16 Mar 2021 05:14:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52412) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lM5m6-0007qx-Nt for guix-patches@gnu.org; Tue, 16 Mar 2021 05:14:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54878) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lM5m6-00028p-Bb for guix-patches@gnu.org; Tue, 16 Mar 2021 05:14:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lM5m6-0005Zc-6x for guix-patches@gnu.org; Tue, 16 Mar 2021 05:14:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47187] [PATCH] gnu: Add c-lightning. Resent-From: =?UTF-8?Q?L=C3=A9o?= Le Bouter Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 16 Mar 2021 09:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47187 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: ZmnSCPxj , 47187@debbugs.gnu.org Received: via spool by 47187-submit@debbugs.gnu.org id=B47187.161588600221362 (code B ref 47187); Tue, 16 Mar 2021 09:14:02 +0000 Received: (at 47187) by debbugs.gnu.org; 16 Mar 2021 09:13:22 +0000 Received: from localhost ([127.0.0.1]:38189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lM5lS-0005YU-9H for submit@debbugs.gnu.org; Tue, 16 Mar 2021 05:13:22 -0400 Received: from mail.zaclys.net ([178.33.93.72]:39131) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lM5lO-0005YG-Q4 for 47187@debbugs.gnu.org; Tue, 16 Mar 2021 05:13:20 -0400 Received: from guix-xps.local (82-64-145-38.subs.proxad.net [82.64.145.38]) (authenticated bits=0) by mail.zaclys.net (8.14.7/8.14.7) with ESMTP id 12G9DCqG026755 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 16 Mar 2021 10:13:12 +0100 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.zaclys.net 12G9DCqG026755 Authentication-Results: mail.zaclys.net; spf=fail smtp.mailfrom=lle-bout@zaclys.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zaclys.net; s=default; t=1615885992; bh=EIugy+6++fIv207AXVbTCIyBMFclI0d7lw24w1s5dpw=; h=Subject:From:To:Date:In-Reply-To:References:From; b=f3q3kAhvsscCAKsnQnjul7M8YwTVI7t61EpZt2x6xYIEXbME4XIKyks+G4wCh5ZrQ mKU0b9fQQyYbZDM/Mib/OguJKvU+GgpPO9khe8OwkiDwwJoTC3t0H+ywyMKndyB7Og CC+fdLMFtMrxAC4wPe6bPalzWfnd85GtqgiM1lLY= Message-ID: <81c654076d3c07c0f7d1657b4e44dce29a01eca2.camel@zaclys.net> Date: Tue, 16 Mar 2021 10:13:07 +0100 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-fTkqj1Uctj9F+r2ceg1h" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: =?UTF-8?Q?L=C3=A9o?= Le Bouter X-ACL-Warn: , =?UTF-8?Q?L=C3=A9o?= Le Bouter via Guix-patches From: =?UTF-8?Q?L=C3=A9o?= Le Bouter via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1615886063; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=EIugy+6++fIv207AXVbTCIyBMFclI0d7lw24w1s5dpw=; b=Va8VA+ZYIrFSfUTBKzbSCxSZspMve3bptB2ova8JF27CRbMnLl8qC6uRqeThQMv46t+X5Q 9yeFuUnhBu4ONN8e+9Z+2qc2FKIZrTnRV30ZxgOIRQqIgHh6HXuM7MixD8DB4/ALGWB3kT vXAHpAyf6j+RA0yZNSQChEsgFpuPAgaTlI3MKXpcaZkxATh1rPo8STc2jV7YwpfXeOI0XW kQ2Wb9q+ZUvg149HJOEKTPN0fonjUE6fQTuFHHjaktqoQ/y3+H5YbipsK9YdJ7ofbx8o48 nefRj1EaDPlC6IJpcXqAV2pMHfzo438dXg8Gc4afHqHPeDD106F91Dlq7tE1AQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1615886063; a=rsa-sha256; cv=none; b=e9ibhrK1OKRBh5vzRMDGMFArRAQED79Fmn+huZyYJ+5KOEGU01fnBVCyW2N90MnkHFFhkV ru/SJ8F/cGqjDsyA8JoZECk0ATcpeYUYcvf9ow/WMz4tcYmq+EVxZXKSQHh1Q9UgPL7pWA 1EzOG6EAUjuhCf5BphUEVz/AemK8rtq+gVKTXlCINcVAg2hI0YD+s9XmVhh8qphLR4xY+m mGkUFd/FSr0Td19dKvRCp+lU84qUyI3Vjs89BuKq/CrBvpgx4900WjjhPYoepABPdy0NR/ guUYdyhhTuwED/qr4f5ptlp8lwq0J+zkqbt3dKEkFNtArHzmDolL4dxDflD1pQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=zaclys.net header.s=default header.b=f3q3kAhv; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -5.00 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=zaclys.net header.s=default header.b=f3q3kAhv; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 135F215506 X-Spam-Score: -5.00 X-Migadu-Scanner: scn0.migadu.com X-TUID: MadzoCr1JHJc --=-fTkqj1Uctj9F+r2ceg1h Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello! Thanks for the patch! I built it and it was successful, however, few comments: The various hacks in the recipe to get a working build seem troublesome maintenance-wise, is it possible you think since you are a developer that you make the build scripts a bit more standard in the project? I see there's some vendored libraries: gheap, jsmn, libbacktrace, libsodium, libwally-core ; Is it possible to unvendor those and create separate packages for each of them? Or is there a requirement of strict behavior here, either way, you could also create separate packages for each of them even if those are specific to c-lightning. It would make the main recipe cleaner, since as far as I can see it's also why the build system is so stubborn to GNU Guix? That it also attempts to build vendored libraries? L=C3=A9o --=-fTkqj1Uctj9F+r2ceg1h Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEFIvLi9gL+xax3g6RRaix6GvNEKYFAmBQdqMACgkQRaix6GvN EKa21RAAuoYovFsFSLETZcz/z6l0U8QfH/j5arsEgaftiHdxLpPEZr8tLw5mslJG PM0dCdDC4YPvjhvgRMJRsiqUPwsdK3dya6cqMvWA/P0A10bM6iPPTFyLR4MIzeW0 DpwmZnJricitJcXfh405kRqfzSUfZIW9/vtueZfIaGhxscxwpogPDrfNMIGeZNFW stSO7BeLusx6TRt2gKzs+/Yg0EkEwT6FKIAGwBloZEfShZ35nWd7G93kkKLMhQKf 5dqCZDSQcmM7uRvThEOV+R1q0kFHPzUBcR8lV8K0S+/urrJ8XQtCf8JRrLGpApgV GoaMXJVNivmUBENkk6dnw+cHpPFf7dQ0fcpnjmqPve6blB1RQDEeOe0iK441edZU AmBm6qmmQVgoRR5C7S2vwil+LMPfmBh3RER0+PhqH+AJ9XqQJhxlVfUYdeAluFFw 9Dq8PhZF8fE+sgnGDpNQFNt+RpCgfZiUw9nzeMko1DJGm5U4jZFIyurpuHupoxtn EXIV9cGhSTPzkgEKI0dEcT3kt75taCYKJiou7Pu+n6g/B+rnMeIbd/NuciPKSbbQ ArjdzYnNhgwW/joZ6g5bikBup+h5u3ScmJBzPPveGmaZv4tZ/29lhpKD/X1cER3e VjvFgA42rIN52oow+hvWALyhgpmu/r8JH0Vd0BwAx9aOvAuDs7U= =jKNa -----END PGP SIGNATURE----- --=-fTkqj1Uctj9F+r2ceg1h--