unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Caliph Nomble via Guix-patches via <guix-patches@gnu.org>
To: 45478@debbugs.gnu.org
Cc: Caliph Nomble <calnomble@protonmail.com>
Subject: [bug#45478] [PATCH] gnu: u-boot: Fix freeze on boot with u-boot-rockpro64-rk3399
Date: Mon, 28 Dec 2020 06:00:28 +0000	[thread overview]
Message-ID: <81PLnSehrBPa4rZr26tcqS9JXZdtYcjjLXfDtZSaA@cp4-web-036.plabs.ch> (raw)

* gnu/packages/bootloaders.scm (u-boot-rockpro64-rk3399): Build with modified
config to prevent freeze on boot due to usb being enabled.
---
 gnu/packages/bootloaders.scm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm
index 7034085d67..078bc3156e 100644
--- a/gnu/packages/bootloaders.scm
+++ b/gnu/packages/bootloaders.scm
@@ -868,7 +868,14 @@ to Novena upstream, does not load u-boot.img from the first partition.")
         (substitute-keyword-arguments (package-arguments base)
           ((#:phases phases)
            `(modify-phases ,phases
-              (add-after 'unpack 'set-environment
+              (add-after 'unpack 'patch-rockpro64-config
+                ;; Fix regression in 2020.10 causing freezes on boot with USB boot enabled.
+                ;; See https://gitlab.manjaro.org/manjaro-arm/packages/core/uboot-rockpro64/-/issues/4
+                (lambda _
+                  (substitute* "configs/rockpro64-rk3399_defconfig"
+                    (("CONFIG_USE_PREBOOT=y") "CONFIG_USE_PREBOOT=n"))
+                  #t))
+              (add-after 'patch-rockpro64-config 'set-environment
                 (lambda* (#:key inputs #:allow-other-keys)
                   (setenv "BL31" (string-append (assoc-ref inputs "firmware")
                                                 "/bl31.elf"))
-- 
2.26.2






             reply	other threads:[~2020-12-28 14:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-28  6:00 Caliph Nomble via Guix-patches via [this message]
2020-12-28 18:40 ` [bug#45478] [PATCH] gnu: u-boot: Fix freeze on boot with u-boot-rockpro64-rk3399 Danny Milosavljevic
2020-12-29  7:23   ` Caliph Nomble via Guix-patches via
2020-12-29 12:33     ` Danny Milosavljevic
2020-12-29 21:34       ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81PLnSehrBPa4rZr26tcqS9JXZdtYcjjLXfDtZSaA@cp4-web-036.plabs.ch \
    --to=guix-patches@gnu.org \
    --cc=45478@debbugs.gnu.org \
    --cc=calnomble@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).