From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id 8LnEIjIAnmLPfgEAbAwnHQ (envelope-from ) for ; Mon, 06 Jun 2022 15:25:06 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id AAypIjIAnmJlAgEAauVa8A (envelope-from ) for ; Mon, 06 Jun 2022 15:25:06 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id BB07B33ACB for ; Mon, 6 Jun 2022 15:25:04 +0200 (CEST) Received: from localhost ([::1]:44670 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nyCj9-0007iE-TJ for larch@yhetil.org; Mon, 06 Jun 2022 09:25:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57826) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyCVb-0006V4-NS for guix-patches@gnu.org; Mon, 06 Jun 2022 09:11:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:40777) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nyCVa-0000jI-JT for guix-patches@gnu.org; Mon, 06 Jun 2022 09:11:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nyCVa-0002PE-B5 for guix-patches@gnu.org; Mon, 06 Jun 2022 09:11:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54832] [patch] update glibc to 2.35 Resent-From: zamfofex Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 06 Jun 2022 13:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54832 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: Maxime Devos , 54832@debbugs.gnu.org Received: via spool by 54832-submit@debbugs.gnu.org id=B54832.16545210559231 (code B ref 54832); Mon, 06 Jun 2022 13:11:02 +0000 Received: (at 54832) by debbugs.gnu.org; 6 Jun 2022 13:10:55 +0000 Received: from localhost ([127.0.0.1]:34674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyCVP-0002Oa-9G for submit@debbugs.gnu.org; Mon, 06 Jun 2022 09:10:55 -0400 Received: from mta-15-4.privateemail.com ([198.54.127.111]:62519) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyBVD-00060U-8Q for 54832@debbugs.gnu.org; Mon, 06 Jun 2022 08:06:35 -0400 Received: from mta-15.privateemail.com (localhost [127.0.0.1]) by mta-15.privateemail.com (Postfix) with ESMTP id 53CE518000A1; Mon, 6 Jun 2022 08:06:29 -0400 (EDT) Received: from APP-18 (unknown [10.50.14.242]) by mta-15.privateemail.com (Postfix) with ESMTPA id 1B7BE18000A2; Mon, 6 Jun 2022 08:06:27 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=twdb.moe; s=default; t=1654517189; bh=P6B2t8M0vsNwCYYOiQnMuZN+wsAsr+DBx9zBBSGHVOM=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=dh1euzyJ6JbnhEoAgPSZTfqTwVP/jm7b+W/6mPPmdeaH6Vi54vIFnwkp579rfvJFP prMn3x+9sn1QD1kAJUzx7yCB0wPK7izzKsHG+ZsWGEuC8mMq2U1DxIYFzrqrLivqvp v39+FR5+NZn3cj7fbCeIfbypWY0juMmhJtacK/ajfsrN2OOGEvy6YuzwnOHQiqpEOo OJXCfd4w2kbjDuG2rjD9Rysywzx8HRJe/um4tIIa4nTKD0q3RGoPrgB+9axd5pxbjf K31NCZ1wxE9yPHedl0iNm222y+jaOa4Ujwx+NsKQlXAFD8iSjNTMj7wLMU+vWhCsuD frtkTqIr3xdZA== Date: Mon, 6 Jun 2022 09:06:27 -0300 (BRT) From: zamfofex Message-ID: <818784149.855838.1654517187059@privateemail.com> In-Reply-To: <87r14ubhyu.fsf@gnu.org> References: <935236349.13698.1649553391613@privateemail.com> <87r14ubhyu.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev15 X-Originating-Client: open-xchange-appsuite X-Virus-Scanned: ClamAV using ClamSMTP X-Mailman-Approved-At: Mon, 06 Jun 2022 09:10:50 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1654521904; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=/DK6LG/lBZ134uRozktAIcrU7M34475gMLIOzw9L2Q8=; b=DYCVc0EVggAGEdoqCJmuqe05QFX5ZmwlGj6rnG0qt788ku/6oRG7eRwiu8lM7skO85XBXq DcmS97bSYQXTEPieg7gsEOoeZcmwY3wPS24qrKZa8b5SLmFsF3OjKD1ykjr4/Lw0XzxJEK kVEkoH10aA7WqcdYIRbYKbW8lZ+q2xxYmig+VZ/7IEOjk+vjeFJUCMBJeP7Ko7GvapZ+4U 85o/5UCyaTzdeo6mNNgzAaYncDdTEkVtpo97PHUmeYOLulvRFJcFYZeiJ1wNpdz4fpe6N7 gN1jkH+qsqqn5MCfwuAmcJWp8AOQMXh5ISB4k4K0RKlme0wQNUShtBso353Jhw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1654521904; a=rsa-sha256; cv=none; b=HjW2Ax47mb8cZ4mdseS5YNLnX3mvVX/WlFgBhXUECNZKYfTk/7Ix9QvR12zkG/cQUEfaLf TFv4atzWjwzOd8ZYNUpa2J/kMTM8+ssqLlIgIA5+5Egs0+mRZphiBrqXbmD7RLwalwd1e+ 8XxXVs6lXn8PLy5doxgWiTRRGyWivjMz4WT7d3BjIxqHCt+KB8yCm+fUhqDxxrAFgeF8cQ ikxd/F2G9bCfaHpeTf26pMez6zkmoxL9AoSz9sSG946q2GiJP8Ys7Gc67mXCKV/Q23UpHG hIjoejt07MW2TVQoMlztudr5pdAzojp4v4hwk4rs3Ils6fsTpcEyImO830E+OA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none ("invalid DKIM record") header.d=twdb.moe header.s=default header.b=dh1euzyJ; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.11 Authentication-Results: aspmx1.migadu.com; dkim=none ("invalid DKIM record") header.d=twdb.moe header.s=default header.b=dh1euzyJ; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: BB07B33ACB X-Spam-Score: -4.11 X-Migadu-Scanner: scn0.migadu.com X-TUID: bbyWommZD/hx > Could you confirm that these patches are no longer needed? I don=E2=80=99t remember exactly what my thought process was for removing t= he =E2=80=98glibc-dl-cache=E2=80=99 patch except that it wasn=E2=80=99t app= licable anymore. At any rate, I don=E2=80=99t fully understand what the pat= ch is actually doing, so it=E2=80=99s a bit difficult to assess whether it= =E2=80=99s still necessary to me. (Help would be appreciated!) Other than that, I did verify the other two patches, and it seems the regex= es they were patching have already been fixed upstream! > Could you explain why the empty .a files need special treatment? In the = end, it seems we=E2=80=99re copying them to the =E2=80=9Cstatic=E2=80=9D ou= tput anyway, so why not let them in =E2=80=98files=E2=80=99? Those files need to be present in both the =E2=80=98static=E2=80=99 and =E2= =80=98out=E2=80=99 outputs, whereas without considering them specially, the= y would be moved to the =E2=80=98static=E2=80=99 output (with =E2=80=98rena= me-file=E2=80=99 as opposed to =E2=80=98copy-file=E2=80=99). Is a comment w= orthwhile? What should I write? I could explain the change in glibc that ma= de those into empty =E2=80=98.a=E2=80=99 files and link to the changelog. I= s that enough? > This should be done in a separate patch. That is fine. Though I will note that the previous version of m4 did not wo= rk with the updated glibc, so I think it would make sense to updated it *be= fore* updating glibc in the commit history. Do I need to verify whether the= newer version works with the previous glibc too? > Like Maxime wrote, please start the patch with a short comment explaining= what it does, and with a link to the upstream commit or bug report. I=E2=80=99m still confused about what I should link to. I can write a comme= nt explaining the issues and link to the IRC conversation we held, or maybe= even to this thread. But I don=E2=80=99t think there actually is =E2=80=9C= an upstream commit or bug report=E2=80=9D that I could link to. > One last thing: could you use =E2=80=98git format-patch=E2=80=99 and (opt= ionally) =E2=80=98git send-email=E2=80=99 to send a revised patch? I definitely don=E2=80=99t mind investigating using those tools more carefu= lly! I think I can prepare and send another patch once my questions are cla= rified. - - - Apologies to Maxime and Ludovic for the repeated messages once again and to= others for taking so long to respond. I=E2=80=99m still getting familiar w= ith sending emails properly! At any rate, thank you for looking into it!