From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djIlP-0002Gj-2a for guix-patches@gnu.org; Sun, 20 Aug 2017 01:27:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1djIlK-0003dY-JD for guix-patches@gnu.org; Sun, 20 Aug 2017 01:27:07 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:37339) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1djIlK-0003dS-9T for guix-patches@gnu.org; Sun, 20 Aug 2017 01:27:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1djIlK-0000EG-3G for guix-patches@gnu.org; Sun, 20 Aug 2017 01:27:02 -0400 Subject: bug#28135: [PATCH 1/2] gnu: Add libinfinity. Resent-To: guix-patches@gnu.org Resent-Message-ID: Message-Id: <803e3f56.AEMAOtK6FEoAAAAAAAAAAAPkTHUAAAACwQwAAAAAAAW9WABZmR2d@mailjet.com> MIME-Version: 1.0 From: Arun Isaac Date: Sun, 20 Aug 2017 10:56:40 +0530 In-reply-to: <87tw14y6co.fsf@fastmail.com> References: <410b0233.ADkAACstJo0AAAAAAAAAAAOtUOAAAAACwQwAAAAAAAW9WABZlrLk@mailjet.com> <87tw14y6co.fsf@fastmail.com> Content-Type: text/plain Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Marius Bakke Cc: 28135-done@debbugs.gnu.org Marius Bakke writes: > Arun Isaac writes: > >> * gnu/packages/gobby.scm (libinfinity): New variable. > > [...] > >> + (synopsis "Infininote protocol implementation") >> + (description "Gobby is a collaborative editor that allows multiple = users >> +to edit the same document together over the internet in real-time. The >> +libinfinity shared library contains the implementation of the protocol = that is >> +used to synchronize document changes between users.") > > I'm not sure if repeating the Gobby description in the first sentence is > necessary. The description from their README is pretty good: > > libinfinity is library to build collaborative text editors. Changes to > the text buffers are synced to all other clients over a central > server. Even though a central server is involved, the local user sees > his changes applied instantly and the merging is done on the individual > clients. > >> + (license license:isc))) > > COPYING and the source files I looked at say LGPL2.1+. Can you check? > > The rest LGTM. Fixed both issues and pushed! Thanks for the review! =