From: Arun Isaac <arunisaac@systemreboot.net>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 28135-done@debbugs.gnu.org
Subject: bug#28135: [PATCH 1/2] gnu: Add libinfinity.
Date: Sun, 20 Aug 2017 10:56:40 +0530 [thread overview]
Message-ID: <803e3f56.AEMAOtK6FEoAAAAAAAAAAAPkTHUAAAACwQwAAAAAAAW9WABZmR2d@mailjet.com> (raw)
In-Reply-To: <87tw14y6co.fsf@fastmail.com>
Marius Bakke writes:
> Arun Isaac <arunisaac@systemreboot.net> writes:
>
>> * gnu/packages/gobby.scm (libinfinity): New variable.
>
> [...]
>
>> + (synopsis "Infininote protocol implementation")
>> + (description "Gobby is a collaborative editor that allows multiple users
>> +to edit the same document together over the internet in real-time. The
>> +libinfinity shared library contains the implementation of the protocol that is
>> +used to synchronize document changes between users.")
>
> I'm not sure if repeating the Gobby description in the first sentence is
> necessary. The description from their README is pretty good:
>
> libinfinity is library to build collaborative text editors. Changes to
> the text buffers are synced to all other clients over a central
> server. Even though a central server is involved, the local user sees
> his changes applied instantly and the merging is done on the individual
> clients.
>
>> + (license license:isc)))
>
> COPYING and the source files I looked at say LGPL2.1+. Can you check?
>
> The rest LGTM.
Fixed both issues and pushed! Thanks for the review!
prev parent reply other threads:[~2017-08-20 5:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-18 9:26 [bug#28135] Updating gobby Arun Isaac
2017-08-18 9:31 ` [bug#28135] [PATCH 1/2] gnu: Add libinfinity Arun Isaac
2017-08-18 20:21 ` Marius Bakke
2017-08-20 5:26 ` Arun Isaac [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=803e3f56.AEMAOtK6FEoAAAAAAAAAAAPkTHUAAAACwQwAAAAAAAW9WABZmR2d@mailjet.com \
--to=arunisaac@systemreboot.net \
--cc=28135-done@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).