unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Vivien Kraus <vivien@planete-kraus.eu>, 66052@debbugs.gnu.org
Cc: rg@raghavgururajan.name, maxim.cournoyer@gmail.com
Subject: [bug#66052] [PATCH gnome-team v4] gnu: tracker: Update to 3.6.0.
Date: Sun, 17 Sep 2023 21:51:15 +0200	[thread overview]
Message-ID: <800d89ee93edfcb461862e2daa3217b7e9fc1c8b.camel@gmail.com> (raw)
In-Reply-To: <afedd96086dbc7468dd6ae3a75c0bc3d6099b03d.1694977684.git.vivien@planete-kraus.eu>

Am Sonntag, dem 17.09.2023 um 13:29 +0200 schrieb Vivien Kraus:
> * gnu/packages/gnome.scm (tracker): Update to 3.6.0.
> [#:phases]: Add 'disable-failing-tests'.
> ---
> 
> > You don't need the clunky #t if you use and
> True. Thank you, I did not think of that.
> 
> > but I'm sure there are other places that already have such logic to
> > copy from with more idiomatic code.  Case in point: glib, which has
> > patches for i686 and hurd.
> 
> I can do the same as glib, but then on x86_64, where nothing is
> spliced in, the phase becomes `(lambda _)' which is a syntax error in
> Guile (lambdas must have at least one item in body). I can do the
> "and" trick, or do as glib and write '("Nothing to do :)") in the
> not-x86-32 branch of the if instead of '(). What would be best?
And that's where my original comment with unspecified comes back in.  
If you add *unspecified* after a bunch of conditional code that may or
may not get expanded, you will at least not have an empty body :)

Also remember to use #$@ rather than #$ for reasons (allows you to use
lists rather than forcing begin everywhere).

Cheers




  reply	other threads:[~2023-09-17 19:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-17 12:59 [bug#66052] [PATCH gnome-team 0/1] Update tracker, and ignore i686 missing tests Vivien Kraus via Guix-patches via
2023-09-17 11:29 ` [bug#66052] [PATCH gnome-team 1/1] gnu: tracker: Update to 3.6.0 Vivien Kraus via Guix-patches via
2023-09-17 13:27   ` Liliana Marie Prikler
2023-09-17 11:29     ` [bug#66052] [PATCH gnome-team v2] " Vivien Kraus via Guix-patches via
2023-09-17 16:22       ` Liliana Marie Prikler
2023-09-17 11:29         ` [bug#66052] [PATCH gnome-team v3] " Vivien Kraus via Guix-patches via
2023-09-17 18:55           ` Liliana Marie Prikler
2023-09-17 11:29             ` [bug#66052] [PATCH gnome-team v4] " Vivien Kraus via Guix-patches via
2023-09-17 19:51               ` Liliana Marie Prikler [this message]
2023-09-17 11:29                 ` [bug#66052] [PATCH gnome-team v5] " Vivien Kraus via Guix-patches via
2023-09-18 17:00                   ` Liliana Marie Prikler
2023-09-24 10:01                     ` bug#66052: " Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=800d89ee93edfcb461862e2daa3217b7e9fc1c8b.camel@gmail.com \
    --to=liliana.prikler@gmail.com \
    --cc=66052@debbugs.gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    --cc=rg@raghavgururajan.name \
    --cc=vivien@planete-kraus.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).