From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 8DGsDlxHTmcmBAAAe85BDQ:P1 (envelope-from ) for ; Mon, 02 Dec 2024 23:48:44 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 8DGsDlxHTmcmBAAAe85BDQ (envelope-from ) for ; Tue, 03 Dec 2024 00:48:44 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=DN0yHBUm; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=p9P8oV+u; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict), DKIM not aligned (strict)" header.from=posteo.net (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1733183324; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=LVARH1XehY7v35r+bPaWH0SMqDwyM5Ho+6HKJjxccRw=; b=h1ccay/NPtNUQ2HQZvgAK+mnZaJtDXBXHIH5lIbQ0kzYVAo77T5Nw0aPxqTDkaBLQwvCPz xuHYsyHbV7LT7KB9c/uraieE+ggBqMfzsgTMtu4qPWiYtGXkRvXi2t6faHa6Kuhlq7zneh G410l2S+q4cGG00PbsCxp+BToszFKKPyFI1mcWrkGbhcTqjraKz51rdHoXjXrEQxnuEaSX GxOrfVklxoPZTKNlViX8pm85wwnLK4SHwwLJgOQcpWKaiQHbHxthUYrHnghM7QFYwDFpex 6vw6YR7JDHaVeP7PZOU961Mkfqhc7Icc2ySFbtsNp3I+E7b9+PQyzBYAHgDdNA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=DN0yHBUm; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=p9P8oV+u; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (strict), DKIM not aligned (strict)" header.from=posteo.net (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1733183324; a=rsa-sha256; cv=none; b=r2VIwHKj8oRDTp2/dTvjXTEylS3YTVSZzcrTCn3h8O2HiSTBKSFu8r2ti7dpeafHBPSRnH gp33MW3lkIfhIP0teE6frUvzYJEb6PiCf3WZyNhk5yLHnhagBxnMpyKGpfW6Z6xC0wFrq1 qGHzSAU3NKt9wTFvfhWSaE+/RM/9/YRAvkZb7VPr92p7BEYVg3kx4yGJkVM05fNNRXp3WU azap1SoxKoxbiEKbXLkRKtvmTfIo9xi5PwI6qthAAwlxPFcU8T0ATgYQbSU5P9X5W4uaMA TfWTmXaWqUss6zThcpYCq7XGFyLhQaA4lZHR68+S148Pe1cjO0xcdXuCsk6qmQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7B3718CACB for ; Tue, 03 Dec 2024 00:48:43 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tIG97-0006kD-8u; Mon, 02 Dec 2024 18:48:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tIG95-0006jI-20 for guix-patches@gnu.org; Mon, 02 Dec 2024 18:48:03 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tIG94-0000z1-Pq for guix-patches@gnu.org; Mon, 02 Dec 2024 18:48:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=LVARH1XehY7v35r+bPaWH0SMqDwyM5Ho+6HKJjxccRw=; b=DN0yHBUmg73Tt4BF/aYL7wV0mgw30ucV9nd+q706heCG/ZD4sKnbf9EedbMl38k2IOhwl6m9rW7bTQC9x9jEZIdCWDTUynqF6XYxIPmhSZVlFhpEDjdc7xNLXDd0PhPo1+Ks4SDkSu0MDIJrVAi8x21veFPjBKZTZ0jYxbu6B8Mk6OcL2lVAjfgJhz3GHU9f+9WOeMjYSxDeZuUEIUECKHOQ+R9uiOOuuOvwrUE8Dw65QmQ1rn8gTfJ5UjLnvUYrfip2ipXSrcJ7rlN0rbrKyI/5sX8yROygaFdFEH6hjYuxpIg8T5WzGXXeZ0rHhO5DxwsX8OlVz7CzvgLoyyN4BA==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tIG94-0007YC-Ig for guix-patches@gnu.org; Mon, 02 Dec 2024 18:48:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#74654] [PATCH 2/5] packages: Optimize =?UTF-8?Q?=E2=80=98all-packages=E2=80=99.?= Resent-From: David Elsing Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 02 Dec 2024 23:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74654 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 74654@debbugs.gnu.org Received: via spool by 74654-submit@debbugs.gnu.org id=B74654.173318328029015 (code B ref 74654); Mon, 02 Dec 2024 23:48:02 +0000 Received: (at 74654) by debbugs.gnu.org; 2 Dec 2024 23:48:00 +0000 Received: from localhost ([127.0.0.1]:57003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIG92-0007Xv-04 for submit@debbugs.gnu.org; Mon, 02 Dec 2024 18:48:00 -0500 Received: from mout01.posteo.de ([185.67.36.65]:43269) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tIG90-0007Xa-1H for 74654@debbugs.gnu.org; Mon, 02 Dec 2024 18:47:58 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id CA790240027 for <74654@debbugs.gnu.org>; Tue, 3 Dec 2024 00:47:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1733183270; bh=LVARH1XehY7v35r+bPaWH0SMqDwyM5Ho+6HKJjxccRw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:From; b=p9P8oV+uJ4KDz4+LXZOFqnRvhnpiO3bSqBIl3/gUAtJfr77qUdWTFstg764Xw0TN+ POswOO8/Th9qVPw6giYZ9Y2miI+M6hhh9vgBwIhueNuxL2mMdVqwq/U8OtSzSxiL7K QwY1t7mh5dUyTgVGM0cffl9j/APGq3egjWYbueysk+fUUACX8Jl2czzZ8eu5aBBk91 SnT9i+B2y3PFoo07uGYm/O1G3lnTqZ9q9RiDJVTzME3pQNVHLWGhHl4f1H2Eh4lC4X ccuWszwgA6LqtBIAoeFHEkHgrAEsYM1K4TqC2DiD4BvBozWp1z5ss2BA30ceQa4sAG Cw+OXpMLTjqGw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Y2L7T3sCyz6twQ; Tue, 3 Dec 2024 00:47:49 +0100 (CET) From: David Elsing In-Reply-To: <642880c208f4445f1d63dba5618a315671d558e2.1733158049.git.ludo@gnu.org> References: <642880c208f4445f1d63dba5618a315671d558e2.1733158049.git.ludo@gnu.org> Date: Mon, 02 Dec 2024 23:47:48 +0000 Message-ID: <7ywmghr6jf.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: -0.91 X-Spam-Score: -0.91 X-Migadu-Queue-Id: 7B3718CACB X-TUID: 7+NkmYb2Pxyw Hi, Ludovic Court=C3=A8s writes: > On my laptop, wall-clock time for (all-packages) goes from 27s to 1s. > > * gnu/packages.scm (all-packages): Use a hash table to remember visited > packages instead of calling =E2=80=98delete-duplicates=E2=80=99 on the fi= nal list. Thanks for fixing this, commit 4b5dae8 also made `guix graph -t reverse-package` much slower, because `delete-duplicates` had not been used in the old `all-packages` procedure before. I wanted to make a patch, but then saw your series already. :) Cheers, David