From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gPNfO95O32E80gAAgWs5BA (envelope-from ) for ; Wed, 12 Jan 2022 22:57:50 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id gLYTON5O32GTIwAAauVa8A (envelope-from ) for ; Wed, 12 Jan 2022 22:57:50 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A0EFB3812D for ; Wed, 12 Jan 2022 22:57:50 +0100 (CET) Received: from localhost ([::1]:40456 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n7lcr-0002lG-MP for larch@yhetil.org; Wed, 12 Jan 2022 16:57:49 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58180) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n7lb8-0008L9-D4 for guix-patches@gnu.org; Wed, 12 Jan 2022 16:56:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:38211) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n7lb8-0007UH-3Z for guix-patches@gnu.org; Wed, 12 Jan 2022 16:56:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n7lb7-0001ke-KS for guix-patches@gnu.org; Wed, 12 Jan 2022 16:56:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53222] [PATCH] gnu: Add autokey. Resent-From: John Kehayias Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 12 Jan 2022 21:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53222 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos , Nicolas Goaziou Cc: 53222@debbugs.gnu.org Received: via spool by 53222-submit@debbugs.gnu.org id=B53222.16420245136672 (code B ref 53222); Wed, 12 Jan 2022 21:56:01 +0000 Received: (at 53222) by debbugs.gnu.org; 12 Jan 2022 21:55:13 +0000 Received: from localhost ([127.0.0.1]:59347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7laK-0001jX-L9 for submit@debbugs.gnu.org; Wed, 12 Jan 2022 16:55:12 -0500 Received: from mail-4316.protonmail.ch ([185.70.43.16]:21257) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n7laH-0001jD-SG for 53222@debbugs.gnu.org; Wed, 12 Jan 2022 16:55:11 -0500 Date: Wed, 12 Jan 2022 21:55:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail2; t=1642024502; bh=WxIyHsPLuHwKOjJ06dg5h2c8GQwD5C+GpWwqvrZuoww=; h=Date:To:From:Cc:Reply-To:Subject:Message-ID:In-Reply-To: References:From:To:Cc; b=O1P1pHScZxxkLmAWozCZdtcEkwNVFKNgC1g58YgSMnLqT3gZc8qcDPtlfwKs0teuR i8Qy1eTOAwXmyzLS3mSvZhxsbuKzj8yhQFF9Zw03IrLHxdWycp4TID5Gb38ZOov88t Wvl5eH7V7dQySybENvmj6E+AklhaSnZi1z9cDCnOZSD8VXqH1Wdzl8UwpOpNv00NVD 2EbntWEbEY2DhaZdgWhILmJhNHp7I0h6f/i38wGENn3N17SBB/c6UZsXfVDihcm2+X NNjJKfz4f2ZOvu/TVXBVa1B6QX6gfI6vZ27r5ylwxd76WzihWOGpffXYzKgVWPvnrs LKm1U7BAPZuig== Message-ID: <7vJ_B5FCWyHFJBMr1a2ubM4eF1T74OW0DGXi6Fwh4bqc_fyAq2wTdtHJ0H9LwFS1pom9o6CsUskqDW5QHRA3fcXUMVNY2W8umzWYZojFbAU=@protonmail.com> In-Reply-To: <684980f3b278c0953766b7108dfd6401bd890af2.camel@telenet.be> References: <684980f3b278c0953766b7108dfd6401bd890af2.camel@telenet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: John Kehayias X-ACL-Warn: , John Kehayias via Guix-patches From: John Kehayias via Guix-patches via X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1642024670; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=WxIyHsPLuHwKOjJ06dg5h2c8GQwD5C+GpWwqvrZuoww=; b=QE34xpSa4SGy9XiiL0luSf1iyQO+NtSaL1d5qRWjTt1WdpaD+bPssk1om45MCOF0aUBc5Q ndcFk5qtIYPhO7H3IkNnJzo0OeLnbsjJKAk3lvVVFuABvwkyqfHojEBDAg2rqSNKgDO1Ji KP/ODOPBlx8M4G4OMU+Uq2FPGhrzmXVogmFQezcq3u2U2nV2X+XYr9xxGAYd6J41lRm1K3 rEFfcU8yf5uuLq+cYKEmZiatmKP2ZPGPuiM2c7GdQqqDAmKLsH6Ap8Gao8Xnn+C4pfMosN jPZtgPHm94LXItjq6GdqksdZpp9rzSQDJH+kLSCpUF4l/DRRpegwHdOTfeNpNw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1642024670; a=rsa-sha256; cv=none; b=ug6Zhk0/q+GAkmeqaXKlXU9i1/IbBCoI5RUwSBgdluJbTwl5IJA3Y9hrUAi1n9gWiB+iZN exgWD38kUBBlttAauWFIzEoteA7sFevDKW5eg1GFSg28ebXdwhSrcnJjzXuzVsYx/icSKv +cQisPOwRTI/e854gKL3cb6LNPVhZwfWqTpHFqLd7SvZ1OG8fkrk1gEYLzqDLHaDvwT0Y2 CC0j4/WEwCkSSYbVV81ahwlHCTdxeflbifWlvCL515vBNS7jIVy3Rc+ziiwD40/a83OA3F z/LSQF0JmLe7oUwlroTjpkGu6mg05AjWKAGo+B6e44Dfkf1RzRoCqCpjzAb4tA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail2 header.b=O1P1pHSc; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.42 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail2 header.b=O1P1pHSc; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A0EFB3812D X-Spam-Score: -4.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: fF2KhASKHg6z Hi Maxime and Nicolas, =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 Original Me= ssage =E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90=E2=80=90 On Wednesday, January 12th, 2022 at 4:26 PM, Maxime Devos wrote: > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 #:tests? #f ; Tests are deprecated/brok= en until next version. > > How can a test be deprecated? > What tests are broken? > Are the tests broken, or do they fail because of a real issue? > Sort of both? They relied on python2 and had not been updated, so they didn= 't work (at all from what I see) and were therefore due for replacement in = the new version (forthcoming). See https://github.com/autokey/autokey/issues/327 where they say "The curre= nt tests are deprecated and won=E2=80=99t work." That's why I said it that = way in the comment, sorry if that wasn't clear. The new version that seems = due soon has a new test framework (tox). > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (wrap-program program > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 `("GI_TYPELIB_PATH" = ":" prefix (,gi-typelib- > > path)))) > > Do we need to include the GI_TYPELIB_PATH from the environment? > If not, I recommend '=3D' instead of 'prefix' to avoid potential trouble. > I'm not sure, I was following the examples I saw. For whatever reason, near= ly all of them do it that way (I think I only saw one or two as '=3D', in m= y quick look). Anyway, I think you are right that it shouldn't be needed, p= robably the same for a lot of other packages? I think it works with '=3D' i= nstead, in my quick test. > > If you add "GUIX_PYTHONPATH" =C2=A0to the wrap-program, > then probably the propagated inputs can be moved to the regular inputs > (since 'autokey' appeas to be used as a few binaries and not > as a python library). > I'm confused on this as these are already wrapped with GUIX_PYTHONPATH (the= bin outputs are python scripts) without adding it explicitly. Trying with = the propagated-inputs being regular inputs seems to work fine too. Although I haven't used it this way, there is also scripting with autokey. = One of the included programs is autokey-shell which is a python shell of so= rts. I'm not sure if that would make a difference and I don't have anything= offhand to test with. I can submit a patch to change the wrap and inputs if that would be cleaner= . Thanks! John