unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Edouard Klein <edk@beaver-labs.com>, 48277@debbugs.gnu.org
Subject: [bug#48277] [PATCH 0/1] New wrap-in-search-paths function
Date: Sun, 09 May 2021 20:15:24 +0200	[thread overview]
Message-ID: <7fa3822a2df127f16b92cfb0a35bf41176073eb7.camel@telenet.be> (raw)
In-Reply-To: <20210507154208.123628-1-edk@beaver-labs.com>

[-- Attachment #1: Type: text/plain, Size: 1140 bytes --]

Edouard Klein schreef op vr 07-05-2021 om 17:42 [+0200]:
> This patch adds the wrap-in-search-paths function [...].
> [... text about shepherd services, foreign distros, propagated-inputs,
>      gexps ...]

I don't see any obvious problems with the patch, though I haven't tested.

It would be easier to review if you modified one or two packages
and services in guix itself to use this wrap-in-search-paths procedure
though. (Preferably services with a system test in gnu/tests/*.scm.)
Otherwise, guix would have a procedure that is not called from anywhere
and isn't tested either, which is a bit of a hard sell.

Not sure how this helps with

> First, when running on a foreign distro, guix packages (especially python packages)
> can break the foreign distribution by putting Guix's python interpreter before the
> host's in the PATH. Scripts that rely on a #!/usr/bin/env python shebang then breaks.
> This for example breaks gdm on the latest Ubuntu when you install any package for
> which python is a propagated input.

, but this seems useful for shepherd services (as you mentioned).

Greetings,
Maxime.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]

  parent reply	other threads:[~2021-05-09 18:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-07 15:42 [bug#48277] [PATCH 0/1] New wrap-in-search-paths function Edouard Klein
2021-05-07 15:45 ` [bug#48277] [PATCH 1/1] guix: search-paths: Add wrap-in-search-paths Edouard Klein
2021-05-09 18:15 ` Maxime Devos [this message]
2021-05-09 19:56   ` [bug#48277] [PATCH 0/1] New wrap-in-search-paths function Edouard Klein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7fa3822a2df127f16b92cfb0a35bf41176073eb7.camel@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=48277@debbugs.gnu.org \
    --cc=edk@beaver-labs.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).