From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id gPSZGcqbZWDaTQAAgWs5BA (envelope-from ) for ; Thu, 01 Apr 2021 12:09:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id oBWBFMqbZWCLZwAA1q6Kng (envelope-from ) for ; Thu, 01 Apr 2021 10:09:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EB0191020D for ; Thu, 1 Apr 2021 12:09:13 +0200 (CEST) Received: from localhost ([::1]:39650 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRuGH-0007KS-5p for larch@yhetil.org; Thu, 01 Apr 2021 06:09:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36698) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRuG6-0007EQ-AW for guix-patches@gnu.org; Thu, 01 Apr 2021 06:09:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:44842) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lRuG6-0000Wn-2z for guix-patches@gnu.org; Thu, 01 Apr 2021 06:09:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lRuG5-0002f5-Uz for guix-patches@gnu.org; Thu, 01 Apr 2021 06:09:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47539] [PATCH 00/28] Add gh and dependencies Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 01 Apr 2021 10:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47539 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Xinglu Chen , 47539@debbugs.gnu.org Received: via spool by 47539-submit@debbugs.gnu.org id=B47539.161727170110183 (code B ref 47539); Thu, 01 Apr 2021 10:09:01 +0000 Received: (at 47539) by debbugs.gnu.org; 1 Apr 2021 10:08:21 +0000 Received: from localhost ([127.0.0.1]:56388 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lRuFR-0002eB-GI for submit@debbugs.gnu.org; Thu, 01 Apr 2021 06:08:21 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:19362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lRuFP-0002e1-QH for 47539@debbugs.gnu.org; Thu, 01 Apr 2021 06:08:20 -0400 Received: from nijino.local (194-96-13-79.adsl.highway.telekom.at [194.96.13.79]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4F9zQm0vD4z1Ldvn; Thu, 1 Apr 2021 12:08:15 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4F9zQm0vD4z1Ldvn DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1617271696; bh=f1U4oHg1huv7rx4J+iRSTN7rhh0xfU4qu6EbbTzJO+Y=; h=Subject:From:To:Date:In-Reply-To:References:From; b=m56Eb79Eq5/zpQCX8oRM7d9YGKCbbBfXHDTq3VGFxOOauTLyoE61KPkMu2GPlfo3k 27D5rdcYbDHBTB1e2/6WyU4jtxIFgfhJWNQKBaMlY+sXRPMgQzeEAVM4cji0zDZSZv DEFa6b1u2CQ8C4lSiy4Ah0SCMs3hMPi0/NpHljN4= Message-ID: <7f41ded1648030ed8f4db3165bfe4ccb2cb6b2a9.camel@student.tugraz.at> From: Leo Prikler Date: Thu, 01 Apr 2021 12:08:15 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617271754; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=f1U4oHg1huv7rx4J+iRSTN7rhh0xfU4qu6EbbTzJO+Y=; b=PQhK9WQW5NRkfvrMrSIARfdgNxbxPnCYdkHWtWrrUWTHr7mUz09kbKJCw9UgZQM3RwP2vv CdAayrvEDE9HFNzOb7VCEUsEKBm80OOKnCZSJjpR0ngu4bdmTw7Dho08fp5R6D7sjQH3DW OROJfJ8DUX+L5zCs5nB3qGTKv5TRJ8GLOaMCbsPf9VpvVvQDrxeJp/XIkFrPDaB0x+SaL5 cy4ra6D2L35ViNxEWdImoe4dbhFLWfazpVkLqGKHbC+lw7FC/jfxfX6q4LHAIMHXm7xP6B UG5lsWQmdguIo+OlLS8IJK/f38xvDQ/nBp62wm+RZn7WX2ZVGBDsEGdUW5WYYw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617271754; a=rsa-sha256; cv=none; b=ZLy+3NqH72IL1BgqkU2kqm9tZ0EU5qhpdfAFsPpKJEBixapz0MpqsUuUJVj8IiWT8+XgXA G/hntAnrioViXHHyAjviSWYJ2GwE7asAZ5SDYdHAWYOLU7LGm2JoBvSU/gv50vm+ufbQta WF8dUDjvHZlcz5RASdY+iVFRMJ/hQICucVozCpG2RIXV8AYDkelpbbFyXSClz9Aruq+8IA u7ky6iOnWT4PFaFFrx8TFO5y1b9yxNNWKRbAr8uTcx/wLpGRRpvKun+RO8MqwFOisi/2yv eSpTO9OkUaMu934Zgnycj+OIfbgOa2MMeTFOcEOwh06It4TQyB65RUl37RokxQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=m56Eb79E; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: 0.17 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b=m56Eb79E; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: EB0191020D X-Spam-Score: 0.17 X-Migadu-Scanner: scn0.migadu.com X-TUID: KCM7mGQ4kzTa Hi, Am Donnerstag, den 01.04.2021, 09:51 +0200 schrieb Xinglu Chen: > This patchset adds the 'gh' package, a CLI interface to GitHub. The > Go > importer did most of the work. :) I am not experienced with Go, so I can't comment on the rest too much, but I wanted to point out, that single, double and triple letter packages are (imo rightly) frowned upon in the Guix project. Considering, that this is the *official* Github CLI tool, a name like "github-cli" would probably make more sense here. > Some things to note: > > - When building'gh', I couldn't get > 'go-github-com-charmbracelet-glamour' to build without moving some > native-inputs to propagated-inputs, though, if I was only building > 'go-github-com-charmbracelet-glamour' it would build without moving > things to propagated-inputs. I am not sure why this happens. Perhaps you need to add those native inputs as native inputs to gh as well? Try adding its native inputs to gh and see whether that changes something. > - I found that (gnu packages syncthing) contained quite a few Go > packages, I think it would make sense to move those packages to > (gnu > packages golang), and move the Syncthing package to (gnu packages > sync). This would be done in a separate commit though. Indeed, that should probably done in a separate set. > - The patch marked with 'D' adds a package which has been deprecated > by > upstream, but it is still needed by one of the packages that 'gh' > depend on. I have marked it as a hidden package, let me know if > this > is the right decision. Yes, we do so for other packages as well, that require outdated or otherwise modified versions, that should not show up in user profiles unless they really, really want to and use manifests to achieve their goals. > - The patch marked with 'W' adds a package which is needed by 'gh', > but > only used on Windows. It is still Free Software (BSD-2), but I > have > also marked it as hidden. This is at least in some sense an acceptable workaround, but how large would the effort be to outright drop references to this package, given that it's already not "actively" being used? Regards, Leo