unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#52238] [PATCH] gnu: megacmd: Add mega-sdk as dependency.
       [not found] <29>
@ 2022-02-04  0:34 ` Wamm K. D
  2022-02-04 18:18   ` Liliana Marie Prikler
  0 siblings, 1 reply; 6+ messages in thread
From: Wamm K. D @ 2022-02-04  0:34 UTC (permalink / raw)
  To: 52238; +Cc: Wamm K. D, liliana.prikler

* gnu/packages/sync.scm (megacmd): Use new package mega-sdk as dependency
rather than build mega-sdk via building recursively.
---
 gnu/packages/sync.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/sync.scm b/gnu/packages/sync.scm
index 52003a7c9d..753b4e4d47 100644
--- a/gnu/packages/sync.scm
+++ b/gnu/packages/sync.scm
@@ -281,8 +281,7 @@ (define-public megacmd
         (method git-fetch)
         (uri (git-reference
               (url "https://github.com/meganz/MEGAcmd")
-              (commit (string-append version "_Linux"))
-              (recursive? #t)))
+              (commit (string-append version "_Linux"))))
         (sha256
          (base32
           "004j8m3xs6slx03g2g6wzr97myl2v3zc09wxnfar5c62a625pd53"))
@@ -301,6 +300,7 @@ (define-public megacmd
        ("curl" ,curl)
        ("freeimage" ,freeimage)
        ("gtest" ,googletest)
+       ("mega-sdk" ,mega-sdk)
        ("openssl" ,openssl)
        ("pcre" ,pcre)
        ("readline" ,readline)
-- 
2.34.0





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [bug#52238] [PATCH] gnu: megacmd: Add mega-sdk as dependency.
  2022-02-04  0:34 ` [bug#52238] [PATCH] gnu: megacmd: Add mega-sdk as dependency Wamm K. D
@ 2022-02-04 18:18   ` Liliana Marie Prikler
  2022-02-05  3:05     ` Jaft
  0 siblings, 1 reply; 6+ messages in thread
From: Liliana Marie Prikler @ 2022-02-04 18:18 UTC (permalink / raw)
  To: Wamm K. D, 52238

Am Donnerstag, dem 03.02.2022 um 18:34 -0600 schrieb Wamm K. D:
> * gnu/packages/sync.scm (megacmd): Use new package mega-sdk as
> dependency
> rather than build mega-sdk via building recursively.
> ---
>  gnu/packages/sync.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gnu/packages/sync.scm b/gnu/packages/sync.scm
> index 52003a7c9d..753b4e4d47 100644
> --- a/gnu/packages/sync.scm
> +++ b/gnu/packages/sync.scm
> @@ -281,8 +281,7 @@ (define-public megacmd
>          (method git-fetch)
>          (uri (git-reference
>                (url "https://github.com/meganz/MEGAcmd")
> -              (commit (string-append version "_Linux"))
> -              (recursive? #t)))
> +              (commit (string-append version "_Linux"))))
>          (sha256
>           (base32
>            "004j8m3xs6slx03g2g6wzr97myl2v3zc09wxnfar5c62a625pd53"))
> @@ -301,6 +300,7 @@ (define-public megacmd
>         ("curl" ,curl)
>         ("freeimage" ,freeimage)
>         ("gtest" ,googletest)
> +       ("mega-sdk" ,mega-sdk)
>         ("openssl" ,openssl)
>         ("pcre" ,pcre)
>         ("readline" ,readline)
Note that the hash didn't change, so you're still fetching the
recursive version.  In addition, the non-recursive version won't build
as mega-sdk is deeply bundled into megacmd.




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#52238] [PATCH] gnu: megacmd: Add mega-sdk as dependency.
  2022-02-04 18:18   ` Liliana Marie Prikler
@ 2022-02-05  3:05     ` Jaft
  2022-02-05  6:59       ` Liliana Marie Prikler
  0 siblings, 1 reply; 6+ messages in thread
From: Jaft @ 2022-02-05  3:05 UTC (permalink / raw)
  To: 52238@debbugs.gnu.org, Liliana Marie Prikler

[-- Attachment #1: Type: text/plain, Size: 1847 bytes --]

 Hmm; perhaps a past installed caused things to build last time I tried this. I see what you mean, now.
In that case, I'm not sure that I have enough experience or knowledge with make tools to be able to untangle things, I'm afraid.
    On Friday, February 4, 2022, 12:18:50 PM CST, Liliana Marie Prikler <liliana.prikler@gmail.com> wrote:  
 
 Am Donnerstag, dem 03.02.2022 um 18:34 -0600 schrieb Wamm K. D:
> * gnu/packages/sync.scm (megacmd): Use new package mega-sdk as
> dependency
> rather than build mega-sdk via building recursively.
> ---
>  gnu/packages/sync.scm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/gnu/packages/sync.scm b/gnu/packages/sync.scm
> index 52003a7c9d..753b4e4d47 100644
> --- a/gnu/packages/sync.scm
> +++ b/gnu/packages/sync.scm
> @@ -281,8 +281,7 @@ (define-public megacmd
>          (method git-fetch)
>          (uri (git-reference
>                (url "https://github.com/meganz/MEGAcmd")
> -              (commit (string-append version "_Linux"))
> -              (recursive? #t)))
> +              (commit (string-append version "_Linux"))))
>          (sha256
>           (base32
>            "004j8m3xs6slx03g2g6wzr97myl2v3zc09wxnfar5c62a625pd53"))
> @@ -301,6 +300,7 @@ (define-public megacmd
>         ("curl" ,curl)
>         ("freeimage" ,freeimage)
>         ("gtest" ,googletest)
> +       ("mega-sdk" ,mega-sdk)
>         ("openssl" ,openssl)
>         ("pcre" ,pcre)
>         ("readline" ,readline)
Note that the hash didn't change, so you're still fetching the
recursive version.  In addition, the non-recursive version won't build
as mega-sdk is deeply bundled into megacmd.
  

[-- Attachment #2: Type: text/html, Size: 4118 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#52238] [PATCH] gnu: megacmd: Add mega-sdk as dependency.
  2022-02-05  3:05     ` Jaft
@ 2022-02-05  6:59       ` Liliana Marie Prikler
  2022-02-13  8:34         ` Jaft
  0 siblings, 1 reply; 6+ messages in thread
From: Liliana Marie Prikler @ 2022-02-05  6:59 UTC (permalink / raw)
  To: Jaft, 52238@debbugs.gnu.org

Am Samstag, dem 05.02.2022 um 03:05 +0000 schrieb Jaft:
> Hmm; perhaps a past installed caused things to build last time I
> tried this. I see what you mean, now.
Not necessarily.  As I said, Guix already has substitutes for the
source, so it will fetch them regardless.

> In that case, I'm not sure that I have enough experience or knowledge
> with make tools to be able to untangle things, I'm afraid.
Fair enough, on the top of my head I'm not too sure how to untangle
this either.  However, note that mega-sdk appears pretty useless as a
standalone package, so I'd like to solve that issue before pushing it.

Cheers




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#52238] [PATCH] gnu: megacmd: Add mega-sdk as dependency.
  2022-02-05  6:59       ` Liliana Marie Prikler
@ 2022-02-13  8:34         ` Jaft
  2022-02-13  8:42           ` Liliana Marie Prikler
  0 siblings, 1 reply; 6+ messages in thread
From: Jaft @ 2022-02-13  8:34 UTC (permalink / raw)
  To: 52238@debbugs.gnu.org, Liliana Marie Prikler

> On Saturday, February 5, 2022, 12:59:47 AM CST, Liliana Marie Prikler <liliana.prikler@gmail.com> wrote: 
>
>
>
>
>
> Am Samstag, dem 05.02.2022 um 03:05 +0000 schrieb Jaft:
> > In that case, I'm not sure that I have enough experience or knowledge
> > with make tools to be able to untangle things, I'm afraid.
> Fair enough, on the top of my head I'm not too sure how to untangle
> this either.  However, note that mega-sdk appears pretty useless as a
> standalone package, so I'd like to solve that issue before pushing it.

That's fair; I had been first trying to get it added as a package as I was trying to package up MEGAsync and, as you might imagine, this is a dependency of it. I've nearly got the MEGAsync package working but need to get icons working properly, still; if I'm able to get it, would it make sense to send a patch here and move forward with that package?




^ permalink raw reply	[flat|nested] 6+ messages in thread

* [bug#52238] [PATCH] gnu: megacmd: Add mega-sdk as dependency.
  2022-02-13  8:34         ` Jaft
@ 2022-02-13  8:42           ` Liliana Marie Prikler
  0 siblings, 0 replies; 6+ messages in thread
From: Liliana Marie Prikler @ 2022-02-13  8:42 UTC (permalink / raw)
  To: Jaft, 52238@debbugs.gnu.org

Am Sonntag, dem 13.02.2022 um 08:34 +0000 schrieb Jaft:
> > On Saturday, February 5, 2022, 12:59:47 AM CST, Liliana Marie
> > Prikler <liliana.prikler@gmail.com> wrote: 
> > Am Samstag, dem 05.02.2022 um 03:05 +0000 schrieb Jaft:
> > > In that case, I'm not sure that I have enough experience or
> > > knowledge with make tools to be able to untangle things, I'm
> > > afraid.
> > Fair enough, on the top of my head I'm not too sure how to untangle
> > this either.  However, note that mega-sdk appears pretty useless as
> > a standalone package, so I'd like to solve that issue before
> > pushing it.
> 
> That's fair; I had been first trying to get it added as a package as
> I was trying to package up MEGAsync and, as you might imagine, this
> is a dependency of it. I've nearly got the MEGAsync package working
> but need to get icons working properly, still; if I'm able to get it,
> would it make sense to send a patch here and move forward with that
> package?
Sure.  As long as there's a consumer to test that the package is
working as expected, everything ought to be fine.  I don't know which
road will be the easier one, however.




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-02-13  8:44 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <29>
2022-02-04  0:34 ` [bug#52238] [PATCH] gnu: megacmd: Add mega-sdk as dependency Wamm K. D
2022-02-04 18:18   ` Liliana Marie Prikler
2022-02-05  3:05     ` Jaft
2022-02-05  6:59       ` Liliana Marie Prikler
2022-02-13  8:34         ` Jaft
2022-02-13  8:42           ` Liliana Marie Prikler

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).