From: Bruno Victal <mirai@makinata.eu>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 62056@debbugs.gnu.org
Subject: [bug#62056] [PATCH] guix: Only issue erase-current-line sequence for ttys.
Date: Sun, 28 May 2023 10:54:36 +0100 [thread overview]
Message-ID: <7e2399a1-e073-cf11-612d-b130ec71fa54@makinata.eu> (raw)
In-Reply-To: <877cu9hscn.fsf_-_@gnu.org>
Hi Ludo’,
On 2023-04-18 21:02, Ludovic Courtès wrote:
> Bruno Victal <mirai@makinata.eu> skribis:
>> On 2023-03-16 21:30, Ludovic Courtès wrote:
>>> Could you see which use of ‘erase-current-line’ is causing problems?
>>
>> guix/scripts/substitute.scm:318
>
> In this particular case, how about returning a different
> <progress-reporter> depending on ‘isatty?’?
It looks like the problem was not just at that particular line, rather
anywhere that happens to call (erase-current-line …) which in addition
to guix/scripts/substitute.scm are guix/status.scm and guix/progress.scm.
Perhaps every instance of <progress-reporter> under guix/ should be
checking whether or not they are running under a tty?
WDYT?
--
Furthermore, I consider that nonfree software must be eradicated.
Cheers,
Bruno.
next prev parent reply other threads:[~2023-05-28 9:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 15:55 [bug#62056] [PATCH] guix: Only issue erase-current-line sequence for ttys Bruno Victal
2023-03-16 21:30 ` Ludovic Courtès
2023-03-18 11:27 ` Bruno Victal
2023-04-18 20:02 ` Ludovic Courtès
2023-05-28 9:54 ` Bruno Victal [this message]
2024-06-02 20:19 ` [bug#62056] Custom progress reporter for scripts/substitute.scm Richard Sent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e2399a1-e073-cf11-612d-b130ec71fa54@makinata.eu \
--to=mirai@makinata.eu \
--cc=62056@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).