From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Suhail Singh <suhailsingh247@gmail.com>
Cc: 72406@debbugs.gnu.org, gemmaro.dev@gmail.com,
cox.katherine.e+guix@gmail.com, andrew@trop.in
Subject: [bug#72406] [PATCH emacs-team WIP 0/4] Simplify creation of emacs package variants
Date: Thu, 01 Aug 2024 06:32:26 +0200 [thread overview]
Message-ID: <7db00ce35b9ba6132a042a680c1de0bddf186afc.camel@gmail.com> (raw)
In-Reply-To: <871q39orif.fsf@gmail.com>
Am Mittwoch, dem 31.07.2024 um 23:23 -0400 schrieb Suhail Singh:
> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
>
> > With this series, we can make natively-compiled Emacs packages
> > substitutable just like their byte-compiled alternatives – to this
> > end, we also make plain emacs the default for emacs-build-system
>
> I don't follow. What's the advantage to making `emacs' the default
> for emacs-build-system as opposed to `emacs-minimal' ? If this is to
> enable native-compilation, could that not be done via `emacs-no-x'
> instead? `emacs' seems to bring in a number of additional inputs, and
> it's not clear to me that they make a better default.
>
> I propose that the patch to change the defaults for the
> emacs-build-system should perhaps be tackled in a different issue
> than the patch series that provides procedures to create variants of
> packages.
None of the emacsen are native-comp-compatible to each other.
By design: they have different feature sets, so they get different
tags.
For package naming, "emacs" should mean "emacs", not "emacs-minimal" or
"emacs-no-x".
> > and provide procedures to create emacs-next-*, emacs-minimal-*, and
> > emacs-pgtk-* variants of packages.
>
> These seem useful. However, it may help to have an example of one of
> these being used.
Example: I am personally using emacs-pgtk.
> If you split the patch series such that the current issue doesn't
> alter the default for the emacs-build-system, then it might help to
> only provide the procedure for creating an emacs-no-x-* variant
> (since they are pretty similar), and use it for a package like emacs-
> org and/or emacs-magit.
Sure, we could provide that procedure – for now I only provided those
that I'd plan to build on CI.
> > What's still left to do in this series is actually defining all of
> > them. There's quite a number of packages to go over, not all of
> > which build using emacs-build-system.
>
> For the packages that don't use the emacs-build-system today, is the
> idea to switch them to using it? If so, it might help to review that
> list.
No, they would have to be special-cased. There's a bunch of things
emacs-build-system can't account for, which are solved by a simple
Makefile. If anything, we'd extend the procedure to also capture
those.
> > And of course, building N variants of every Emacs package will not
> > make the load for CI lighter, so let's keep N small, shall we? :)
>
> If I am understanding correctly, it seems N can be 1 most of the time
> (corresponding to one of the "current" variants). Sometimes we may
> need a "next" variant, but in those cases a "current" variant likely
> wouldn't suffice.
N should be the number of Emacsen in practical use by the Guix
community, which is currently >= 2.
Cheers
next prev parent reply other threads:[~2024-08-01 4:34 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 19:58 [bug#72406] [PATCH emacs-team WIP 0/4] Simplify creation of emacs package variants Liliana Marie Prikler
2024-07-31 18:41 ` [bug#72406] [PATCH emacs-team WIP 2/4] build-system: emacs: Make emacs the default variant Liliana Marie Prikler
2024-07-31 18:42 ` [bug#72406] [PATCH emacs-team WIP 3/4] build-system: emacs: Define common variants Liliana Marie Prikler
2024-07-31 19:54 ` [bug#72406] [PATCH emacs-team WIP 4/4] etc: Provide snippet for defining emacs variants Liliana Marie Prikler
2024-07-31 19:57 ` [bug#72406] [PATCH emacs-team WIP 1/4] build-system: emacs: Define package-with-explicit-emacs Liliana Marie Prikler
2024-08-01 3:23 ` [bug#72406] [PATCH emacs-team WIP 0/4] Simplify creation of emacs package variants Suhail Singh
2024-08-01 4:32 ` Liliana Marie Prikler [this message]
2024-08-01 6:02 ` Suhail Singh
2024-08-01 16:54 ` Liliana Marie Prikler
2024-08-01 19:40 ` Suhail Singh
2024-08-11 12:59 ` [bug#72406] [PATCH emacs-team WIP v4 00/24] Build variants for other Emacsen Liliana Marie Prikler
2024-08-11 12:58 ` [bug#72406] [PATCH emacs-team WIP v4 01/24] build-system: emacs: Define package-with-explicit-emacs Liliana Marie Prikler
2024-09-03 15:18 ` Simon Tournier
2024-08-11 12:58 ` [bug#72406] [PATCH emacs-team WIP v4 03/24] build-system: emacs: Define common variants Liliana Marie Prikler
2024-09-03 15:21 ` Simon Tournier
2024-09-03 15:39 ` Simon Tournier
2024-08-11 12:58 ` [bug#72406] [PATCH emacs-team WIP v4 02/24] build-system: emacs: Make emacs the default variant Liliana Marie Prikler
2024-09-03 15:29 ` Simon Tournier
2024-08-11 12:58 ` [bug#72406] [PATCH emacs-team WIP v4 04/24] build-system: emacs: Handle variants in elpa naming Liliana Marie Prikler
2024-08-11 12:58 ` [bug#72406] [PATCH emacs-team WIP v4 05/24] etc: Provide snippet for defining emacs variants Liliana Marie Prikler
2024-08-11 12:58 ` [bug#72406] [PATCH emacs-team WIP v4 06/24] gnu: emacs-libgit: Build variants Liliana Marie Prikler
2024-09-03 15:32 ` Simon Tournier
2024-09-03 16:57 ` Liliana Marie Prikler
2024-08-11 12:58 ` [bug#72406] [PATCH emacs-team WIP v4 10/24] gnu: emacs-fontaine: Reindent Liliana Marie Prikler
2024-08-11 12:58 ` [bug#72406] [PATCH emacs-team WIP v4 07/24] gnu: emacs-eweouz: Build variants Liliana Marie Prikler
2024-09-03 15:47 ` Simon Tournier
2024-08-11 12:58 ` [bug#72406] [PATCH emacs-team WIP v4 08/24] gnu: emacs-tablist: Define variants Liliana Marie Prikler
2024-08-11 12:58 ` [bug#72406] [PATCH emacs-team WIP v4 09/24] gnu: emacs-pdf-tools: Build variants Liliana Marie Prikler
2024-08-11 12:58 ` [bug#72406] [PATCH emacs-team WIP v4 13/24] gnu: emacs-edit-indirect: Define variants Liliana Marie Prikler
2024-08-11 12:58 ` [bug#72406] [PATCH emacs-team WIP v4 14/24] gnu: emacs-geiser: " Liliana Marie Prikler
2024-08-11 12:58 ` [bug#72406] [PATCH emacs-team WIP v4 11/24] gnu: emacs-bui: " Liliana Marie Prikler
2024-08-11 12:58 ` [bug#72406] [PATCH emacs-team WIP v4 12/24] gnu: emacs-dash: " Liliana Marie Prikler
2024-08-11 12:58 ` [bug#72406] [PATCH emacs-team WIP v4 19/24] gnu: emacspeak: Build variants Liliana Marie Prikler
2024-08-11 12:58 ` [bug#72406] [PATCH emacs-team WIP v4 20/24] gnu: emacs-xelb: " Liliana Marie Prikler
2024-08-11 12:58 ` [bug#72406] [PATCH emacs-team WIP v4 18/24] [WIP] gnu: emacs-dvc: " Liliana Marie Prikler
2024-08-11 12:58 ` [bug#72406] [PATCH emacs-team WIP v4 15/24] gnu: emacs-geiser-guile: Define variants Liliana Marie Prikler
2024-08-11 12:58 ` [bug#72406] [PATCH emacs-team WIP v4 17/24] gnu: emacs-guix: Build variants Liliana Marie Prikler
2024-08-11 12:58 ` [bug#72406] [PATCH emacs-team WIP v4 16/24] gnu: emacs-magit-popup: Define variants Liliana Marie Prikler
2024-08-11 12:58 ` [bug#72406] [PATCH emacs-team WIP v4 21/24] gnu: emacs-exwm: Build variants Liliana Marie Prikler
2024-08-11 12:58 ` [bug#72406] [PATCH emacs-team WIP v4 22/24] gnu: emacs-exwm-x: " Liliana Marie Prikler
2024-08-11 12:58 ` [bug#72406] [PATCH emacs-team WIP v4 24/24] gnu: Build all the other emacs-* variants Liliana Marie Prikler
2024-08-11 12:58 ` [bug#72406] [PATCH emacs-team WIP v4 23/24] gnu: eless: Build variants Liliana Marie Prikler
2024-09-03 15:51 ` [bug#72406] [PATCH emacs-team WIP v4 00/24] Build variants for other Emacsen Simon Tournier
2024-09-03 16:52 ` Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7db00ce35b9ba6132a042a680c1de0bddf186afc.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=72406@debbugs.gnu.org \
--cc=andrew@trop.in \
--cc=cox.katherine.e+guix@gmail.com \
--cc=gemmaro.dev@gmail.com \
--cc=suhailsingh247@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).