From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id uPQiIX9oC2ITkwAAgWs5BA (envelope-from ) for ; Tue, 15 Feb 2022 09:46:55 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id CP0DGn9oC2LrHQEAG6o9tA (envelope-from ) for ; Tue, 15 Feb 2022 09:46:55 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id C32D136F02 for ; Tue, 15 Feb 2022 09:46:54 +0100 (CET) Received: from localhost ([::1]:54146 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nJtU5-00007e-3y for larch@yhetil.org; Tue, 15 Feb 2022 03:46:53 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42964) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nJtTm-000078-H3 for guix-patches@gnu.org; Tue, 15 Feb 2022 03:46:37 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:49528) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nJtTG-0000vN-Ld for guix-patches@gnu.org; Tue, 15 Feb 2022 03:46:33 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nJtTG-0001Ly-Hn for guix-patches@gnu.org; Tue, 15 Feb 2022 03:46:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#53995] [PATCH] gnu: rbw: Update to 1.4.3 Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 15 Feb 2022 08:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53995 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Nicolas Graves Cc: 53995@debbugs.gnu.org Received: via spool by 53995-submit@debbugs.gnu.org id=B53995.16449147585190 (code B ref 53995); Tue, 15 Feb 2022 08:46:02 +0000 Received: (at 53995) by debbugs.gnu.org; 15 Feb 2022 08:45:58 +0000 Received: from localhost ([127.0.0.1]:43425 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJtTC-0001Le-2o for submit@debbugs.gnu.org; Tue, 15 Feb 2022 03:45:58 -0500 Received: from baptiste.telenet-ops.be ([195.130.132.51]:60278) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nJtTA-0001LT-BW for 53995@debbugs.gnu.org; Tue, 15 Feb 2022 03:45:57 -0500 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by baptiste.telenet-ops.be with bizsmtp id vLlu2600C4UW6Th01Llu2P; Tue, 15 Feb 2022 09:45:54 +0100 Message-ID: <7d19f36e73cbb3fb2ede965162bc2e7ac96506a8.camel@telenet.be> From: Maxime Devos Date: Tue, 15 Feb 2022 09:45:49 +0100 In-Reply-To: <87zgms4krn.fsf@ngraves.fr> References: <87r185y4gm.fsf@ngraves.fr> <52f2be01de0179ccc846ef74bca125389446b619.camel@telenet.be> <87zgms4krn.fsf@ngraves.fr> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-lYQqwGCL/7M3+4eYzrmc" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1644914754; bh=ozGEL2GhJ0BinFLHaWfH2n9I90QCl+aNd1WeexIkmcM=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=K72z8k1dv+34PHg9kttaPrSmVPEMtwkQm8660Cnpx0ccTj1XuytoUARAqZN8JIIWU 9FItJjy0+twziNzOVdS2IrvTjJkTgoALPe8Z24rYw0uktDaRN2XdZ0yOsHQBgDikp2 6UUNpOZ3EKbPaUrd5HVR9qUMLVeVnVZkCobCcw4pg5q+MxXRIG6XESQN1mLYhPEf/g KVy20ObRJdNW62E9BU3VHBjmrLJaVKknxZpE1KPX5p/SYqECdJ1R/migHXAH97E+6t WaPmstUQB/TqWAB0HAOhS7vnH7gM+YgnLwEztyWbWUQol3JZPxfsBZ5OK2ZLyv+h+i 1usxsUEvRliNQ== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644914815; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=ozGEL2GhJ0BinFLHaWfH2n9I90QCl+aNd1WeexIkmcM=; b=tAEwr/XYy1NyE908V/gyE7xqwDVTXD5iLX+5AFnpzOEktw5S3dY0obI6r5OItT5kFPyfG4 SSHYPRiT3WsUtBmAH7wcmMWz4tP+rdpfc1Ssi8rJXmgP5iKQGcdI9GQonRPvTIxsmpbJaH p1A2AOZNteWEEBDS+elR/AuYOMC86sZCHyMzfYNuHTb6K1IoJkl1zOX8hYitbVoF4Bd8YM Z79i8RDzND4sUvvqFRL9QwxzI1XMq9qd/WUphV0tIZsVGZrk4+5YQ1zZ5iOUzYMEaGpdXk atZ0+m6Ng8qxHzhciuQpB3mO5qNoXcMglVyrd6ByrhH9iLSJ0eo9I7AljhKlSA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644914815; a=rsa-sha256; cv=none; b=pMLocx2k0O9xwbf2gWDVmgo8t4a9fADM8BiiR16/P/XLD6yM4eusoCAo580KgdUIT6gWN8 YwjU488na+CXSVyOF6gAjWbpV6qFEXs33cKwO2fboHD5a1KSVOGM7vtXyY7c9Ucb+ZOFDc 11MCv1TaBdibUXsCW4jMKEyVVgtnGek1mWph6+ivC6Zb/Py3pTWdWAP5DglBSTJz1wt3De PMCLJ0OJrGrywH6uTopHTFERZ6EKegxYCm+Sc0G7L/xjBqOy6b2T2gSF1BBMU+DkyWQBof xGgyKNkhDH4wmzpq1co/SoFhezy/bxxO5MaF+pi/ynlNm7MBHJsEcsoV8py+sQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=K72z8k1d; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.23 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=K72z8k1d; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: C32D136F02 X-Spam-Score: -4.23 X-Migadu-Scanner: scn1.migadu.com X-TUID: ce6MhPGiM7o6 --=-lYQqwGCL/7M3+4eYzrmc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Nicolas Graves schreef op di 15-02-2022 om 08:50 [+0100]: > Hi Maxime, >=20 > Do you mean updating packages and adding packages ? >=20 > I added two packages because they were now needed for rbw: > - rust-valuable-derive-0.1 > - rust-valuable-0.1 >=20 > Also I (maybe questionnably) updated 2 packages that are used elsewhere : > - rust-hyper-rustls-0.22 --> rust-hyper-rustls-0.23 > - rust-tokio-rustls-0.22 --> rust-tokio-rustls-0.23 I count at least 21 package updates. > The sole "patch" I can see is that of rbw in rust-apps: the only change > is the deletion of now unneeded "relax-requirements". With 'patch', I meant 0001-gnu-rbw-Update-to-1.4.3.patch. > Is it clearer ? What precisely can I split to ease the review ? Last > time I contributed, I made ~40 patches for each individual package > added, seemed too much. To ease review, I recommend 1 patch per package update and 1 patch per new package. From (guix)Submitting Patches: 13. Verify that your patch contains only one set of related changes. Bundling unrelated changes together makes reviewing harder and slower. Examples of unrelated changes include the addition of several packages, or a package update along with fixes to that package. The total size of the changes remains the same, so splitting patches does not make things =E2=80=98too much=E2=80=99 anymore than the original p= atch would be =E2=80=98too much=E2=80=99. Splitting patches makes it easier to respon= d to individual parts. Also, a commit message was missing. Additionally, I recommend setting the "--base" option of "git format-patch/git send-email" to help with rebasing. Greetings, Maxime. --=-lYQqwGCL/7M3+4eYzrmc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYgtoPRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7lCcAP0XW1AQYdy66GdHyuPB4vU7j5Jo AnKj2pyNQx1mGHyGzwEA6quPib5/cc0WfCuiZj00JZ7xJ41/WHoQSbWLr51O4wI= =kPF2 -----END PGP SIGNATURE----- --=-lYQqwGCL/7M3+4eYzrmc--