From: Vivien Kraus via Guix-patches via <guix-patches@gnu.org>
To: 65828@debbugs.gnu.org
Cc: rg@raghavgururajan.name, liliana.prikler@gmail.com,
maxim.cournoyer@gmail.com
Subject: [bug#65828] [gnome-team v4 1/3] gnu: gegl: Update to 0.4.46.
Date: Fri, 8 Sep 2023 18:50:18 +0200 [thread overview]
Message-ID: <7c2d7e28fc1f905412782a1e7d20c8b1de403bfd.1694559697.git.vivien@planete-kraus.eu> (raw)
In-Reply-To: <cover.1694559696.git.vivien@planete-kraus.eu>
* gnu/packages/gimp.scm (gegl): Update to 0.4.46.
---
gnu/local.mk | 1 +
gnu/packages/gimp.scm | 6 +-
.../gegl-compatibility-old-librsvg.patch | 80 +++++++++++++++++++
3 files changed, 85 insertions(+), 2 deletions(-)
create mode 100644 gnu/packages/patches/gegl-compatibility-old-librsvg.patch
diff --git a/gnu/local.mk b/gnu/local.mk
index 69be1a07c7..c29e99ba38 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -1238,6 +1238,7 @@ dist_patch_DATA = \
%D%/packages/patches/gdm-remove-hardcoded-xwayland-path.patch \
%D%/packages/patches/gdm-wayland-session-wrapper-from-env.patch \
%D%/packages/patches/gdm-pass-gdk-pixbuf-loader-env.patch \
+ %D%/packages/patches/gegl-compatibility-old-librsvg.patch \
%D%/packages/patches/gemmi-fix-pegtl-usage.patch \
%D%/packages/patches/gemmi-fix-sajson-types.patch \
%D%/packages/patches/genimage-mke2fs-test.patch \
diff --git a/gnu/packages/gimp.scm b/gnu/packages/gimp.scm
index b1ff08d652..167de97ec5 100644
--- a/gnu/packages/gimp.scm
+++ b/gnu/packages/gimp.scm
@@ -215,7 +215,7 @@ (define-public babl
(define-public gegl
(package
(name "gegl")
- (version "0.4.42")
+ (version "0.4.46")
(source
(origin
(method url-fetch)
@@ -228,8 +228,10 @@ (define-public gegl
(string-append "ftp://ftp.gtk.org/pub/gegl/"
(version-major+minor version)
"/gegl-" version ".tar.xz")))
+ (patches
+ (search-patches "gegl-compatibility-old-librsvg.patch"))
(sha256
- (base32 "0bg0vlmj4n9x1291b9fsjqxsal192zlg48pa57f6xid6p863ma5b"))))
+ (base32 "14p8n6vily0yp6gqafl2xy7d2rh1j48pcj0a7mglqxy83d4b5cyh"))))
(build-system meson-build-system)
(arguments
`(#:configure-flags
diff --git a/gnu/packages/patches/gegl-compatibility-old-librsvg.patch b/gnu/packages/patches/gegl-compatibility-old-librsvg.patch
new file mode 100644
index 0000000000..3e5733f9fd
--- /dev/null
+++ b/gnu/packages/patches/gegl-compatibility-old-librsvg.patch
@@ -0,0 +1,80 @@
+From a99a93e5c9013bd4101f5058cdee7d0cf30234fe Mon Sep 17 00:00:00 2001
+Message-ID: <a99a93e5c9013bd4101f5058cdee7d0cf30234fe.1694554961.git.vivien@planete-kraus.eu>
+From: Jehan <jehan@girinstud.io>
+Date: Wed, 5 Jul 2023 21:18:19 +0200
+Subject: [PATCH] Issue #333: continuing to support librsvg 2.40.x (C
+ versions).
+
+Commit 9beeefcbe uses too new functions of librsvg. We could just bump
+the minimum required version but there are issues with Rust not being
+available on every platform yet. So instead, let's add some conditional
+code paths, so that it still builds with librsvg 2.40.x (which was the
+last versions fully in C) while we use newer code and no warnings when
+using newer versions.
+---
+ operations/external/svg-load.c | 25 ++++++++++++++++++++-----
+ 1 file changed, 20 insertions(+), 5 deletions(-)
+
+diff --git a/operations/external/svg-load.c b/operations/external/svg-load.c
+index 3312a0c0a..15c0b30b7 100644
+--- a/operations/external/svg-load.c
++++ b/operations/external/svg-load.c
+@@ -76,16 +76,25 @@ query_svg (GeglOperation *operation)
+ {
+ GeglProperties *o = GEGL_PROPERTIES (operation);
+ Priv *p = (Priv*) o->user_data;
++#if LIBRSVG_CHECK_VERSION(2, 52, 0)
+ gdouble out_width, out_height;
++#else
++ RsvgDimensionData dimensions;
++#endif
+
+ g_return_val_if_fail (p->handle != NULL, FALSE);
+
+- rsvg_handle_get_intrinsic_size_in_pixels (p->handle, &out_width, &out_height);
+-
+ p->format = babl_format ("R'G'B'A u8");
+
++#if LIBRSVG_CHECK_VERSION(2, 52, 0)
++ rsvg_handle_get_intrinsic_size_in_pixels (p->handle, &out_width, &out_height);
+ p->height = out_height;
+- p->width = out_width;
++ p->width = out_width;
++#else
++ rsvg_handle_get_dimensions (p->handle, &dimensions);
++ p->height = dimensions.height;
++ p->width = dimensions.width;
++#endif
+
+ return TRUE;
+ }
+@@ -98,10 +107,12 @@ load_svg (GeglOperation *operation,
+ {
+ GeglProperties *o = GEGL_PROPERTIES (operation);
+ Priv *p = (Priv*) o->user_data;
+- RsvgRectangle svg_rect = {0.0, 0.0, width, height};
+ cairo_surface_t *surface;
+ cairo_t *cr;
+- GError *error = NULL;
++#if LIBRSVG_CHECK_VERSION(2, 52, 0)
++ GError *error = NULL;
++ RsvgRectangle svg_rect = {0.0, 0.0, width, height};
++#endif
+
+ g_return_val_if_fail (p->handle != NULL, -1);
+
+@@ -115,7 +126,11 @@ load_svg (GeglOperation *operation,
+ (double)height / (double)p->height);
+ }
+
++#if LIBRSVG_CHECK_VERSION(2, 52, 0)
+ rsvg_handle_render_document (p->handle, cr, &svg_rect, &error);
++#else
++ rsvg_handle_render_cairo (p->handle, cr);
++#endif
+
+ cairo_surface_flush (surface);
+
+--
+2.41.0
+
--
2.41.0
next prev parent reply other threads:[~2023-09-12 23:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 16:57 [bug#65828] [gnome-team 0/1] Update gegl Vivien Kraus via Guix-patches via
2023-09-08 16:50 ` [bug#65828] [gnome-team 1/1] gnu: gegl: Update to 0.4.46 Vivien Kraus via Guix-patches via
2023-09-08 18:23 ` [bug#65828] [gnome-team 0/1] Update gegl Liliana Marie Prikler
2023-09-08 18:40 ` [bug#65828] [gnome-team v2 0/2] Update gegl and gimp Vivien Kraus via Guix-patches via
2023-09-08 16:50 ` [bug#65828] [gnome-team v2 1/2] gnu: gegl: Update to 0.4.46 Vivien Kraus via Guix-patches via
2023-09-08 18:37 ` [bug#65828] [gnome-team v2 2/2] gnu: gimp: Update to 2.10.34 Vivien Kraus via Guix-patches via
2023-09-12 17:17 ` [bug#65828] [gnome-team 0/1] Update gegl Vivien Kraus via Guix-patches via
2023-09-12 18:41 ` Liliana Marie Prikler
2023-09-12 19:20 ` Vivien Kraus via Guix-patches via
2023-09-12 20:25 ` Liliana Marie Prikler
2023-09-12 22:16 ` [bug#65828] [gnome-team v3 0/2] Silly me, that was already fixed upstream Vivien Kraus via Guix-patches via
2023-09-08 16:50 ` [bug#65828] [gnome-team v3 1/2] gnu: gegl: Update to 0.4.46 Vivien Kraus via Guix-patches via
2023-09-08 18:37 ` [bug#65828] [gnome-team v3 2/2] gnu: gimp: Update to 2.10.34 Vivien Kraus via Guix-patches via
2023-09-12 23:01 ` [bug#65828] [gnome-team v4 0/3] Gegl 0.4.46 does not work yet with gnome-photos Vivien Kraus via Guix-patches via
2023-09-08 16:50 ` Vivien Kraus via Guix-patches via [this message]
2023-09-08 18:37 ` [bug#65828] [gnome-team v4 3/3] gnu: gimp: Update to 2.10.34 Vivien Kraus via Guix-patches via
2023-09-12 22:52 ` [bug#65828] [gnome-team v4 2/3] gnu: gegl: Add version 0.4.44 for gnome-photos Vivien Kraus via Guix-patches via
2023-09-13 4:18 ` Liliana Marie Prikler
2023-09-13 5:01 ` [bug#65828] [gnome-team v5 0/2] Update and fix gegl in one patch Vivien Kraus via Guix-patches via
2023-09-08 16:50 ` [bug#65828] [gnome-team v5 1/2] gnu: gegl: Update to 0.4.46 Vivien Kraus via Guix-patches via
2023-09-08 18:37 ` [bug#65828] [gnome-team v5 2/2] gnu: gimp: Update to 2.10.34 Vivien Kraus via Guix-patches via
2023-09-15 16:15 ` bug#65828: " Liliana Marie Prikler
2023-09-14 5:02 ` [bug#65828] [gnome-team v4 2/3] gnu: gegl: Add version 0.4.44 for gnome-photos Vivien Kraus via Guix-patches via
2023-09-15 4:20 ` Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c2d7e28fc1f905412782a1e7d20c8b1de403bfd.1694559697.git.vivien@planete-kraus.eu \
--to=guix-patches@gnu.org \
--cc=65828@debbugs.gnu.org \
--cc=liliana.prikler@gmail.com \
--cc=maxim.cournoyer@gmail.com \
--cc=rg@raghavgururajan.name \
--cc=vivien@planete-kraus.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).