From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id AM/gCcRrWGFDDwEAgWs5BA (envelope-from ) for ; Sat, 02 Oct 2021 16:25:08 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id WHKPBcRrWGEybgAA1q6Kng (envelope-from ) for ; Sat, 02 Oct 2021 14:25:08 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E1AA32E8FC for ; Sat, 2 Oct 2021 16:25:07 +0200 (CEST) Received: from localhost ([::1]:48294 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWfwp-00035P-2Z for larch@yhetil.org; Sat, 02 Oct 2021 10:25:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46554) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWfuo-0007om-8x for guix-patches@gnu.org; Sat, 02 Oct 2021 10:23:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:48634) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mWfun-0000CF-Sp for guix-patches@gnu.org; Sat, 02 Oct 2021 10:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mWfun-0004Mg-PG for guix-patches@gnu.org; Sat, 02 Oct 2021 10:23:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#50960] [PATCH 10/10] shell: Maintain a profile cache. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 02 Oct 2021 14:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50960 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 50960@debbugs.gnu.org Received: via spool by 50960-submit@debbugs.gnu.org id=B50960.163318456716758 (code B ref 50960); Sat, 02 Oct 2021 14:23:01 +0000 Received: (at 50960) by debbugs.gnu.org; 2 Oct 2021 14:22:47 +0000 Received: from localhost ([127.0.0.1]:60180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWfuZ-0004ME-Cj for submit@debbugs.gnu.org; Sat, 02 Oct 2021 10:22:47 -0400 Received: from albert.telenet-ops.be ([195.130.137.90]:39356) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWfuW-0004M3-Nj for 50960@debbugs.gnu.org; Sat, 02 Oct 2021 10:22:45 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by albert.telenet-ops.be with bizsmtp id 12Ni260090mfAB4062NiEN; Sat, 02 Oct 2021 16:22:43 +0200 Message-ID: <7c07bacb08ead4ee3f36b7ff034d3eff82a814ab.camel@telenet.be> From: Maxime Devos Date: Sat, 02 Oct 2021 16:22:42 +0200 In-Reply-To: <87ee93y0n9.fsf@gnu.org> References: <20211002102240.27815-1-ludo@gnu.org> <20211002102240.27815-10-ludo@gnu.org> <6c199526d88150c31461e3b7f9e76909217e658c.camel@telenet.be> <87ee93y0n9.fsf@gnu.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-5Q78Cene2ntdHSC8tJk3" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1633184563; bh=my9/9Zew4VKRud5q7u9oxs7hf1oPjoiy/0TObI533WQ=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=W/ZoXY+K9z6ibO65RljhOz35ZyXGDZdUn8n9P20x/MTBMTs7nyM0PvoiIIgja3/OE 5Viz7AY2cEtaGJpyeKyvnpAxgN6qwaBSI6uVl3LftxwBrGKjzEUJpljApgrsMvKNMM Ws6/fyYuc7BgBiV/RYiSWp6iHe4QGwoLuPAwgeftJv7rY6c8XfMXPTs5iwks82PZWR h0AdB8FTnUqWdWrTUPPkKbGdsCnrmyTnfFuhkKgTQkWskzdD69uw/PKqNe8hr0n58L vDcN5ccLI7siFiBroWlECaHgLDzHFgOaKFsNrR6poXnJ+Sr1KBy5QXpVGNH56QaqLh 5pQrpyWqmQXeA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1633184707; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=my9/9Zew4VKRud5q7u9oxs7hf1oPjoiy/0TObI533WQ=; b=XWZ67e/4WubB89NwcF9GPHLANDedUiGaQH67zYpWIxtWN2t/Z1CgZeTJyL8t1SvHMNWNF3 7UOAI/7Qu3wz5JiOhTDJlYbMOXw/gremAEUf8gP5s63+lyk6GY+dYQZ7azUAD06Hu3BPDr 2VSn5+WefNs+A4W7dcP5CBioNiVX24UvGNxbVLTUKNhdZvtHGqd2M67jVPct0W8gakb5Od z6dLAfZ6IOORRvtHsR+lBbkGtPmEbF7c24pen6cYfKtXVb34uzTzJpO0jJi0b12kSWmiYm o6yj8ncw8dzxoJpN2OZBCDUpOHhU0TPv0aW7Rwu0FEbhKvBS6ODkFDKz1ch4YA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1633184707; a=rsa-sha256; cv=none; b=Jp2/I3OjfObPcShz2dMyN+bVUmaUwc/r/++NalNMXO38LzeYUd4/bdY8ZcsigAosGjQ/Ef iUq2DptBMttB9vdshXmzaWt1W/WMC+Bw3WEmWa9HgzKW27Bbf1odYyVMpvUlSqGzLh0YWw J7An4rqSwa04t8Xm+bNDKKwLfZ7ISZToMmKpxWsEdNGPoKwsGYuBcB6XYvnCIERsNkHKJg 3t9aRkP8/Jvrmz0ZqwJ+tH2ICRsv8+IA6D7u/6YCDcVE8L0c+0YRc5MsLYA3QfkuCeuFL0 dzH4UKYwJb1ry9XJ2WVM0rcoDXhPRgoyv2kMSP2SiWc547Zi27duiGUxmxXzxg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b="W/ZoXY+K"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.40 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b="W/ZoXY+K"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: E1AA32E8FC X-Spam-Score: -3.40 X-Migadu-Scanner: scn0.migadu.com X-TUID: 4IgGQtf9EqX0 --=-5Q78Cene2ntdHSC8tJk3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s schreef op za 02-10-2021 om 16:14 [+0200]: > > Why only use the 'basename' of a file name instead of the full name? > > (Consider the case where a user has multiple "guix.scm" or "manifest.sc= m".) > > This turns out to be unproblematic, because stat:dev and stat:ino is in= cluded > > as well, though including (a part of) the file name is superfluous beca= use > > stat:dev and stat:ino are included. > >=20 > > Could you document the rationale for including the file name, and why o= nly > > the basename is included instead of the full file name? >=20 > Actually it=E2=80=99s probably not useful to include the file (base)name.= I > think initially I thought about distinguishing between guix.scm and > manifest.scm, since they return different kinds of objects, but dev/ino > is probably enough. WDYT? Looking at https://lwn.net/Articles/866582/, it appears when BTRFS and NFS = are combined, it is possible for two dev/ino pairs to be the same for different= files. It appears to be considered a bug but non-trivial to fix. Thus, dev/ino ap= parently is not always sufficient, so it may be reasonable to include the file name. I would include the full file name, because the basename is often rather ge= neric ("guix.scm", "manifest.scm"), though this depends on the habits of the user= . Greetings, Maxime. --=-5Q78Cene2ntdHSC8tJk3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYVhrMhccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7nKHAQD6BCZGjPM4qeIqRrFG+WMLPnQV PtHseP+LHLl7P3OKnQD/Q97JX9o16rY4wMSZajmE4shFgl73moiQmbT/XHJD9gc= =rU4o -----END PGP SIGNATURE----- --=-5Q78Cene2ntdHSC8tJk3--