From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KDcHIULR2GHz2gAAgWs5BA (envelope-from ) for ; Sat, 08 Jan 2022 00:48:18 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id MFt0HkLR2GFcTAEA9RJhRA (envelope-from ) for ; Sat, 08 Jan 2022 00:48:18 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D2C662C342 for ; Sat, 8 Jan 2022 00:48:17 +0100 (CET) Received: from localhost ([::1]:51916 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5yy0-0003po-LC for larch@yhetil.org; Fri, 07 Jan 2022 18:48:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33522) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5yxm-0003pO-Mu for guix-patches@gnu.org; Fri, 07 Jan 2022 18:48:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:53156) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5yxm-0000ze-AC for guix-patches@gnu.org; Fri, 07 Jan 2022 18:48:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n5yxm-0000E3-6f for guix-patches@gnu.org; Fri, 07 Jan 2022 18:48:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH v8 00/41] guix: node-build-system: Support compiling add-ons with node-gyp. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 07 Jan 2022 23:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Philip McGrath Cc: 51838@debbugs.gnu.org, Timothy Sample , Pierre Langlois , Jelle Licht , Leo Famulari Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.1641599278849 (code B ref 51838); Fri, 07 Jan 2022 23:48:02 +0000 Received: (at 51838) by debbugs.gnu.org; 7 Jan 2022 23:47:58 +0000 Received: from localhost ([127.0.0.1]:46059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5yxh-0000Dc-VZ for submit@debbugs.gnu.org; Fri, 07 Jan 2022 18:47:58 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:37875) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5yxe-0000Cm-Qj for 51838@debbugs.gnu.org; Fri, 07 Jan 2022 18:47:56 -0500 Received: by mail-wm1-f68.google.com with SMTP id l12-20020a7bc34c000000b003467c58cbdfso5806368wmj.2 for <51838@debbugs.gnu.org>; Fri, 07 Jan 2022 15:47:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=NzcdtdIM1Pdi4CKlW+vfQ5eWLCAP20JdNLyNxWdOyE4=; b=i6ENj1WY6Dr7KAhj9bn8zXk/m4lK6kQ48AR3xi1qjQMMmL0koQdLIna40Iqb8R9G+A Pj172lFuffMiYJMXqs67Nsi1StU8n1D9utXy5BCDKvEuOo2XczQFckgWke2jtHCBCn4O zmMxMvsDeZcm0BlBkBThef79roDyIzzWbUAChtQuJuOEp26aXhSGtvUPnxNfn+X0sXvo y0cMaVae55XhW8O2mEVNFizfyMdvwx/B2qdGk4Pv3l+W4uWypjQD9hRXoCiOZlQddhYt P4O23xmAQAT0X22gRglPq7S3VwJSv253IkPG/qrQdQRFA1Ofiw+o66is30sdhjD0CKcq OSMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=NzcdtdIM1Pdi4CKlW+vfQ5eWLCAP20JdNLyNxWdOyE4=; b=LwBh82bm9sTcq8DH9wVOu5Q8ivqLjSpKUeWOlZmFy/A7hYfCa15CppP+mxUvUntqcp 0Aja3B6eEzSMVBN8PvwCrul0RRoyGUgwNwokX5vvpk47zfhQ75ee/R6vlKnYva8SrUvg qpLGYulsuRGK9VoYCcJ8SWHuVJRrOXc+47VC0VlXb6esd/0dn1v5zHwnAxviZMjgzlCz /12WmNAWF4OhQZhm9+3GWgjdbCXOHqFzA2jhZC90n18oEXx1EPkOvDfOMBfdHQY+ZyTL ddk/3I/+2j/2I6cNuIYBpzCYdAI9i1nf/JEyeoBaQRljXo5FXe+T94dnqiINaYonXQg9 d8jg== X-Gm-Message-State: AOAM532d7PYj3Y131ZhYUmGVZSDC9fVooEs9B6Ss6Jii4iRLaxC7Jud7 5z8Ywu4x3+KtVrx96j6kGgM= X-Google-Smtp-Source: ABdhPJz15sd70pHrCj1Q57/PAfK+9BYciaPNhKf0SRTs3W5bfahjlsdWlpTlbyXbYnf4B0MN2Qy79A== X-Received: by 2002:a1c:2544:: with SMTP id l65mr13045038wml.101.1641599268795; Fri, 07 Jan 2022 15:47:48 -0800 (PST) Received: from nijino.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id n41sm142896wms.32.2022.01.07.15.47.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jan 2022 15:47:48 -0800 (PST) Message-ID: <7b04af28bbd57c67093ce8f33a648efec89693bd.camel@gmail.com> From: Liliana Marie Prikler Date: Sat, 08 Jan 2022 00:47:46 +0100 In-Reply-To: References: <64e08d3a1838ed8507f33fae895545372960522f.camel@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.42.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641599297; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=NzcdtdIM1Pdi4CKlW+vfQ5eWLCAP20JdNLyNxWdOyE4=; b=A5LFbYt3uV5uhTs3NLHHBcsnH9yDSyKq+DhhD4qoAtbwIx8cB98ZMOSY4vyH9vbM6fN2Gl n8SgfVxmz2K28iXLh8FBMRPWU3fVHD7mrBnS66YZw92lRrwxAvoiX5e63HDGl8dDHYOS4t SF7CIioC5N2LXkPFJRnBPnvoxJnqYCUNN2IE2dxAtDpwx5D6BcocX24PPpMls8YauHlSXa tQl+O4ZYOASbw0/6RkC0+t4YFNzRnkg+NYpKXzExmKic/8AiZGJXzmAEPqPhE68Va6FzXw b0UGovfBlleKHdB7MkcttVtIAm5ostyonZdYZN9i1+25gpLM0CyBVvYBV1BjAg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641599298; a=rsa-sha256; cv=none; b=tPYf70BTeBFwb6POlkMBYKDbJjonvMXkYN9ei/i8Ven9Gom9PgMCdkSiViXE6Wx/5fB9j+ kMFBYzHc2e6zYQnxapILjjtVTt5wPi5tIt8qTVCWSPG2McB/Y90B+8bUfhHybgGP15f+UA SNDrZnalVyGtLvsAodiRRcT2TuYAAP8j6SCdC372ASggfP484JMHF9LD61dszpSO73t9UV BiWaeaMNwgyDoJDp0cJP8EpQc6WBWkvn5y2gXjehmwav1DHj62clkBKT3LP1x0FQwri+jH nran7S00S98JEb/OCSfYuZKc5BoCOPKr3QV30ql5CxRSPNEI5Bvu/LDJP/Sxng== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=i6ENj1WY; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.00 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=i6ENj1WY; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: D2C662C342 X-Spam-Score: -2.00 X-Migadu-Scanner: scn1.migadu.com X-TUID: YYvV4ZSH6xiq Hi, Am Freitag, dem 07.01.2022 um 17:11 -0500 schrieb Philip McGrath: > I think this is not quite correct. > > (Actually, I suspect more broadly that node-build-system's handling > of peerDependencies is not quite correct, but wrapping my head around > the semantics of peerDependencies is on my to-do list for after these > patches are applied. Here's one thing I want to read and understand: > https://pnpm.io/how-peers-are-resolved) > > NPM does not try to install packages in "peerDependencis" during 'npm > install' (out 'configure' phase). The problem arises because because > our 'patch-dependencies' phase adds the "peerDependencies" as > additional "dependencies". (Why? I don't fully understand, but I > guess because it wants them to be installed.) We want absent > "peerDependencies" to not be listed in "dependencies", but I don't > think we want to delete them from "peerDependencies": at a minimum, > we do not need to, and it seems like it might cause problems that I > don't fully understand. > > (This is one of the reasons I preferred to handle absent dependencies > in the 'patch-dependencies' phase.) I'd like to be able to understand that too, but npm still boggles my mind. I think node-build-system's implementation is a rather pragmatic one; it forces you to use just a single combination of versions for all of those rather than relying on node trickery (on a related note, perhaps we ought to make inputs in node-build-system propagated-inputs to be on the safe side). > > 4. Regexps :) > > Hopefully addressed in my previous email :) Jelle makes good > arguments for the no-regexps side. I'm genuinely on the fence, which > suggests to me the best course might be to leave it as a possible > future extension (as we're doing with '#:absent-dependencies'). We do already have threads on the regexp thing, so I'm not going to respond here to keep it manageable. The change is a rather small one inside node-build-system itself, but you have to expand those strings again ;) > For the patches where you've made substantive changes to the > implementation or the commit message, maybe there should be more of > an annotation than just "Signed-off-by". I'm not super familiar with > the Git etiquette here, but one suggestion I've seen is something > like: > >      Signed-off-by: Random J Developer >      [lucky@maintainer.example.org: struct foo moved from foo.c to > foo.h] >      Signed-off-by: Lucky K Maintainer > > It's not a big deal, I could just imagine getting confused some > months or years from now about what exactly I wrote or didn't write. > (TBH the numerous versions of this series are already a bit > unwieldy.) If you don't like my phrasing in a particular message, you are free to change it for v9 (or if you don't want a v9 to be reviewed, just reply to the individual one with how you'd reword it and I'll try to keep my changes to your version minimal). I simply tried to adapt your messages to the generally accepted style, which means moving long-form discussions out of the ChangeLog into the message body and correcting every variable to variable. Now I do admit that I used some more flowery parts for 3-5 and that's completely on me, but 3 already has me as Co-Author anyway. > Time permitting, I'll send some more comments, but the only things I > think need to be addressed before merging are peerDependencies and > regexps. Cool. Let's just not forget to send a v9 once we have what looks like to be a reasonable action (assuming it's not a do-nothing, in which case I just need to reword some of your commit messages again). In my personal experience, patches help a stalled discussion tremendously. Cheers