From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60950)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dgY0J-0005m1-3J
	for guix-patches@gnu.org; Sat, 12 Aug 2017 11:07:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dgY0E-0008Vn-W3
	for guix-patches@gnu.org; Sat, 12 Aug 2017 11:07:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:48032)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dgY0E-0008VY-Gg
	for guix-patches@gnu.org; Sat, 12 Aug 2017 11:07:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dgY0E-0002YJ-3x
	for guix-patches@gnu.org; Sat, 12 Aug 2017 11:07:02 -0400
Subject: [bug#28060] [PATCH] gnu: Add emacs-nixos-mode.
Resent-Message-ID: <handler.28060.B28060.15025504059805@debbugs.gnu.org>
Message-Id: <7a592bd0.ADkAACozouwAAAAAAAAAAAPfggsAAAACwQwAAAAAAAW9WABZjxmB@mailjet.com>
MIME-Version: 1.0
From: Arun Isaac <arunisaac@systemreboot.net>
Date: Sat, 12 Aug 2017 20:36:28 +0530
In-reply-to: <87shgx2rql.fsf@gmail.com>
References: <87shgx2rql.fsf@gmail.com>
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Oleg Pykhalov <go.wigust@gmail.com>
Cc: 28060@debbugs.gnu.org


Thanks for the patch!

Oleg Pykhalov writes:

> +(define-public emacs-nixos-mode
> +  (package
> +    (name "emacs-nixos-mode")
> +    (version "1.11.13")

misc/emacs/nix-mode.el says the version number is 1.0. This contradicts
the release version number 1.11.13. But, I guess we can go with the
release version number.

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'chdir-elisp
> +           (lambda _
> +             (chdir "misc/emacs"))))))

It is kinda obvious, but do add a short comment explaining why we are
changing directory.

> +    (synopsis "Emacs major mode for editing Nix expressions")
> +    (description "@code{nixos-mode} provides an Emacs major mode for edi=
ting
> +Nix expressions.")

Could you add the following line to the description?

"It supports syntax highlighting, indenting and refilling of comments."

I have taken the above sentence from
https://github.com/NixOS/nix/blob/master/misc/emacs/README

> +    (license license:gpl3+)))

Nix is under the LGPL 2.1 license. So, nix-mode should also be under the
same license, right?

Could you send an updated patch? Thanks!
=