[bug#72596] [PATCH] gnu: mrg: Fix the build.

[bug#72596] [PATCH] gnu: mrg: Fix the build.

[Artyom V. Poptsov]

* gnu/packages/graphics.scm (mrg): Fix the build.
[arguments]: Add "patch-meson-build" phase.
[home-page]: Fix the URL.

Change-Id: If6f1a255e864669a10c646ee0d991e6fabdcb6b9
---
 gnu/packages/graphics.scm | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/graphics.scm b/gnu/packages/graphics.scm
index 8eae1ed89d..1d5fc1e4da 100644
--- a/gnu/packages/graphics.scm
+++ b/gnu/packages/graphics.scm
@@ -162,6 +162,16 @@ (define-public mmm
        (sha256
         (base32 "1xmcv6rwinqsbr863rgl9005h2jlmd7k2qrwsc1h4fb8r61ykpjl"))))
     (build-system meson-build-system)
+    (arguments
+     (list #:phases #~(modify-phases %standard-phases
+                        ;; XXX: Meson build fails due to a misspelling of
+                        ;; "description" keyword in the configuration.  This phase
+                        ;; fixes that.
+                        (add-after 'unpack 'patch-meson-build
+                          (lambda _
+                            (substitute* "meson.build"
+                              (("not stable, Description:")
+                               "not stable, description:")))))))
     (native-inputs
      (list luajit pkg-config))
     (inputs
@@ -169,7 +179,7 @@ (define-public mmm
     (synopsis "Memory Mapped Machine")
     (description "MMM is a shared memory protocol for virtualising access to
 framebuffer graphics, audio output and input event.")
-    (home-page "https://github.com/hodefoting/mrg")
+    (home-page "https://github.com/hodefoting/mmm")
     (license license:isc)))
 
 (define-public directfb

base-commit: 487dd0077fed2ef7a91bd71af0e23421ab715710
-- 
2.45.2

[bug#72596] [PATCH] gnu: mrg: Fix the build.

[Zheng Junjie]

[-- Attachment #1: Type: text/plain, Size: 1997 bytes --]

"Artyom V. Poptsov" <poptsov.artyom@gmail.com> writes:

> * gnu/packages/graphics.scm (mrg): Fix the build.
> [arguments]: Add "patch-meson-build" phase.
> [home-page]: Fix the URL.
>
> Change-Id: If6f1a255e864669a10c646ee0d991e6fabdcb6b9
> ---
>  gnu/packages/graphics.scm | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/graphics.scm b/gnu/packages/graphics.scm
> index 8eae1ed89d..1d5fc1e4da 100644
> --- a/gnu/packages/graphics.scm
> +++ b/gnu/packages/graphics.scm
> @@ -162,6 +162,16 @@ (define-public mmm
>         (sha256
>          (base32 "1xmcv6rwinqsbr863rgl9005h2jlmd7k2qrwsc1h4fb8r61ykpjl"))))
>      (build-system meson-build-system)
> +    (arguments
> +     (list #:phases #~(modify-phases %standard-phases
> +                        ;; XXX: Meson build fails due to a misspelling of
> +                        ;; "description" keyword in the configuration.  This phase
> +                        ;; fixes that.
> +                        (add-after 'unpack 'patch-meson-build
> +                          (lambda _
> +                            (substitute* "meson.build"
> +                              (("not stable, Description:")
> +                               "not stable, description:")))))))

see https://github.com/hodefoting/mrg/blob/master/README.md
Microraptor gui is discontinued

maybe we should drop this package.


>      (native-inputs
>       (list luajit pkg-config))
>      (inputs
> @@ -169,7 +179,7 @@ (define-public mmm
>      (synopsis "Memory Mapped Machine")
>      (description "MMM is a shared memory protocol for virtualising access to
>  framebuffer graphics, audio output and input event.")
> -    (home-page "https://github.com/hodefoting/mrg")
> +    (home-page "https://github.com/hodefoting/mmm")

should new patch.

>      (license license:isc)))
>  
>  (define-public directfb
>
> base-commit: 487dd0077fed2ef7a91bd71af0e23421ab715710

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

bug#72596: [PATCH] gnu: mrg: Fix the build.

[Ludovic Courtès]

"Artyom V. Poptsov" <poptsov.artyom@gmail.com> skribis:

> * gnu/packages/graphics.scm (mrg): Fix the build.
> [arguments]: Add "patch-meson-build" phase.
> [home-page]: Fix the URL.
>
> Change-Id: If6f1a255e864669a10c646ee0d991e6fabdcb6b9

Finally applied, thanks!

[bug#72596] [PATCH] gnu: mrg: Fix the build.

[Ludovic Courtès]

Hi Zheng,

Zheng Junjie <zhengjunjie@iscas.ac.cn> skribis:

> "Artyom V. Poptsov" <poptsov.artyom@gmail.com> writes:
>
>> * gnu/packages/graphics.scm (mrg): Fix the build.
>> [arguments]: Add "patch-meson-build" phase.
>> [home-page]: Fix the URL.
>>
>> Change-Id: If6f1a255e864669a10c646ee0d991e6fabdcb6b9

[...]

>> +                            (substitute* "meson.build"
>> +                              (("not stable, Description:")
>> +                               "not stable, description:")))))))
>
> see https://github.com/hodefoting/mrg/blob/master/README.md
> Microraptor gui is discontinued
>
> maybe we should drop this package.

[...]

>> +    (home-page "https://github.com/hodefoting/mmm")
>
> should new patch.

I applied the patch anyway because it fixes an immediate issue, and
moving the ‘home-page’ to a separate patch is not worth the trouble and
cognitive overhead.  I hope that makes sense.

If you think there are good reasons to remove the package, maybe submit
a patch doing so?

Thanks,
Ludo’.