From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52224) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cywH0-00023j-PX for guix-patches@gnu.org; Fri, 14 Apr 2017 04:08:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cywGw-0004ju-Pk for guix-patches@gnu.org; Fri, 14 Apr 2017 04:08:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:48222) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cywGw-0004jh-Gb for guix-patches@gnu.org; Fri, 14 Apr 2017 04:08:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cywGw-0000C3-9C for guix-patches@gnu.org; Fri, 14 Apr 2017 04:08:02 -0400 Subject: bug#26488: [PATCH] gnu: Add crawl. Resent-Message-ID: Message-Id: <791d5ba7.AEQAJP3OyzEAAAAAAAAAAAO02gcAAAACwQwAAAAAAAW9WABY8IM9@mailjet.com> MIME-Version: 1.0 From: Arun Isaac Date: Fri, 14 Apr 2017 13:37:01 +0530 In-reply-to: References: <9758282d-96a4-8fe4-183b-a60a43a9eab9@cock.li> Content-Type: text/plain Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: 26488@debbugs.gnu.org Thanks for the patch! >> + (uri (list >> + ;; Older releases get moved into a versioned direct= ory >> + (string-append "http://crawl.develz.org/release/" >> + (version-major+minor version) "/ston= e_soup-" >> + version "-nodeps.tar.xz") >> + ;; Only the latest release is in this directory >> + (string-append "http://crawl.develz.org/release/sto= ne_soup-" >> + version "-nodeps.tar.xz"))) Why do we need two URIs? Shouldn't the latest release alone be enough? Isn't that the only release we need to build? >> + (arguments >> + '(#:tests? #f The release tarball does seem to come with tests. Could you package them as well? >> + #:phases >> + (modify-phases >> + %standard-phases Please put modify-phases and %standard-phases on the same line like: (modify-phases %standard-phases >> + (add-after >> + 'unpack 'prepare-before-make >> + (lambda* (#:key inputs #:allow-other-keys) >> + (chdir "source"))) I haven't actually tried building the package, but is this phase necessary? If you do want to change directory before running make, you can pass "-C" and "source" as #:make-flags. >> + (add-before >> + 'configure 'patch-makefile >> + (lambda* (#:key inputs #:allow-other-keys) >> + (substitute* >> + "Makefile" >> + (("SQLITE_INCLUDE_DIR :=3D /usr/include") >> + "SQLITE_INCLUDE_DIR :=3D ${sqlite}/include")) >> + (substitute* >> + "Makefile" >> + (("/usr/share/fonts /usr/local/share/fonts /usr/*/lib/X11= /fonts;") >> + "${dejavu_fonts}/share/fonts;")))) >> + (delete 'configure)))) You should be able to do this using #:make-flags. See https://www.gnu.org/software/make/manual/html_node/Overriding.html >> + (description "A roguelike adventure through dungeons filled with da= ngerous >> +monsters in a quest to find the mystifyingly fabulous Orb of Zot. >> +The game is also known under the name 'Dungeon Crawl Stone Soup'.") Could you make this "Dungeon Crawl Stone Soup is a roguelike adventure ... "? Also, remove the last sentence "The game is also known as ...". >> + (license license:gpl2+))) licence.txt mentions multiple licenses. Could you mention them all as a list of licenses? =