From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id AJSCAgvNAWaeqwAA62LTzQ:P1 (envelope-from ) for ; Mon, 25 Mar 2024 20:14:19 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id AJSCAgvNAWaeqwAA62LTzQ (envelope-from ) for ; Mon, 25 Mar 2024 20:14:19 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=DvyZbrxf; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1711394059; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=S+VQ3z8pyOkYqFlurxODka3Qm/h7EfjKQ7F2TJOP/AE=; b=HW97SzaXw1OoaNIFcuvILUW4osmzJP4pbkZyv87zNiKHagu7tmYOB0h4E2WNf63vc8O0CU Kzw1+gEYmSUcUQksrpKZzhB7oCkmhAns44rZdagXXHW1+1mQD+qA5tskxoQvGANcuZiqU2 k0hSRoU+H/FtqpRMLaNNKiXNlxF6oylZ1ILDu+rOui1ha8MCt0c/eDOYg6nu9xK8oJDPpv MfLKhkQtNzGMJypkDwWZLFvhC0IGKQfq9eXcd6gOc3ylhcFWLkvHQybGdBcpI1LXFHRlZo 7ScIcQy+19hpPOq3EDkAwoC2WL9h1ZGU1PFt1qNq8iirdkFhYFPr3m3gONOHow== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=protonmail.com header.s=protonmail3 header.b=DvyZbrxf; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1711394059; a=rsa-sha256; cv=none; b=QBSkOTxGybizpk223PcHYf3YCiZA3c5KqyNLSikXPUfz23AcjTT3qH1H5hOVeqjWPmRVkB N61IYu3s68G14alH/+xlFnDM5gZl9cZGFE/ZDdEj+vcUz1/qlo918P4sdXU3fh4FT8MPKL xGvPY1A3XLkEHzo39omir3O7hNjSqiY980ydn8W/vCpRs04jMh5RLus6ACFnKUZwmiagCo zi6gJ+C7Onil4w1A8SMKJH1W4jlaxHWYPWC6seph+l942+XY1mZGPMenNXAZD7FnE+OaKz yOsk1yGm6cn66ljX64SICV0pWKru1+bozozRu10dVOy4J7QX0kxwrkluPigNfg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5C03AB99D for ; Mon, 25 Mar 2024 20:14:17 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ropln-0003V7-34; Mon, 25 Mar 2024 15:14:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1roplk-0003Lk-Us for guix-patches@gnu.org; Mon, 25 Mar 2024 15:14:05 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ropli-0006KC-W3 for guix-patches@gnu.org; Mon, 25 Mar 2024 15:14:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ropli-0003rd-6T for guix-patches@gnu.org; Mon, 25 Mar 2024 15:14:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70001] [PATCH] gnu: reprotest: Add missing propogated inputs Resent-From: Skyler Ferris Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 25 Mar 2024 19:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 70001 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 70001@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.171139400114800 (code B ref -1); Mon, 25 Mar 2024 19:14:02 +0000 Received: (at submit) by debbugs.gnu.org; 25 Mar 2024 19:13:21 +0000 Received: from localhost ([127.0.0.1]:36296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ropl3-0003qe-Bf for submit@debbugs.gnu.org; Mon, 25 Mar 2024 15:13:21 -0400 Received: from lists.gnu.org ([2001:470:142::17]:47726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ropl2-0003qR-2V for submit@debbugs.gnu.org; Mon, 25 Mar 2024 15:13:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ropkx-0002mS-57 for guix-patches@gnu.org; Mon, 25 Mar 2024 15:13:15 -0400 Received: from mail-40131.protonmail.ch ([185.70.40.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ropkv-0006BE-4W for guix-patches@gnu.org; Mon, 25 Mar 2024 15:13:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1711393983; x=1711653183; bh=S+VQ3z8pyOkYqFlurxODka3Qm/h7EfjKQ7F2TJOP/AE=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=DvyZbrxfb54gCiDGCxo1ANaBCBLE9inmIr/EPfAK3Mryqh7U6xiwF4JRWWiH3j5Uj caD5oxWFz2mXJ0lp55lC/V6AUmoROE9XIkbFQHykXjWb5awUdlmsX3PsTrd/yzI0gW KWmHNR84kidzAbVN2WTwU7k3MsffhpnzqV0yUCl0tsK9FkGHLLtOtEpSNCgw0jyM4f avFcte7hSBXFbKmYYbQSx4rM8f6RZ493Syu3eyNVDkAWxMXtkuxf6ci7iwF3eEgdj8 QY3fztRrbqTSQz36syVSE1Uqmc7mTQdm8RlqW6Pkn2kK+8x7g88Yi31xHtv8TZW21V oAf0DZgdiI+KQ== Date: Mon, 25 Mar 2024 19:12:52 +0000 Message-ID: <7893aa6e-886b-4e74-999f-886a8ea0166b@protonmail.com> Feedback-ID: 40635331:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.40.131; envelope-from=skyvine@protonmail.com; helo=mail-40131.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Skyler Ferris X-ACL-Warn: , Skyler Ferris via Guix-patches From: Skyler Ferris via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Queue-Id: 5C03AB99D X-Spam-Score: -6.84 X-Migadu-Spam-Score: -6.84 X-Migadu-Scanner: mx10.migadu.com X-TUID: LTyY4NL+vG7b Hello, This patch adds some propagated inputs to the reprotest package so that=20 most tests can run in a pure shell. I observed some issues running this=20 package in a pure shell when reviewing issue 69991 (which updates=20 diffoscope). Some of the new propagated inputs have already been listed=20 as native inputs, but I did not remove them under the assumption that=20 these programs are actually needed for the build machine. There are 3=20 tests which still do not work in a pure shell. The fileordering and user_group tests both require setuid programs. Both=20 require fusermount and user_group requires sudo. I do not think it is=20 possible to make these tests work within a pure shell because a package=20 cannot provide setuid programs (only an operating system can). The domain_host test does not work in a pure shell due to a dependency=20 on a program named domainname. I was unable to locate a package which=20 provides this command. The closest I could find is the inetutils package=20 which provides dnsdomainname but I do not think this is sufficient for=20 the test to run correctly. The domainname command is used in=20 reprotest/build.py line 243: ```python _ =3D _.prepend_to_build_command(*"unshare -r --uts".split(), =C2=A0=C2=A0=C2=A0 "sh", "-ec", r""" =C2=A0=C2=A0=C2=A0 hostname {1} =C2=A0=C2=A0=C2=A0 domainname "{2}" =C2=A0=C2=A0=C2=A0 """.format(build.aux_tree, hostname, domainname) + '"$@= "', "-") ``` It looks to me like this is trying to set both the hostname and the=20 domainname, which makes sense if it wants to test for these settings as=20 a cause of non-determinism. The hostname command supports setting, but=20 the dnsdomainname command only supports retrieving the domain name. Additionally, this patch adds a new build phase to call fusermount3=20 instead of fusermount, which is the name of the command provided by=20 Guix's fuse package. This does not make it work in a pure shell but it=20 does make it work in an operating system that provides the suid version=20 of the binary. Summary: Tests working in pure shell: - aslr - build_path - environment - exec_path - home - kernel - locales - num_cpus - time - timezone - umask Tests work with appropriate suid programs provided: - fileordering - user_group Tests that do not work on any Guix system: - domain_host To try reprotest in a pure shell, create the following makefile in an=20 empty directory: ```make destination: =C2=A0=C2=A0 =C2=A0echo foo > destination clean: =C2=A0=C2=A0 =C2=A0rm -f destination ``` Then, run the following command to try the working tests. If you want to=20 see the test report a problem you will need to change the recipe to be=20 non-deterministic. For example, use `date` instead of `echo foo` in=20 order to see the time test report a problem. Note that make is an=20 additional package in the shell because this is the build system that=20 happens to be used, but it would not make sense to add this as a=20 mandatory input to the package because some people might use reprotest=20 without using make. If you remove one of the propagated inputs then at=20 least one of these tests will crash, with the exception of findutils and=20 diffoscope which are used by reprotest outside the context of a specific=20 test (to get the hashes of multiple files and display diffs to the user,=20 respectively). ```shell guix shell --pure reprotest make -- bash -c 'cd /tmp/test && reprotest=20 "make clean && make" destination --variations=3D"+environment,=20 +build_path, +kernel, +aslr, +num_cpus, +time, +home, +locales,=20 +exec_path, +timezone, +umask"' ``` You can try the suid-dependent tests with the same Makefile. The sudo=20 and fuse-2 packages need to be installed; the default %setuid-programs=20 variable includes the relevant binaries. Remove the `--pure` flag from=20 the shell invocation and change the `--variations` flag in the reprotest=20 variations to have the value `"+fileordering, +user_group"`. Regards, Skyler