From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id oK9sL5APZGJERgAAbAwnHQ (envelope-from ) for ; Sat, 23 Apr 2022 16:39:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id KdVmL5APZGIBZwAA9RJhRA (envelope-from ) for ; Sat, 23 Apr 2022 16:39:12 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7910CB2B9 for ; Sat, 23 Apr 2022 16:39:12 +0200 (CEST) Received: from localhost ([::1]:57224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1niGul-0007NZ-KZ for larch@yhetil.org; Sat, 23 Apr 2022 10:39:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58886) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1niGuc-0007NC-Qh for guix-patches@gnu.org; Sat, 23 Apr 2022 10:39:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34775) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1niGuc-0004aW-G8 for guix-patches@gnu.org; Sat, 23 Apr 2022 10:39:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1niGuc-0002sH-Du for guix-patches@gnu.org; Sat, 23 Apr 2022 10:39:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54852] [PATCH] gnu: Add openjdk18. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 23 Apr 2022 14:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54852 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Rostislav Svoboda Cc: Julien Lepiller , 54852@debbugs.gnu.org Received: via spool by 54852-submit@debbugs.gnu.org id=B54852.165072470810998 (code B ref 54852); Sat, 23 Apr 2022 14:39:02 +0000 Received: (at 54852) by debbugs.gnu.org; 23 Apr 2022 14:38:28 +0000 Received: from localhost ([127.0.0.1]:56905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1niGu3-0002rK-VO for submit@debbugs.gnu.org; Sat, 23 Apr 2022 10:38:28 -0400 Received: from laurent.telenet-ops.be ([195.130.137.89]:50074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1niGu2-0002rB-GL for 54852@debbugs.gnu.org; Sat, 23 Apr 2022 10:38:27 -0400 Received: from ptr-bvsjgyhxw7psv60dyze.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:3c5f:2eff:feb0:ba5a]) by laurent.telenet-ops.be with bizsmtp id NEeN2700g4UW6Th01EePQM; Sat, 23 Apr 2022 16:38:24 +0200 Message-ID: <77993552c1ea4641522845b97adc8bd5d8a2691a.camel@telenet.be> From: Maxime Devos Date: Sat, 23 Apr 2022 16:38:17 +0200 In-Reply-To: References: <20220411125335.4047-1-Rostislav.Svoboda@gmail.com> <3878c34d8b9b52c6a618bb47ff3a3142f3d55c9f.camel@telenet.be> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-RalN6FvxpySJWzn6bCc0" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1650724704; bh=n1kbwsUEzK6iOoxcKNxybQjV7LFPPbUqjaz19qEs5EI=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=LXZZQg2e6DsexabIhMOAGwozXBIXHdQDPH1mhwep0xY5IXJNE4kwcoxfwXcEyNz/K AGDzAubY+qyT9j1hR0mERjt0Su3/337ZJf4sg7JnndcT7Wd63afjyBegOGKQTHDjrC HR0xcexFAPAt0FTtaMTw8i7taNhk7WjRP74J84M21aLpxXL/ahNXTX5fP6zB4mVWBn k94qrn7hM1+ZLfwWv1aNchwgfWBhWAqVQzP8iZgUyh6VWxzpae4y1EAezSrKH7nAuA J66BaWcevl9zK//UlxBlBe0b6FbXt+6CwC579nXNxYK1fOEGrZQxiVL6Iw3h0Yab3c yAxoBwcHGDBVg== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1650724752; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=n1kbwsUEzK6iOoxcKNxybQjV7LFPPbUqjaz19qEs5EI=; b=f9k4jOnKg9Y67K966KlvW1eBhofVrINkxh9cbmrpdFBWVqntxbN76NXxKLUZlTF5s656yT yjwFqugrKO8ieo6WhsLO2ryI/R+EPx6WuC42PTJXR9gkgOxBnSfC6KlZ8K9sodu9BHxEyE l3fTYG2gs1iJjN+fp8VJe/h9HpUDBB0deLJBGZSuHf8vMdzAeJdzDzQ5yZqNPk4eh4P3T4 KpJzQi1XuZi1Y6Kx2fAPDqKWHgninwOnm4jGU6CSoZK5tdv7L8XNs+FBSilMEVr6o02ggb mKUkcz3W2gbZgo5UOczs4IHJsp9tiNmub8y3O9cXj5Wo/M08kYMAOni8+qM7lA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1650724752; a=rsa-sha256; cv=none; b=TKniGLL+aZa3eQ9pZpA0QPxp+N16wQA6E/LOqy3VEPS+m3NIRlyfT7o65uQ6ATpgFA7F4R 8o5eJSNhLkB9z5k+jQUr7zWDR0Vg+pWS2bjdF2Mm2zP4HBTyNSBDhGNZWlMq0HqQrwcLDg F6IbVri4b0iYSmnBTuWFUYSrbNVx/u/ea3XqYuysUz2fsrALWvwISUGQyt0Ed0uawv4Kvf jtRxJ9WuGLfL6t0uTUhfIEVtUFqve2c59psTalAk7X4AYtjNgCHfetkjpxRg4yOEnuv8hd 9p9aZYaATMD/i1aULnTKNI6gr3bsBqhfqWwEPR3Oi4VkbEb7Kw79Bn8nCFobxg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=LXZZQg2e; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 3.88 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r22 header.b=LXZZQg2e; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 7910CB2B9 X-Spam-Score: 3.88 X-Migadu-Scanner: scn1.migadu.com X-TUID: epmpIFGQe72V --=-RalN6FvxpySJWzn6bCc0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Rostislav Svoboda schreef op vr 22-04-2022 om 12:59 [+0200]: > > Is something like > >=20 > > =C2=A0=C2=A0 (modify-inputs (package-native-inputs opendjk17) > > =C2=A0=C2=A0=C2=A0=C2=A0 (replace "openjdk16:jdk" openjdk17)) > >=20 > > possible? >=20 > I think more appropriate would be: >=20 > (modify-inputs (package-native-inputs openjdk17) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (replace "openjdk16:jdk" `(,openjdk17 "jdk= "))) >=20 > however that would mean to assign a value Y to a variable named > "I-represent-a-value-of-X". So hmm, better not this way. >=20 > I personally prefer the: >=20 > (native-inputs > =C2=A0=C2=A0=C2=A0=C2=A0 (map (lambda (input) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (match= (car input) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 ("openjdk16:jdk" `("openjdk17:jdk" ,openjdk17 "jdk")) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 (_ input))) > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (package-native-in= puts openjdk17))) >=20 > variant. IMO it better expresses the idea of substitution. >=20 > Here, (if such a pattern repeats) we could define a new syntax > `substitue` in the guix/packages.scm analogical to `delete`, > `prepend`, `append` and `replace`. Isn't this just (modify-inputs ... (replace "..." ...))? What's the difference between 'replace' and 'substitute'? They conceptually seem to be about the same to me. And in case of substitute, I'm more thinking of 'substitute*' than package inputs. Greetings, Maxime. --=-RalN6FvxpySJWzn6bCc0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYmQPWRccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7rbDAP965Lg0A2ilI1uJJRJjxvfVbsWe s0GAuvl4ErCC0pT8XAD/XN0a0YhjSG+GDcOfOAfOpZ3M+ASjUI0XQBvsISEQZgI= =DAfq -----END PGP SIGNATURE----- --=-RalN6FvxpySJWzn6bCc0--