From: Jonathan Brielmaier <jonathan.brielmaier@web.de>
To: "Jakub Kądziołka" <kuba@kadziolka.net>, 42474@debbugs.gnu.org
Cc: efraim@flashner.co.il
Subject: [bug#42474] [PATCH v3 1/2] gnu: Add ispell.
Date: Tue, 28 Jul 2020 14:51:14 +0200 [thread overview]
Message-ID: <7712f260-e389-919a-5085-a79af523e80f@web.de> (raw)
In-Reply-To: <20200728113609.28126-1-kuba@kadziolka.net>
On 28.07.20 13:36, Jakub Kądziołka wrote:
> * gnu/packages/aspell.scm (ispell): New variable.
>
> Co-authored-by: Jonathan Brielmaier <jonathan.brielmaier@web.de>
> ---
>
> Hi,
>
> DESTDIR is a variable that should always be / on Guix. Its meaning is
> that the package should be installed to $DESTDIR/$prefix/bin/foo, but
> will be ran at $prefix/bin/foo - useful when you're managing the
> creation of a binary tarball manually, but useless and misleading for
> Guix.
Okay, thanks for that explanation :)
> Also, we already have an implementation of Yacc - I've replaced the
> input with Bison.
I search for yacc in my /gnu/store but there was no build of Bison so I
couldn't find it. We(TM) need definitly a tool to search binaries in all
packages :)
> Moreover, instead of patching the defaults, a configuration file is now
> created.
>
> I haven't tried spellchecking anything with ispell or using the German
> dictionary, but both packages now build.
I tested your version with LibreOffice and Icecat and it's still
working. So I'm fine with it for pushing. Thank for your review and
additional work!
next prev parent reply other threads:[~2020-07-28 12:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 12:26 [bug#42474] [PATCH 0/3] WIP: Add hunspell-dict-de Jonathan Brielmaier
2020-07-22 12:30 ` [bug#42474] [PATCH 1/3] gnu: Add byacc Jonathan Brielmaier
2020-07-22 12:30 ` [bug#42474] [PATCH 2/3] WIP: gnu: Add ispell Jonathan Brielmaier
2020-07-22 12:30 ` [bug#42474] [PATCH 3/3] WIP: gnu: Add hunspell-dict-de Jonathan Brielmaier
2020-07-23 7:56 ` [bug#42474] [PATCH 0/3] WIP: " Efraim Flashner
2020-07-24 22:38 ` [bug#42474] [PATCH v2 0/3] " Jonathan Brielmaier
2020-07-24 22:38 ` [bug#42474] [PATCH v2 1/3] gnu: Add byacc Jonathan Brielmaier
2020-07-24 22:38 ` [bug#42474] [PATCH v2 2/3] WIP: gnu: Add ispell Jonathan Brielmaier
2020-07-28 11:36 ` [bug#42474] [PATCH v3 1/2] " Jakub Kądziołka
2020-07-28 12:51 ` Jonathan Brielmaier [this message]
2020-07-28 11:36 ` [bug#42474] [PATCH v3 2/2] gnu: Add hunspell-dict-de Jakub Kądziołka
2020-08-27 20:15 ` Jonathan Brielmaier
2020-10-15 20:07 ` Jonathan Brielmaier
2020-10-18 9:20 ` bug#42474: " Efraim Flashner
2020-07-24 22:38 ` [bug#42474] [PATCH v2 3/3] WIP: " Jonathan Brielmaier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7712f260-e389-919a-5085-a79af523e80f@web.de \
--to=jonathan.brielmaier@web.de \
--cc=42474@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
--cc=kuba@kadziolka.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).