From: Maxime Devos <maximedevos@telenet.be>
To: Dion Mendel <guix@dm9.info>, 47921@debbugs.gnu.org
Subject: [bug#47921] [PATCH] build: Fix elf-dynamic-info-soname.
Date: Wed, 21 Apr 2021 13:49:33 +0200 [thread overview]
Message-ID: <76bb70d22fed27efd4a15308abdd9e95fb1aa929.camel@telenet.be> (raw)
In-Reply-To: <20210420194429.GB29387@dm9.info>
[-- Attachment #1: Type: text/plain, Size: 859 bytes --]
Dion Mendel schreef op wo 21-04-2021 om 03:44 [+0800]:
> * guix/build/gremlin.scm (elf-dynamic-info-soname): Return the value of
> the dynamic-entry instead of the dynamic-entry record itself.
1. IIUC, this change would cause a world-rebuild, so this patch would have
to applied on core-updates. The subject line should have been
[PATCH core-updates]: etcetera.
2. How did you test this patch?
3. What does this patch fix?
4. elf-dynamic-info-soname is a record accessor. Did you mean elf-dynamic-info?
5. According to the docstring (core-updates, c9a61dff8242612ae8275829a5ee31ff45ff08b1):
"Return dynamic-link information for ELF as an <elf-dynamic-info> object, or
#f if ELF lacks dynamic-link information."
So this patch actually _introduces_ a bug. Or you need to modify the docstring
as well.
Greetings,
Maxime.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 260 bytes --]
next prev parent reply other threads:[~2021-04-21 11:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-20 19:44 [bug#47921] [PATCH] build: Fix elf-dynamic-info-soname Dion Mendel
2021-04-21 2:46 ` Dion Mendel
2021-04-21 11:49 ` Maxime Devos [this message]
2021-04-21 15:46 ` Dion Mendel
2021-04-21 18:33 ` Maxime Devos
2021-04-22 3:13 ` Dion Mendel
2021-04-22 8:20 ` bug#47921: " Ludovic Courtès
2021-04-22 2:55 ` [bug#47921] retitle Dion Mendel
2021-04-22 3:26 ` [bug#47921] Include correct commit message Dion Mendel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76bb70d22fed27efd4a15308abdd9e95fb1aa929.camel@telenet.be \
--to=maximedevos@telenet.be \
--cc=47921@debbugs.gnu.org \
--cc=guix@dm9.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).