From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id WCLFGgjdtmAXCwAAgWs5BA (envelope-from ) for ; Wed, 02 Jun 2021 03:21:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id IF01FgjdtmCBGAAA1q6Kng (envelope-from ) for ; Wed, 02 Jun 2021 01:21:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id EE57A258A3 for ; Wed, 2 Jun 2021 03:21:11 +0200 (CEST) Received: from localhost ([::1]:48792 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loFZH-0008GX-2q for larch@yhetil.org; Tue, 01 Jun 2021 21:21:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52018) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loFZ8-0008Ft-TF for guix-patches@gnu.org; Tue, 01 Jun 2021 21:21:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54918) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1loFZ8-0006C3-Le for guix-patches@gnu.org; Tue, 01 Jun 2021 21:21:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1loFZ8-00080y-Hd for guix-patches@gnu.org; Tue, 01 Jun 2021 21:21:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47768] [PATCH v3 00/42] Assorted OCaml patches Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 02 Jun 2021 01:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47768 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 47768@debbugs.gnu.org, public@yoctocell.xyz, pukkamustard@posteo.net Cc: erikl@posteo.net, maximedevos@telenet.be, d@divoplade.fr X-Debbugs-Original-To: guix-patches@gnu.org, Xinglu Chen , pukkamustard X-Debbugs-Original-Cc: Erik , Maxime Devos , 47768@debbugs.gnu.org, divoplade Received: via spool by 47768-submit@debbugs.gnu.org id=B47768.162259681030701 (code B ref 47768); Wed, 02 Jun 2021 01:21:02 +0000 Received: (at 47768) by debbugs.gnu.org; 2 Jun 2021 01:20:10 +0000 Received: from localhost ([127.0.0.1]:38227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loFYH-0007z6-UV for submit@debbugs.gnu.org; Tue, 01 Jun 2021 21:20:10 -0400 Received: from lepiller.eu ([89.234.186.109]:39094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1loFYF-0007ys-S8 for 47768@debbugs.gnu.org; Tue, 01 Jun 2021 21:20:08 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 3e7b869e; Wed, 2 Jun 2021 01:20:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date :in-reply-to:references:mime-version:content-type :content-transfer-encoding:subject:to:cc:from:message-id; s= dkim; bh=cTAdfsGiN3WEi1UWKN85tUSMC4hJ24limbp82Xf+Gdc=; b=OrjXMfI zlQICqW+dvOOZsTM7mFG500QtJnI6Kk49j1Tgn8QKp/c2Rgvg+rzCWdLyytHxQlH u9oiit94OYk35ZG3d9fi5oX7s58uWaoaAfUvOfZUtrdEM3i5VDPC2LeRcVzBJLmo O6ARgpd34UV2Dgk7GN8N7AD4izCj/Km5AS/HtzkTGQkICx9m9f+Ab7cJXNfUsocZ iFeseSOHdkoIi2R+yLYgBH3TSnfeILv4R8ek5MQD15yvMeRKmoWBNVZfwx8K9ApU 5LHStzV0kjMYn5oplX59uQ/2YErbt4+6DgFiWmJNVUHj1izYc52KXUFW1J5hUtf8 VsIXG/QhGBg5zpw== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 67141109 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Wed, 2 Jun 2021 01:20:04 +0000 (UTC) Date: Tue, 01 Jun 2021 21:19:42 -0400 User-Agent: K-9 Mail for Android In-Reply-To: <87czt5xnpf.fsf@yoctocell.xyz> References: <87lf82hasx.fsf@yoctocell.xyz> <20210601202203.8587-1-pukkamustard@posteo.net> <87czt5xnpf.fsf@yoctocell.xyz> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----BQ60W1U7OD4YHBHQ9CUMLBP19IIV6A" Content-Transfer-Encoding: 7bit From: Julien Lepiller Message-ID: <7662B41F-646C-44A3-807C-D4678139619A@lepiller.eu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1622596872; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=cTAdfsGiN3WEi1UWKN85tUSMC4hJ24limbp82Xf+Gdc=; b=lu4CJI0t8A5p422kBp23sNtr/WsdjaMw3yS3b7/QvtRxiQC++rN+25xR6HILiMJIDVSE5N tiIc8yyLal+Et2D/OoyPMjE1YdXNg+GS8xkbhEQp3mImCeYuIagza4PnDCmJNI9U3gz0yi EdhNHS7boldbOJoy2VYO64Nc73JiTRh7OUhSyd92MdZL8JaldPFkbvJBVRGpDmm37/tG9n AP1txB4PaohWQEF28MeMI99GSMIEQLbYolf/Skg8NER76FIZA170gvbLnpfmV/7cvsAo0O W0HlIQ5/IFCjR30v+E97YxsgcLT407d6SWOLiph2UzDnW6JiE5LToBB52EIMAg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1622596872; a=rsa-sha256; cv=none; b=FDMcrJgliqRzM0yxSfsrEHew5vXcARo4BVSY74Q2uNPctHLJ8ZJmAtJDMbZRLTroescjd9 OH2sydLsxLYtOSLyJqSnXurVMd/7jDfB6gy2yjOQLao8yHh6zwvbmn51+D9hcIfcg+f+aB u17lyCnwsdeHE4ZrR+C7Ske0Z/ESTMoSALdGQCAB+prLD+aBN0ZZKRSY2JhPG9WGMcxvG3 3WmekIe50UvwqqHeii1MC56mLT8ig4Qij0QwsWfVvMyo05D9n1XCVmzV8/x5zfku8eSY90 qsNGP2hQ9bK+dT82HKwlccOw9GYOT2Obsk6ZCsH6mYXqbpR0SAFGgVwZAKFoZA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b="OrjXMfI "; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.33 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b="OrjXMfI "; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: EE57A258A3 X-Spam-Score: -1.33 X-Migadu-Scanner: scn0.migadu.com X-TUID: B3YiyIC/73zc ------BQ60W1U7OD4YHBHQ9CUMLBP19IIV6A Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable I keep telling myself I should review and merge the changes but I keep havi= ng better things to do :p=2E I'll have a look during the week-end if noone = beats me at it :) Le 1 juin 2021 17:46:36 GMT-04:00, Xinglu Chen a = =C3=A9crit : >On Tue, Jun 01 2021, pukkamustard wrote: > >> Hi, >> >> Xinglu Chen writes: >> >>> All the packages build fine, but I haven=E2=80=99t tested anything=2E >> >> Thanks for the review! > >You are welcome! > >> It follows a V3 with the two changes you suggested (add tests for >> ocaml-uunf and merge patches 10 and 11 of V2)=2E > >The changes look good to me, and =E2=80=98ocaml-uunf=E2=80=99 builds fine= =2E > >> Erik has tested some of the packages and reports that everything >seems >> to be fine=2E >> >>> LGTM! >> >> Maybe we are good to merge now? > >No objections from me, but I don=E2=80=99t have commit access=2E :( > >Thank you and divoplade for the work! ------BQ60W1U7OD4YHBHQ9CUMLBP19IIV6A Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable I keep telling myself I should review and merge th= e changes but I keep having better things to do :p=2E I'll have a look duri= ng the week-end if noone beats me at it :)

Le 1 juin 2021 17:46:36 GMT-04:00, Xinglu Chen <public@yoctocell=2Exyz= > a =C3=A9crit :
On Tue, Jun 01 2021, pukkamustard wrote:

 Hi,

 Xinglu Chen <p=
ublic@yoctocell=2Exyz> writes:

All the packages build fine, but I haven=E2=80=99t tested an=
ything=2E

 Thanks for the review!

Y= ou are welcome!

It = follows a V3 with the two changes you suggested (add tests for
ocaml-uun= f and merge patches 10 and 11 of V2)=2E

The changes loo= k good to me, and =E2=80=98ocaml-uunf=E2=80=99 builds fine=2E

Erik has tested some of the pac= kages and reports that everything seems
to be fine=2E

LGTM!

Maybe we = are good to merge now?

No objections from me, but I don= =E2=80=99t have commit access=2E :(

Thank you and divoplade for the = work!
------BQ60W1U7OD4YHBHQ9CUMLBP19IIV6A--