From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 8JVMN37UEWU7uwAAauVa8A:P1 (envelope-from ) for ; Mon, 25 Sep 2023 20:42:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:478a::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 8JVMN37UEWU7uwAAauVa8A (envelope-from ) for ; Mon, 25 Sep 2023 20:42:07 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 964DC6159E for ; Mon, 25 Sep 2023 20:42:06 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="g1u/OW5p"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1695667326; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=POohiJ7mTpL/2lOo76EkSRiVZgbKqa1S65CdRnljJyI=; b=MBSA1XQEUPjc5uv290TMfzABOmwasx508x/rxrfodKuna6FseL1imTGH79IqCVGmXOW9PD 0dAWK6hPv10GG2UmgIJpLP4ArnoO9oeAkP0szTvTrKqF6OQAuv0Wc1elwGXDklNvcumXjG aooBtkEEq3eUtGZpp6nu01CbRpzjEahjecRm5Hmlvvfk3gHS4ANzZIjlbTddOX186jYalg jRs/JeokSFFEnICkmB+4ODuDhiPtctwAjCR1sxyGPGIfIO7+sVk4Qoc6DQgBxo0kPUmZAP OKc/s5mHzxqZjDo2tbK3di+Us4C4AsCOyX9H1tZmJFU6++yVCr68/jHtji9h+w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1695667326; a=rsa-sha256; cv=none; b=NilG26S9l7Vv5hq7k8cx1icxaNCR8K9QyFSCHRYaaIszrgEEUXQi7Pwbpa9mHsFtv0Uta1 sPa/lGwzLOL/fuduSKeNaf8UadQVS6r+JSNeSbUfIRv+z6Po8XmK5sVNW9bU9qIflXahcJ N2tPwlJFNRm0bDXfAFLo842XFEiJvKwviNJ1uDLbrwf0/jnvKvvHUFLl8plIc9G4FKBNuR dRhUyQzTtbvT6BFQl5xSZN/b0bUy7LQNscD/xjxVKDpUO5+sV8NbQlrec2BTA+GSO4JRer 2l+8KNxrnhWWSjDyEdPMew0/UtNvXthSad3p28Nh5tHoILmkN9MZ2Trdm8AKhQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="g1u/OW5p"; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qkqWm-0000U4-Ud; Mon, 25 Sep 2023 14:41:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qkqWj-0000NJ-Lm for guix-patches@gnu.org; Mon, 25 Sep 2023 14:41:50 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qkqWj-00024q-DO for guix-patches@gnu.org; Mon, 25 Sep 2023 14:41:49 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qkqWv-0001em-Kj for guix-patches@gnu.org; Mon, 25 Sep 2023 14:42:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#66171] [PATCH] gnu: git: Install shell completions. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 25 Sep 2023 18:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66171 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: 66171@debbugs.gnu.org, Simon Tournier Received: via spool by 66171-submit@debbugs.gnu.org id=B66171.16956672906323 (code B ref 66171); Mon, 25 Sep 2023 18:42:01 +0000 Received: (at 66171) by debbugs.gnu.org; 25 Sep 2023 18:41:30 +0000 Received: from localhost ([127.0.0.1]:46657 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkqWQ-0001dv-67 for submit@debbugs.gnu.org; Mon, 25 Sep 2023 14:41:30 -0400 Received: from mail-ej1-x644.google.com ([2a00:1450:4864:20::644]:61608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qkqWL-0001dd-Mj for 66171@debbugs.gnu.org; Mon, 25 Sep 2023 14:41:29 -0400 Received: by mail-ej1-x644.google.com with SMTP id a640c23a62f3a-99c1c66876aso870519966b.2 for <66171@debbugs.gnu.org>; Mon, 25 Sep 2023 11:41:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695667267; x=1696272067; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=POohiJ7mTpL/2lOo76EkSRiVZgbKqa1S65CdRnljJyI=; b=g1u/OW5pvjkCq0SwD7WhHammVybAZjqqATvFsHIw2dECMSINB08T1y/mOHVkEBCgCu gPiBmzjDQKMPy2pDYvNt1OSLNYyRqA4VH/XdZ0bdVdaf2V+ZlSZAOXL1iqRn0FzhVQi3 Bh0P9/nOgLTl/ALr6s7nMx/NjJxsj5kFwQGuu/4fl+6QOoG1aoGRmXVyDnKlfi/cRYGc 7q2qGgFHs+rfZQD56Wi/x71T7EP4nySwBwfcXr348HyPglQ3mkF4bkjSo4wqDVtdTUMs 6rq3lwGUwRjKRV/NSwCBtwuZga+h6P+DuIhzYBhK5ofcYtcZd4pY4g3bEKO5Puhqe7NR yplw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695667267; x=1696272067; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=POohiJ7mTpL/2lOo76EkSRiVZgbKqa1S65CdRnljJyI=; b=Eex1GVG0jRM/qM4LtJO1Fj4q7iyWyARVqrTUM3IYOla+saItGQHr4rO3haGG9nFigH a7DQl1LYWs3f2WQ8V/x8/lQLj2BRqXCYNNQU6LJKxh7uOSgTsXBhBITAg26hN398i24V 1eagD563LQSxIv5NqU0W+ENU3EiTg885vTjRGiXkYSdD552E+841U7Kb0A0pjcyZ798q ytToilUPS1GdObCWiwfBQOvhrGcx/FcBxXUb0gMHDsiNv1hcHxySmHspX4bOex09NqzG AcE0wKxC+JSeM58jhy3NXNrCvNmsd4vzTzRBe7SqFNowK7trygys+MIKEkrZhFpF3rH/ QJ7w== X-Gm-Message-State: AOJu0YxWhIeBAimSjtYgc1tOGZ5FZ7OXAO78yB0rB/axnU26/EZW5REu bc8tbX/U36Y426ymWCyvEPo2SKN1BuHLHg== X-Google-Smtp-Source: AGHT+IHLfLlYbFKdf/2OqqGXSG91Kj5JHPv64M8uufRQqc5ocmvcJ0M4Oqs9+nISYOUy/HpMPm4T5w== X-Received: by 2002:a17:906:209:b0:9a9:d5f4:1a0d with SMTP id 9-20020a170906020900b009a9d5f41a0dmr6502083ejd.45.1695667267170; Mon, 25 Sep 2023 11:41:07 -0700 (PDT) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id md1-20020a170906ae8100b009a1be9c29d7sm6720579ejb.179.2023.09.25.11.41.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 Sep 2023 11:41:06 -0700 (PDT) Message-ID: <7659d2d5a891bb3ee81e87ab484924f3337cae81.camel@gmail.com> From: Liliana Marie Prikler Date: Mon, 25 Sep 2023 20:41:05 +0200 In-Reply-To: <877coe2lap.fsf_-_@gmail.com> References: <7be0975a4d30362dec08c3115e68c992e58ab549.1695660890.git.liliana.prikler@gmail.com> <877coe2lap.fsf_-_@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx0.migadu.com X-Migadu-Spam-Score: -3.64 X-Spam-Score: -3.64 X-Migadu-Queue-Id: 964DC6159E X-TUID: 8J2dH3BV5fBw Am Montag, dem 25.09.2023 um 13:51 -0400 schrieb Maxim Cournoyer: > Hello, >=20 > Liliana Marie Prikler writes: >=20 > > * gnu/packages/version-control.scm (git)[outputs]: Add > > =E2=80=9Ccompletion=E2=80=9D. > > [#:phases]: Add =E2=80=98install-completion=E2=80=99. > > (git-minimal)[#:phases]: Adjust accordingly. >=20 > Did something change in git?=C2=A0 I've always had completion in git, so > I'm not sure what this extra phase does, or when it's useful?=C2=A0 Does > it add *extra* completion or... ? Which shell are you using? If it's zsh, then the completion is baked in. If it's bash, idk, I haven't tried. I personally use this for the included git-prompt, which allows me to have my prompt look like the following: \u@\h /path/to/guix [$branch env] ($SHLVL) \$ > Also, a completion output seems a bit over the top.=C2=A0 I doubt its > weigh justifies the annoyance of special casing it. I special-cased it because it *is* a contrib script, but also as it might be able to conflict with whatever shell builtins you have. Now it isn't particularly likely to do so given that other distros include it as part of their git-core, but I prefer safe over sorry. That being said, I could just write it to out if you prefer that. Cheers