From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id SH3wKwcl8V6DIAAA0tVLHw (envelope-from ) for ; Mon, 22 Jun 2020 21:39:19 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id oMCuJwcl8V7hbwAAbx9fmQ (envelope-from ) for ; Mon, 22 Jun 2020 21:39:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 43FCB94051C for ; Mon, 22 Jun 2020 21:39:19 +0000 (UTC) Received: from localhost ([::1]:38606 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jnU9t-00026K-R2 for larch@yhetil.org; Mon, 22 Jun 2020 17:39:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45208) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jnU9e-00025y-7V for guix-patches@gnu.org; Mon, 22 Jun 2020 17:39:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51482) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jnU9d-0000dp-T8 for guix-patches@gnu.org; Mon, 22 Jun 2020 17:39:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jnU9d-0003D2-Qe for guix-patches@gnu.org; Mon, 22 Jun 2020 17:39:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41953] [PATCH] gnu: darktable: Update to 3.0.2. Resent-From: Vinicius Monego Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 22 Jun 2020 21:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41953 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke , 41953-done@debbugs.gnu.org Received: via spool by 41953-done@debbugs.gnu.org id=D41953.159286191012295 (code D ref 41953); Mon, 22 Jun 2020 21:39:01 +0000 Received: (at 41953-done) by debbugs.gnu.org; 22 Jun 2020 21:38:30 +0000 Received: from localhost ([127.0.0.1]:34795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnU98-0003CF-6B for submit@debbugs.gnu.org; Mon, 22 Jun 2020 17:38:30 -0400 Received: from mout02.posteo.de ([185.67.36.66]:33321) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jnU95-0003Bz-Ui for 41953-done@debbugs.gnu.org; Mon, 22 Jun 2020 17:38:28 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 82DF52400FB for <41953-done@debbugs.gnu.org>; Mon, 22 Jun 2020 23:38:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1592861901; bh=nHYxXG3ZbwLqU3FMobDRmqrxxxV97+sAR7swLKV7zjQ=; h=Subject:From:To:Date:From; b=Rn3LF1tlE/4FxPzaIvJPWD8JsJE09m8T8ndKpKq5OEA3lew+qi7TfYmWJcnkVmNLc lED4t3vOmz3XmosBcE7W0X8zxsb/pgBrK5oboYfQ46oAWy4dbdGu2c+MM37hfdggPR RSTvS8rp/fJ2vlF94AhNeCaTWPnTWewrDyx7BjFE8dZ1Hmp/mwc7ekpzyrOT+pqzoO EgjZIdl/wLs3o38Todbchx380i+rdta9HqJGQUilKPkigdcxRFdn/8r58Z+R2JWGeM O4lZPjz8Rd2lZf/emzTsZ5/xsQY+gTgcVpjVYVqEXMpxgSnHeJc/5EEHYYMsJ0zktS S+YSPcgZEsFmA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 49rN7b54CHz9rxG; Mon, 22 Jun 2020 23:38:19 +0200 (CEST) Message-ID: <764ae39b13a0bc092e18474e9f784e32c3028cf8.camel@posteo.net> From: Vinicius Monego Date: Mon, 22 Jun 2020 18:37:58 -0300 In-Reply-To: <875zbibyby.fsf@gnu.org> References: <20200619201120.34116-1-monego@posteo.net> <875zbibyby.fsf@gnu.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=posteo.net header.s=2017 header.b=Rn3LF1tl; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: qp7qnnc2QVk5 Em seg, 2020-06-22 às 23:11 +0200, Marius Bakke escreveu: > Vinicius Monego writes: > > > * gnu/packages/photo.scm (darktable): Update to 3.0.2. > > [arguments]: Compile with clang. > > [arguments]: Wrap GSETTINGS_SCHEMAS_DIR. > > [license]: Add license information for Rawspeed. > > [native-inputs]: Add clang. > > [native-inputs]: Add desktop-file-utils. > > [native-inputs]: Add glib. > > [native-inputs]: Add gobject-instrospection. > > [native-inputs]: Add llvm. > > [native-inputs]: Add po4a. > > [native-inputs]: Reorder alphabetically. > > [inputs]: Add colord-gtk. > > [inputs]: Add cups. > > [inputs]: Add graphicsmagick. > > [inputs]: Add gsettings-desktop-schemas. > > [inputs]: Add iso-codes. > > [inputs]: Add libsecret. > > [inputs]: Add lua. > > [inputs]: Add openjpeg. > > [inputs]: Add osm-gps-map. > > [inputs]: Reorder alphabetically. > > Thanks! I flattened this commit message so there is just a single > entry > for each of the changed fields. > > > (modify-phases %standard-phases > > + (add-before 'configure 'prepare-build-environment > > + (lambda* (#:key inputs #:allow-other-keys) > > + (setenv "CC" "clang") (setenv "CXX" "clang++"))) > > I tried building with GCC, and indeed it failed. First because ISL > was > not enabled, so I added 'gcc-9' which has it and adjusted > CPLUS_INCLUDE_PATH accordingly, but still ran into problems. A few hours ago I was splitting this patch into shorter commits and the build began to fail. Weird, because it compiled succesfully for about 7 times before I submitted this patch. > > It would be good to move to GCC eventually because Clang is not > nearly > as well tested. :-) > The reason I chose clang is that CMake was very loud about LLVM not being found (it's an optional dependency to run OpenCL tests, which is one of the few features still missing from the package). When LLVM is found, CMake will recommend clang. That made me guess it was the recommended compiler. > Anyway thanks for the patch, applied! I didn't expect it to be approved at v1. Thanks :-)