From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36436)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dxB4Q-0003xH-SE
	for guix-patches@gnu.org; Wed, 27 Sep 2017 08:04:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dxB4M-000309-V7
	for guix-patches@gnu.org; Wed, 27 Sep 2017 08:04:06 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:53838)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dxB4M-0002zw-R1
	for guix-patches@gnu.org; Wed, 27 Sep 2017 08:04:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dxB4M-0002Nh-G5
	for guix-patches@gnu.org; Wed, 27 Sep 2017 08:04:02 -0400
Subject: [bug#28583] [PATCH 2/7] gnu: Add ruby-multi-json.
Resent-Message-ID: <handler.28583.B28583.15065138209123@debbugs.gnu.org>
References: <20170924171717.3855-1-mail@cbaines.net>
	<20170924171717.3855-2-mail@cbaines.net>
From: Ben Woodcroft <b.woodcroft@uq.edu.au>
Message-ID: <763dd635-3585-ed21-1823-2c0c3f285dbd@uq.edu.au>
Date: Wed, 27 Sep 2017 22:03:32 +1000
MIME-Version: 1.0
In-Reply-To: <20170924171717.3855-2-mail@cbaines.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Christopher Baines <mail@cbaines.net>, 28583@debbugs.gnu.org



On 25/09/17 03:17, Christopher Baines wrote:
> * gnu/packages/ruby.scm (ruby-multi-json): New variable.
[..]
> +    (arguments
> +     '(#:tests? #f)) ;; No testsuite.
No testsuite included in distributed gem, rather.
> +    (synopsis
> +     "Common interface to multiple JSON libraries for Ruby")
> +    (description
> +     "This package provides a common interface to multiple JSON libraries,
> +including Oj, Yajl, the JSON gem (with C-extensions), the pure-Ruby JSON gem,
> +NSJSONSerialization, gson.rb, JrJackson, and OkJson.")
> +    (home-page
> +     "http://github.com/intridea/multi_json")
Both home-page and synopsis could be moved to the line before.

Otherwise LGTM.
ben