From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 6P1FMxhj22bAXQEAe85BDQ:P1 (envelope-from ) for ; Fri, 06 Sep 2024 20:16:25 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id 6P1FMxhj22bAXQEAe85BDQ (envelope-from ) for ; Fri, 06 Sep 2024 22:16:24 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=eJpNmAF6; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=K+6fI0MH; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1725653784; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=b/nYirG698nmKGWnzJQ4L6n+jX7/69SdDLTRECXaDns=; b=OXGOM6qgH5x35XXKOZvaDFL/cIbU+0TL60RGN194OEQhCJzhQlTAJZ4BxoW72EXm+ttfdP YDEjgCqbIpIieAmLmYho1xI4gtkhDXaLjOrz1OCvYf5SXmzWNd9oTx/o7Lua3EE5ugxMFv SexlpDj/pdLe+VHefcCoEelggMtvhGwiSDJ9YTKAM88PO1LFAsy3pJP3lNFscz9uoz0BcI v8Q+PYTf1yfg0AS2JqqtqtnrZJMPmHmVS4HDpOMa+xZu8fEumrjMcDfW0aJcK4R0St2sTq Fmz06wniqUntwvsKZmowvy+XbL77Oy6bzs98NCtrYb6tdvoPraGBra2bQt176g== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1725653784; a=rsa-sha256; cv=none; b=DMw5RMUAS4lJY+mNGLpA8jRYPGOY2ANAbmv/7wfSJJR0tvZN+Z4h/JQL6Ut4nf3IbNGWor UJZVpkK+HVsQkMq6FbDLNCvZyMfPmt7Jnzp0C/fzNci2VbIyPQCIyJOPinSkDpHszK1lYZ fhKpCDBUEo7ky+BlRxxk86f3VCgo5YcP2S0HcKmD2E59InfVv0QXhn5D3w8+YX7I/wYt5m Kk9PJ3FavQucIwxqjq+L5q5yb3zcALJn70O1NATipNkUNRzMFVjIvLPuqdOPg0h2jXogTE w8rG1NSkYNl25ewJob+ndByE8Ewe2fqDIGK06fIu550you0j+1Sn2/0i6G/fAA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=eJpNmAF6; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=K+6fI0MH; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B938772CA7 for ; Fri, 06 Sep 2024 22:16:23 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1smfNF-0000MK-NO; Fri, 06 Sep 2024 16:16:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1smfND-0000M1-CA for guix-patches@gnu.org; Fri, 06 Sep 2024 16:16:03 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1smfNC-0008C7-Ta for guix-patches@gnu.org; Fri, 06 Sep 2024 16:16:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:Date:From:To:Subject; bh=b/nYirG698nmKGWnzJQ4L6n+jX7/69SdDLTRECXaDns=; b=eJpNmAF65P6puRLHhmb5OyCPeLAISdm4Go3900yoTc2RtPZFjSXCVIrA+9k+AHsQZiJEpVNcTQQl2BOEWNZc1ssMM8PLuphvBTReVRYfxF5DYiQJGmpBaorMaCuTj1vWMZw6bcy0oSc2kRFmUnONQH2vbFYd1rhtXIg4NV6QZx0CvLCHpzjNxrvuKEBldiGGZX4vDrLJxxK7t40yVtngnVy84EtiPwTlOOXoimnP5syGGgx6Gruwh0EUiLtHZUD0gUajEeO26Cw0uxx+V/opseuMO5n94MrGfSTV/bQGemKFJJ45q9auKr5azh2fwnDa53fL+US90+uiU4f937GoqQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1smfNB-0005H7-M3 for guix-patches@gnu.org; Fri, 06 Sep 2024 16:16:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73073] [PATCH 4/6] gnu: gnome-recipes: Move libgd origin from phases to native-inputs. Resent-From: Liliana Marie Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 06 Sep 2024 20:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73073 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Simon Tournier , 73073@debbugs.gnu.org Cc: Vivien Kraus , Maxim Cournoyer Received: via spool by 73073-submit@debbugs.gnu.org id=B73073.172565371420212 (code B ref 73073); Fri, 06 Sep 2024 20:16:01 +0000 Received: (at 73073) by debbugs.gnu.org; 6 Sep 2024 20:15:14 +0000 Received: from localhost ([127.0.0.1]:54234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smfMP-0005Fw-N8 for submit@debbugs.gnu.org; Fri, 06 Sep 2024 16:15:14 -0400 Received: from mail-wr1-f65.google.com ([209.85.221.65]:48287) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1smfMN-0005Am-2Y for 73073@debbugs.gnu.org; Fri, 06 Sep 2024 16:15:11 -0400 Received: by mail-wr1-f65.google.com with SMTP id ffacd0b85a97d-3787ddbd5a2so1278438f8f.0 for <73073@debbugs.gnu.org>; Fri, 06 Sep 2024 13:15:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725653645; x=1726258445; darn=debbugs.gnu.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=b/nYirG698nmKGWnzJQ4L6n+jX7/69SdDLTRECXaDns=; b=K+6fI0MH7cLdc/CS/sw122si6IJ3DIvW34vMMTaKsIUqqzS9KfQ1LeJPv1kAKn/w0p +ot2hD1N4mFcZsb0HZXMKZoV6wR+H6OSIb8lKmwaa58QXJzJOWhdfWMFge+orUNCYQl9 5+XrD5swIFfW/zJfvLm2cDVAZpRNAe+8jVwGbBsDfLKSW6byWvAFjoenelU2iA6g3hWV DDjfB6bFFV+ZXYlhW4lyaVHUKIRap6aAI7ifOXNf2YmBmw8jqBRgXFYRy74wX2pHDq9O kQJmkifAiK8vKsl0gTEeRFXYE7Ka9fDdZs5J7wPTfvjW9A5tiixEiCQ580dn0pVDyFFA CChw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725653645; x=1726258445; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=b/nYirG698nmKGWnzJQ4L6n+jX7/69SdDLTRECXaDns=; b=q9exmHuVi2yIqTayaN3l6s6AJyNzZ+kJAhhKFlwuw1kbCeIa7/HwVIsHzf0YRbBfaw bMQ4s+W2w6QBQj4yKOf075gpiEdf6ocF34FidZ/wJ2qf9eO2BM2xC9ecuQOJ4Wh/A7au gy7SAjT/oMRV/PBQzrDc38jvr/jqWktbLeL/Hwv3KeGZ28/gpI9wlX5vgn3ToRYkVOfm FzmigGNqrg1RltE8SSnfRJ08OK+SoojS5r6yTx/6XUhOJSN2++KZkgaUdHZpBIkhG4k2 jKCOOmDZJfXsnLP7Ii8U+9o88VNhde+1b0rIXuLa2T4QkI+c5ZolxVi6t7n1HHnZM88F k3lw== X-Forwarded-Encrypted: i=1; AJvYcCW7zjRw8Mg2X1w7BGPvZ9D3OJkr3p2S3SvGv+SdDQLNVzMjITzhF3DHZmNEyqYjoyoIsVAiNw==@debbugs.gnu.org X-Gm-Message-State: AOJu0Yy0RVjqcSu4xfamwE1UPhvN6rO8Ie87z1OJTB/eAXBD+fOJ/KCW Z7lcUKUYZaTQVj1lOBX0w73iCGL72ZpmcVYEHqTEjuHhAXtMeRPi X-Google-Smtp-Source: AGHT+IEAmK7omH2srucNxilHUFjIwtKByQHOpAf4e5XQPaoXW+LqTvDQIi6Abh8q5LnajRevFxs0ow== X-Received: by 2002:a5d:50cb:0:b0:371:8c61:577c with SMTP id ffacd0b85a97d-378895dcc54mr2394881f8f.26.1725653644723; Fri, 06 Sep 2024 13:14:04 -0700 (PDT) Received: from lumine.fritz.box (85-127-20-124.dsl.dynamic.surfer.at. [85.127.20.124]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42ca53a3e4bsm21635275e9.47.2024.09.06.13.14.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Sep 2024 13:14:03 -0700 (PDT) Message-ID: <7618cf89ae284480e97374a13b288a6dc209fb81.camel@gmail.com> From: Liliana Marie Prikler Date: Fri, 06 Sep 2024 22:14:02 +0200 In-Reply-To: <8734mcire8.fsf@gmail.com> References: <4b84954a845391197ebbdbb7f5c9d04eb3ecdc7f.1725636992.git.zimon.toutoune@gmail.com> <8734mcire8.fsf@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -5.92 X-Spam-Score: -5.92 X-Migadu-Queue-Id: B938772CA7 X-Migadu-Scanner: mx11.migadu.com X-TUID: u2LdgASv4dxK Am Freitag, dem 06.09.2024 um 20:11 +0200 schrieb Simon Tournier: > Hi Liliana, >=20 > My aim is not to mix, under =E2=80=99inputs=E2=80=99 record field, the ol= d style > (label) with the new style (no label) but to have the =E2=80=99origin=E2= =80=99 inside > =E2=80=99inputs=E2=80=99 and not inside =E2=80=99arguments=E2=80=99. Sure, but you do introduce a label to make that work is what I'm saying. > As I wrote in the cover letter: >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 This is annoying because these= origins are hidden from > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 =E2=80=99package-direct-source= s=E2=80=99; see module (guix packages). >=20 > So it helps the package. ;-) >=20 > Please note that the docstring of =E2=80=99package-direct-sources=E2=80= =99 is > currently lying. ;-)=C2=A0 Well, the situation is a bug, IMHO. I think we should fix =E2=80=98package-direct-sources=E2=80=99 then. The d= erivation obviously knows about this input, otherwise the package wouldn't be built, so the information is there. I'd also hazard a guess that Rust being Rust, no useful information for Rust packages comes with package- direct-inputs if arguments aren't being handled. > --8<---------------cut here---------------start------------->8--- > =C2=A0 "Return all source origins associated with PACKAGE; including > origins in PACKAGE's inputs and patches." > --8<---------------cut here---------------end--------------->8--- >=20 >=20 > > IMHO, G-Expressions in phases serve in part to facilitate uses like > > this. >=20 > I agree that G-exps facilitate manipulation of store paths.=C2=A0 But > using =E2=80=99origin=E2=80=99 inside arguments appears to me as an abuse= of the > feature.=C2=A0 As I wrote in the cover letter: >=20 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Moreover and tangentially, it = appears to me an anti-pattern > of the > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 functional paradigm: The data = from the impure outside should > be handled > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 by the =E2=80=99source=E2=80= =99 record field, or otherwise by =E2=80=99inputs=E2=80=99, > =E2=80=99native-inputs=E2=80=99 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 or =E2=80=99propagated-inputs= =E2=80=99 record fields; let say only =E2=80=99inputs=E2=80=99 > for > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 simplicity. >=20 > Therefore, I strongly think =E2=80=99origin=E2=80=99 should not be inside= arguments. We could handle it in source at the cost of similar anti-patterns, or in inputs at the cost of the anti-pattern you suggest. The Right Thing=E2=84=A2 would be to unbundle these dependencies correctly. Also note that your argument would apply to #$this-package-input just as well: it still is magic that pulls in data from the impure outside world, and you can trivially trick it into doing silly things. (Just add inheritance.) > Somehow, my submission is a proposal for dealing with the case.=C2=A0 And > it=E2=80=99s not really if it needs to, or should, be done. :-) You are working on the implicit assumption that everyone agrees that it needs to be done, then. =20 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0 Particularly, we're now even adding a labeled input, > > which makes for a cursed situation where all but one inputs are > > unlabeled=C2=B9. >=20 > Please note it=E2=80=99s a specific inputs: it=E2=80=99s an =E2=80=99orig= in=E2=80=99.=C2=A0 This can be > checked by the pattern matching, e.g., >=20 > =C2=A0=C2=A0=C2=A0 (((? string? label) (? origin? o) ;Allow old style as = sometimes > requires by origin in inputs > =C2=A0=C2=A0=C2=A0=C2=A0 `(,label ,o)) >=20 > Other said, it would not be a =E2=80=9Ccursed situation=E2=80=9D; only a = situation > using a locally defined input. It *is* a cursed situation for the person reading the inputs field.=20 Apart from proper unbundling, some other workarounds would be: - hacking around search-input-file - making dummy data packages - named origins (this one requires similar support code to be written and has already been rejected once IIRC) - computed origins And yes, I label them as workarounds, since they don't address the root cause of why origins are introduced in arguments. Sometimes, practicality beats purity: Consider the ungoogled-chromium recipe if you hadn't had a good scare today. The fact that this pattern shows up as rarely as it does is a testament to how well Guix functions otherwise =E2=80=93 but there might still be a need for it in som= e fringe circumstances. I'd rather we don't change code unless the result is clearly better=E2=84=A2, and I don't see that here. Cheers