unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Roel Janssen <roel@gnu.org>
To: Felix Gruber <felgru@posteo.net>, 48418-done@debbugs.gnu.org
Subject: bug#48418: [PATCH] gnu: sameboy: Update to 0.14.3
Date: Fri, 21 May 2021 13:11:55 +0200	[thread overview]
Message-ID: <75e4138959d7c235e5210095caae17d876765693.camel@gnu.org> (raw)
In-Reply-To: <20210514140514.7311-1-felgru@posteo.net>

Hi Felix,

On Fri, 2021-05-14 at 14:05 +0000, Felix Gruber wrote:
> * gnu/packages/emulators.scm (sameboy): Update to 0.14.3.
> [native-inputs]: Remove gcc-9.
> [arguments]: Use cc-for-target instead of hard-coding gcc.
> ---
>  gnu/packages/emulators.scm | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/gnu/packages/emulators.scm b/gnu/packages/emulators.scm
> index 4367c23a6b..30cd2daf55 100644
> --- a/gnu/packages/emulators.scm
> +++ b/gnu/packages/emulators.scm
> @@ -14,6 +14,7 @@
>  ;;; Copyright © 2020 Jakub Kądziołka <kuba@kadziolka.net>
>  ;;; Copyright © 2020 Christopher Howard
> <christopher@librehacker.com>
>  ;;; Copyright © 2021 Felipe Balbi <balbi@kernel.org>
> +;;; Copyright © 2021 Felix Gruber <felgru@posteo.net>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -637,7 +638,7 @@ and Game Boy Color games.")
>  (define-public sameboy
>    (package
>      (name "sameboy")
> -    (version "0.13.6")
> +    (version "0.14.3")
>      (source
>       (origin
>         (method git-fetch)
> @@ -646,17 +647,17 @@ and Game Boy Color games.")
>               (commit (string-append "v" version))))
>         (file-name (git-file-name name version))
>         (sha256
> -        (base32
> "04w8lybi7ssnax37ka4qw7pmcm7cgnmk90p9m73zbyp5chgpqqzc"))))
> +        (base32
> "1dipidx12ai62hnzf0pvnsk1cgjcmw1h5x2r7ilxq0k0pkia5b7a"))))
>      (build-system gnu-build-system)
>      (native-inputs
>       `(("rgbds" ,rgbds)
> -       ("gcc" ,gcc-9)
>         ("pkg-config" ,pkg-config)))
>      (inputs
>       `(("sdl2" ,sdl2)))
>      (arguments
>       `(#:tests? #f                      ; There are no tests
> -       #:make-flags `("CC=gcc" "NATIVE_CC=gcc" "CONF=release"
> +       #:make-flags `(,(string-append "CC=" ,(cc-for-target))
> +                      "NATIVE_CC=gcc" "CONF=release"
>                        ,(string-append "DATA_DIR="
>                                        (assoc-ref %outputs "out")
>                                        "/share/sameboy/"))

LGTM and pushed in 4bf2637c4947ad874821c58ca0eb2583753f5631.

Thank you!

Kind regards,
Roel Janssen





      reply	other threads:[~2021-05-21 11:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-14 14:05 [bug#48418] [PATCH] gnu: sameboy: Update to 0.14.3 Felix Gruber
2021-05-21 11:11 ` Roel Janssen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=75e4138959d7c235e5210095caae17d876765693.camel@gnu.org \
    --to=roel@gnu.org \
    --cc=48418-done@debbugs.gnu.org \
    --cc=felgru@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).