From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id +Ep8IpuHYmDZbgAAgWs5BA (envelope-from ) for ; Tue, 30 Mar 2021 04:06:19 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id CddPHJuHYmAkSQAAbx9fmQ (envelope-from ) for ; Tue, 30 Mar 2021 02:06:19 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id F3DA71C0F4 for ; Tue, 30 Mar 2021 04:06:18 +0200 (CEST) Received: from localhost ([::1]:37388 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lR3lp-00054f-9H for larch@yhetil.org; Mon, 29 Mar 2021 22:06:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59728) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lR3la-00054T-87 for guix-patches@gnu.org; Mon, 29 Mar 2021 22:06:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38362) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lR3la-0004oT-0q for guix-patches@gnu.org; Mon, 29 Mar 2021 22:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lR3lZ-0000Zk-QV for guix-patches@gnu.org; Mon, 29 Mar 2021 22:06:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47435] gnu: mail: Make the sendmail package actually output its binary Resent-From: =?UTF-8?Q?L=C3=A9o?= Le Bouter Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 30 Mar 2021 02:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47435 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Rovanion Luckey , Leo Famulari Cc: 47435@debbugs.gnu.org Received: via spool by 47435-submit@debbugs.gnu.org id=B47435.16170699312168 (code B ref 47435); Tue, 30 Mar 2021 02:06:01 +0000 Received: (at 47435) by debbugs.gnu.org; 30 Mar 2021 02:05:31 +0000 Received: from localhost ([127.0.0.1]:49908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lR3l1-0000Yr-SK for submit@debbugs.gnu.org; Mon, 29 Mar 2021 22:05:31 -0400 Received: from mail.zaclys.net ([178.33.93.72]:40043) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lR3kw-0000YX-I0 for 47435@debbugs.gnu.org; Mon, 29 Mar 2021 22:05:26 -0400 Received: from guix-xps.local (82-64-145-38.subs.proxad.net [82.64.145.38]) (authenticated bits=0) by mail.zaclys.net (8.14.7/8.14.7) with ESMTP id 12U25Et8040308 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 30 Mar 2021 04:05:15 +0200 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.zaclys.net 12U25Et8040308 Authentication-Results: mail.zaclys.net; spf=fail smtp.mailfrom=lle-bout@zaclys.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zaclys.net; s=default; t=1617069915; bh=lqOLn32AkfbERmG6hNIXeaG/+RpARSYKYptoyZEXMMI=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=kNJvgMQN7bpWW6H6EF1dmc9V2qlbJZMorXAD8Q7+ir7YOreGEQJZ8Rh8u0TD+MWxw wtOIXKZy0WBB/axUW8u/4QSfjtsRMQT4acKrZS/aE78+ntxDCAogy62uvy9s6VfFi0 5ajW5tog5FkqmAaBjrD6s8U5LqTgS2rBkTT9k7l4= Message-ID: <75974c07f11e9e07061c192fe50c8704e4cb4d1c.camel@zaclys.net> Date: Tue, 30 Mar 2021 04:05:10 +0200 In-Reply-To: References: Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-xz5Ri1w08tbtr8rCSDfp" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: =?UTF-8?Q?L=C3=A9o?= Le Bouter X-ACL-Warn: , =?UTF-8?Q?L=C3=A9o?= Le Bouter via Guix-patches From: =?UTF-8?Q?L=C3=A9o?= Le Bouter via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617069979; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=lqOLn32AkfbERmG6hNIXeaG/+RpARSYKYptoyZEXMMI=; b=D94dNt0ns/5B+i+479l7/4KmOk7+4dy5FPZe5vsQSj7FW75Z/nrZTPjpc/oIRRVuS8M9ie RIpbJpWWcI9CxOGC0SWzJBT3tS9wp+ibkWe7Pvxn8i3R7xKYJ9QzJfuMWvhRMtvbld78pN xUR3e16EyRcWnyx8bCfhnsWRwvW/Bz/mpYH5UVGPfvwqlcvvWdotKH0WBPyDOcCfL4Rl/l pT5F7W/A8G7qJ694ea+d4yLkwjfdNm0JVGrFAhdVS9WWuKmpKGeRCnM1MdI8yH3lvPBzaF mhI+kzgdy7zNkWlBR34Zt2st9Qq2IfTVIL/az65q5h8oVoHbtE0VVuC68nsmuA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617069979; a=rsa-sha256; cv=none; b=tlS/qfirSWecDZc5DqxmQdHFSuj9RtA7SzPSQGrWwBYzATo/14TsrJAtpdPiile3WCgARr dsmp6sIQ81037fm57f959So/spJwAhxUEFeU3bBaXGH7bJnTWd8R8r6xmAWUPAPrewogbS 7ExEIxLY5yVugdHmp3da71662yHgCD0xidtJcKbcpmapEZ6eZDDQbcHbDuNc+hitaqHCp4 hCQ1wENAwK+FAPWtIOtr5nYvqxs8wl7gDpAzcmnYH+Sig255Z0uHQZ9yG+jYEKOe4RKAWf zTqw65xUwIaKFSUSyKJ4Sq14WQGMEjsb0x/xXlgz9gFgzyd4EpPVZXoVf4jotg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=zaclys.net header.s=default header.b=kNJvgMQN; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -3.52 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=zaclys.net header.s=default header.b=kNJvgMQN; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: F3DA71C0F4 X-Spam-Score: -3.52 X-Migadu-Scanner: scn0.migadu.com X-TUID: HW7tQhuwgArQ --=-xz5Ri1w08tbtr8rCSDfp Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2021-03-29 at 16:24 +0200, Rovanion Luckey wrote: > Attached to this email you will find three patches that > 1. make the sendmail binary appear in PATH after the sendmail package > is > installed, > 2. add libmilter to the package collection and > 3. updates sendmail and libmilter to 8.16.1. >=20 > I ended up putting smrsh back in libexec because that is where all > the > other distros put it and seems like a program that should only be > used by > sendmail itself. Thank you for the patches! > + (synopsis "Sendmail library for creating mail filters."))) > + On the commit message, the convention is that all titles end with a period, also all statements in the subtext also end with a period, and that the subtext is wrapped to 80 columns (unless links). Look at other commit messages for examples. It seems in your latest patches applied on top of master, the 'sendmail' package does not build: starting phase `pre-install' Using M4=3D/gnu/store/jlm51s1gz6pah5bn7mc1i12kj5xilhck-m4-1.4.18/bin/m4 ../../devtools/bin/install.sh -c -o root -g bin -m 0444 sendmail.cf /gnu/store/6iaqmnb3rgcjdh3jz56x4r1hafalrvmg-sendmail- 8.16.1/etc/mail/sendmail.cf cp: cannot create regular file '/gnu/store/6iaqmnb3rgcjdh3jz56x4r1hafalrvmg-sendmail- 8.16.1/etc/mail/sendmail.cf': No such file or directory make: *** [Makefile:83: install-sendmail-cf] Error 1 command "sh" "Build" "install-cf" failed with status 2 builder for `/gnu/store/7rm2hkxw5sqz34k562wfgwsfvpg0avsk-sendmail- 8.16.1.drv' failed with exit code 1 @ build-failed /gnu/store/7rm2hkxw5sqz34k562wfgwsfvpg0avsk-sendmail- 8.16.1.drv - 1 builder for `/gnu/store/7rm2hkxw5sqz34k562wfgwsfvpg0avsk-sendmail-8.16.1.drv' failed with exit code 1 derivation '/gnu/store/7rm2hkxw5sqz34k562wfgwsfvpg0avsk-sendmail- 8.16.1.drv' offloaded to 'www.proxmox-2.schmilblick.org' failed: build of `/gnu/store/7rm2hkxw5sqz34k562wfgwsfvpg0avsk-sendmail-8.16.1.drv' failed build of /gnu/store/7rm2hkxw5sqz34k562wfgwsfvpg0avsk-sendmail- 8.16.1.drv failed libmilter builds fine however. I noticed it builds as a static library: /gnu/store/vdg98ynngj637sdn1xazgafb8af8fv2j-libmilter- 1.0.1/lib/libmilter.so.: ELF 64-bit LSB shared object, x86-64, version 1 (SYSV), statically linked, not stripped Is there any build flag to disable that? If so, I think we probably should, for security updates of it's dependencies, but it doesnt look like it has any, not even the glibc? Maybe it's not so important here. I also noticed that there was a weird naming for the actual so file, it ends with a dot '.': $ tree $(./pre-inst-env guix build libmilter) /gnu/store/vdg98ynngj637sdn1xazgafb8af8fv2j-libmilter-1.0.1 =E2=94=9C=E2=94=80=E2=94=80 include =E2=94=82 =E2=94=94=E2=94=80=E2=94=80 libmilter =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 mfapi.h =E2=94=82 =E2=94=94=E2=94=80=E2=94=80 mfdef.h =E2=94=9C=E2=94=80=E2=94=80 lib =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 libmilter.a =E2=94=82 =E2=94=9C=E2=94=80=E2=94=80 libmilter.so -> libmilter.so. <<-- = here =E2=94=82 =E2=94=94=E2=94=80=E2=94=80 libmilter.so. <<-- also here =E2=94=94=E2=94=80=E2=94=80 share =E2=94=94=E2=94=80=E2=94=80 doc =E2=94=94=E2=94=80=E2=94=80 libmilter-1.0.1 =E2=94=94=E2=94=80=E2=94=80 LICENSE 6 directories, 6 files Again it will work anyways I believe, not crucial. > +(define-public libmilter > + (package > + (inherit sendmail) > + (name "libmilter") > + (version "1.0.1") Where does this version come from? Are you sure about that? Also do note that changing the version field here in libmilter does not change the version used in the origin of the inherited package So it's using the same sources as sendmail exactly, that's what you want? > + (arguments > + (substitute-keyword-arguments (package-arguments sendmail) > + ((#:phases phases) > + `(modify-phases ,phases > + (replace 'build > + (lambda* _ > + (with-directory-excursion "libmilter" > + (invoke "sh" "Build")) > + #t)) > + (delete 'pre-install) > + (replace 'install > + (lambda* _ > + (with-directory-excursion "libmilter" > + (mkdir-p (string-append (assoc-ref %outputs "out") > "/lib")) > + (invoke "make" "install")) > + #t)))))) > + (synopsis "Sendmail library for creating mail filters."))) > + I suggest adding a dedicated synopsis and description here, also synopsises as I see it should not be sentences and not end with a period, descriptions on the other hand should be full sentences, look at the other packages for inspiration. L=C3=A9o --=-xz5Ri1w08tbtr8rCSDfp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEFIvLi9gL+xax3g6RRaix6GvNEKYFAmBih1YACgkQRaix6GvN EKaYlQ//Xzs3TUfoCzPz1PoEMuPBlY/Qtny9L4sJUKsbQ04z4Tm50YnC6yWjzWZK MpFUEqm4a41Szwh0wUxLzqRNK1A2AFsWn+2L9UHakzCUKOB/LDqe0TIdYV01sftm i03BgK3Y+cJkstULhD/Is1YfqWiW1qziP4kfd9pK6Cuyms+/y+EXEt81krX8CE7z C9VTvDWZlD8sV2fOjQHqJ7jEUMC1Ed1rj8+2J0zLNCC1sbcE9wxzzHS9oVLhtV0g 5ZXH3nHYkSt+6pVzwqBX08t7dSQdR2EdEupLVsc5cpxeMKyV4xy+sBLRxtYroCMX Gt7mSKlH9bPEYQM/02um/tQBMXKRrzYk+qTswxhwkVo19QRNyQhxQweLi4t+3tjJ Ukmaqviovosb+7tmV/REPlqDRn/q90xONJUEn5cjfygqd7Te8e6PcEIPlCYrNotA 4MTyPCkJK4Rdjjr6+ZBJHqD4gQ6u10sFcn5d2aMHErJU6IqULjodvpjMiATEHKC5 Ue1vx3WZSZs2zaHXqOWrCMo5ROfPS/vIUho5juSF2YZowVLjiEA6ag286w+vvgYO NOpo9wra6JQoBAzmVGHJtQTvFeLWIYV6/fTsEx6xT42LQ/LumQnURN5X3pdR1aAJ NuYQsTjBeAVXFiKO3je8RXvjnsQ0rsAWXV1vPOZg/ehQLi+VKY8= =79vH -----END PGP SIGNATURE----- --=-xz5Ri1w08tbtr8rCSDfp--