From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YD9xJiczfWBrdgEAgWs5BA (envelope-from ) for ; Mon, 19 Apr 2021 09:37:11 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id SMsfIiczfWDRJwAAB5/wlQ (envelope-from ) for ; Mon, 19 Apr 2021 07:37:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2486F2D0F9 for ; Mon, 19 Apr 2021 09:37:11 +0200 (CEST) Received: from localhost ([::1]:40548 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lYOSz-00030h-Qt for larch@yhetil.org; Mon, 19 Apr 2021 03:37:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55034) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lYOSs-00030N-9G for guix-patches@gnu.org; Mon, 19 Apr 2021 03:37:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:36724) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lYOSr-0003gP-U4 for guix-patches@gnu.org; Mon, 19 Apr 2021 03:37:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lYOSr-0004TI-R2 for guix-patches@gnu.org; Mon, 19 Apr 2021 03:37:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47870] [PATCH 1/2] gnu: polkit-gnome: Add autostart .desktop file. Resent-From: Leo Prikler Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 19 Apr 2021 07:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47870 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Brendan Tildesley , 47870@debbugs.gnu.org Received: via spool by 47870-submit@debbugs.gnu.org id=B47870.161881777217123 (code B ref 47870); Mon, 19 Apr 2021 07:37:01 +0000 Received: (at 47870) by debbugs.gnu.org; 19 Apr 2021 07:36:12 +0000 Received: from localhost ([127.0.0.1]:48270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYOS4-0004S6-2A for submit@debbugs.gnu.org; Mon, 19 Apr 2021 03:36:12 -0400 Received: from mailrelay.tugraz.at ([129.27.2.202]:45171) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lYOS1-0004Rx-KP for 47870@debbugs.gnu.org; Mon, 19 Apr 2021 03:36:10 -0400 Received: from nijino.local (194-96-9-9.adsl.highway.telekom.at [194.96.9.9]) by mailrelay.tugraz.at (Postfix) with ESMTPSA id 4FNzBt01npz1LLyL; Mon, 19 Apr 2021 09:36:05 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 mailrelay.tugraz.at 4FNzBt01npz1LLyL DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tugraz.at; s=mailrelay; t=1618817766; bh=h+rugA+VMf+4drvlPU+E72TCeTIllRjGqSLL4TrIK74=; h=Subject:From:To:Date:In-Reply-To:References:From; b=nH/B3z0gh3xQAXIKB6C83AHnXdfQgEEotyrNViL08KE3gM4DEns7xdYcFlTNBQP4C OuZlzxwc2ZIowJBdzGA+UdcT9b41M0t9U4i6haNlaAQuHUJRPPAMPCaIkvQg9dNBzI qJkwVXNIfBnkO+tub57Wsmuk6JYuNgD5wVJrb8Do= Message-ID: <758fbca893846a643f5478972867e01d620b89dc.camel@student.tugraz.at> From: Leo Prikler Date: Mon, 19 Apr 2021 09:36:05 +0200 In-Reply-To: <1897089617.84042.1618815414259@office.mailbox.org> References: <20210418131727.6104-1-mail@brendan.scot> <687049384.78340.1618758931217@office.mailbox.org> <1897089617.84042.1618815414259@office.mailbox.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TUG-Backscatter-control: bt4lQm5Tva3SBgCuw0EnZw X-Spam-Scanner: SpamAssassin 3.003001 X-Spam-Score-relay: -1.9 X-Scanned-By: MIMEDefang 2.74 on 129.27.10.117 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1618817831; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=h+rugA+VMf+4drvlPU+E72TCeTIllRjGqSLL4TrIK74=; b=RHbB4Lt0mjsDIZ+xbHsHBdzYumAt3lU3ABTUrw493KnOZUh6kqZwimv7+BF1w2esIJAgoP l30+maiom6p5S4EqYKVdfvWjvWkG9m5oH7/XR4RUuxtFDnHRAgvEHqC6N9jUBDSJkdi0kD sDJdcNkEGoFtc00pLmrUIbFWUSVCdFRCdY4Ll/2z8k/MITxCy29/OyrHMkgHBMcvoYJGsm i6CCrlKQLD/QH96E/Dz+/mQm70VJw6jlAhpuP2ucID9slNwsOW2tcR4QDm3EUM6uS3OUK+ BLuDtz+QyRXnQd3Kvr/x+nEM3JnG32IlGJO7mzHVymDLtvol9PkXqaTxZyqZFg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1618817831; a=rsa-sha256; cv=none; b=ZjoUKD3yNNHHKM5Y66jrnrmRbpFruxc5UoFLAJxWilLMG+CaAhK6VMGvIs+vYwBfKQiVhS g+C7QmIUt8ksf9tsoBVGTg5FBtyNb+FiH4XqwXCfehphUWAO1hteZePpmrjJmxTjx3NPRc hSCf046yz6meqcuaOznJeVcrxi2hB5bfNe7nCv5l0bbNgW9GdEmsuwvErxOLr6/eFJQ9oQ OanWKtaYgiXWzEQw139yCwukGse+0mo0BMOlSMT+Eyy0YD8c9D3V7an0IDMLIY/9g6xpo2 RlZEuRqeuRKQEWTjMhJ3IEHo6GlfM4mG2tqonV77BYFijWx4KBO2prIU412jaA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b="nH/B3z0g"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.34 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=tugraz.at header.s=mailrelay header.b="nH/B3z0g"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=student.tugraz.at (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 2486F2D0F9 X-Spam-Score: -1.34 X-Migadu-Scanner: scn0.migadu.com X-TUID: 11vYOi1SkPvw Hi Brendan, Am Montag, den 19.04.2021, 08:56 +0200 schrieb Brendan Tildesley: > > On 04/18/2021 5:52 PM Leo Prikler > > wrote: > > > > > > Hi, > > > > Am Sonntag, den 18.04.2021, 17:15 +0200 schrieb Brendan Tildesley: > > > > On 04/18/2021 4:47 PM Leo Prikler < > > > > leo.prikler@student.tugraz.at> > > > > wrote: > [...] > > > On second thought perhaps another option is just to use the MATE > > > polkit > > > agent instead? I tested it for changing network manager and it > > > worked > > > just the same, only the GUI looks slightly different. I was > > > searching > > > What do you think? > > If it works for XFCE, why not? Given that polkit-gnome has no > > dependents other than itself, should we perhaps also look into > > removing > > it? > > > One issue is that mate-polkit's .desktop file has the line > OnlyShowIn=MATE; > This prevents it from being launched in any other desktop. When > multiple > desktops are installed all these files sit in /run/current- > desktop/profile/etc/ > and rely these lines to make them not appear in other desktops. > > I made a couple patches [attached] that adds XFCE to the the > .desktop's OnlyShowIn. > It's a little ugly though. This may potentially be bikeshedding, but what about defining a (potentially hidden) package, that inherits from mate-polkit (call it mate-polkit-for-xfce) and installs a .desktop file, that replaces MATE with XFCE? Ah, well, you'd also have to move the desktop file to a different location for there not to be a name clash. Other than that, the contents of your patches LGTM, but the ChangeLog is on a pretty verbose end. For instance, the message for 0001 should likely be rewritten as: ---- gnu: polkit-mate: Enable autostarting in XFCE. Add XFCE to the OnlyShowIn field of the autostart .desktop file so it will be started by XFCE as well. This is for the same of making polkit-mate the de facto polkit agent for XFCE in Guix, since XFCE does not ship its own. A potential downside might be, that this desktop file ends up in the current system profile and can therefore be seen in XFCE configurations, that did not ask for it. * gnu/packages/mate.scm (polkit-mate)[#:phases]: Add 'patch-desktop- for-xfce'. ---- You could also write significantly shorter commit messages, since "Enable autostarting in XFCE" already tells you everything the patch does. Regards, Leo