* [bug#72006] [PATCH] gnu: emacs-empv: Update to 4.3.0 revision 2.
@ 2024-07-09 11:46 gemmaro
2024-07-09 13:10 ` bug#72006: " Nicolas Goaziou via Guix-patches via
2024-07-09 17:09 ` [bug#72006] " Liliana Marie Prikler
0 siblings, 2 replies; 3+ messages in thread
From: gemmaro @ 2024-07-09 11:46 UTC (permalink / raw)
To: 72006; +Cc: gemmaro, Andrew Tropin, Katherine Cox-Buday,
Liliana Marie Prikler
* gnu/packages/emacs-xyz.scm (emacs-empv): Update to 4.3.0 revision 2.
[arguments]: Add a phase to set default binaries for fd and mpv.
[inputs]: Add fd and mpv.
[propagated-inputs]: Add emacs-consult.
Change-Id: I0e627d3b3ec3e5515ff7da9cd601713840e2a9c7
---
gnu/packages/emacs-xyz.scm | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 45225f2051..d7b25af21c 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -3751,7 +3751,7 @@ (define-public emacs-emprise
(define-public emacs-empv
(let ((commit "8cc9b0a425b6989d30f91bf90e9b09bd00581f07")
- (revision "1"))
+ (revision "2"))
(package
(name "emacs-empv")
(version (git-version "4.3.0" revision commit))
@@ -3766,7 +3766,16 @@ (define-public emacs-empv
(base32
"06dphwj9vi39dbpif3kzp6azs80klh13s9l22a6ddz91kmds2myy"))))
(build-system emacs-build-system)
- (propagated-inputs (list emacs-compat emacs-s))
+ (arguments
+ (list
+ #:phases #~(modify-phases %standard-phases
+ (add-after 'unpack 'set-default-binaries
+ (lambda* (#:key inputs #:allow-other-keys)
+ (emacs-substitute-variables "empv.el"
+ ("empv-fd-binary" (search-input-file inputs "/bin/fd"))
+ ("empv-mpv-binary" (search-input-file inputs "/bin/mpv"))))))))
+ (inputs (list fd mpv))
+ (propagated-inputs (list emacs-compat emacs-consult emacs-s))
(home-page "https://github.com/isamert/empv.el")
(synopsis
"Emacs multimedia player, media library manager, YouTube frontend")
base-commit: 6b496c071537e399710ff5ec0284f74a44b66c71
prerequisite-patch-id: 7243f4196faacbbb69b65baecf49b488e4c8a910
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#72006: [PATCH] gnu: emacs-empv: Update to 4.3.0 revision 2.
2024-07-09 11:46 [bug#72006] [PATCH] gnu: emacs-empv: Update to 4.3.0 revision 2 gemmaro
@ 2024-07-09 13:10 ` Nicolas Goaziou via Guix-patches via
2024-07-09 17:09 ` [bug#72006] " Liliana Marie Prikler
1 sibling, 0 replies; 3+ messages in thread
From: Nicolas Goaziou via Guix-patches via @ 2024-07-09 13:10 UTC (permalink / raw)
To: 72006-done; +Cc: gemmaro
Hello,
> * gnu/packages/emacs-xyz.scm (emacs-empv): Update to 4.3.0 revision 2.
I skipped that part. It is not necessary, since the patch doesn't modify
the commit hash.
Applied. Thank you!
Regards,
--
Nicolas Goaziou
^ permalink raw reply [flat|nested] 3+ messages in thread
* [bug#72006] [PATCH] gnu: emacs-empv: Update to 4.3.0 revision 2.
2024-07-09 11:46 [bug#72006] [PATCH] gnu: emacs-empv: Update to 4.3.0 revision 2 gemmaro
2024-07-09 13:10 ` bug#72006: " Nicolas Goaziou via Guix-patches via
@ 2024-07-09 17:09 ` Liliana Marie Prikler
1 sibling, 0 replies; 3+ messages in thread
From: Liliana Marie Prikler @ 2024-07-09 17:09 UTC (permalink / raw)
To: gemmaro, 72006; +Cc: Katherine Cox-Buday, Andrew Tropin
Am Dienstag, dem 09.07.2024 um 20:46 +0900 schrieb gemmaro:
> * gnu/packages/emacs-xyz.scm (emacs-empv): Update to 4.3.0 revision
> 2.
You don't need to bump the revision to update a recipe.
> [arguments]: Add a phase to set default binaries for fd and mpv.
> [inputs]: Add fd and mpv.
> [propagated-inputs]: Add emacs-consult.
>
> Change-Id: I0e627d3b3ec3e5515ff7da9cd601713840e2a9c7
> ---
> gnu/packages/emacs-xyz.scm | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
> index 45225f2051..d7b25af21c 100644
> --- a/gnu/packages/emacs-xyz.scm
> +++ b/gnu/packages/emacs-xyz.scm
> @@ -3751,7 +3751,7 @@ (define-public emacs-emprise
>
> (define-public emacs-empv
> (let ((commit "8cc9b0a425b6989d30f91bf90e9b09bd00581f07")
> - (revision "1"))
> + (revision "2"))
> (package
> (name "emacs-empv")
> (version (git-version "4.3.0" revision commit))
> @@ -3766,7 +3766,16 @@ (define-public emacs-empv
> (base32
>
> "06dphwj9vi39dbpif3kzp6azs80klh13s9l22a6ddz91kmds2myy"))))
> (build-system emacs-build-system)
> - (propagated-inputs (list emacs-compat emacs-s))
> + (arguments
> + (list
> + #:phases #~(modify-phases %standard-phases
> + (add-after 'unpack 'set-default-binaries
> + (lambda* (#:key inputs #:allow-other-keys)
> + (emacs-substitute-variables "empv.el"
> + ("empv-fd-binary" (search-input-file
> inputs "/bin/fd"))
> + ("empv-mpv-binary" (search-input-file
> inputs "/bin/mpv"))))))))
> + (inputs (list fd mpv))
> + (propagated-inputs (list emacs-compat emacs-consult emacs-s))
> (home-page "https://github.com/isamert/empv.el")
> (synopsis
> "Emacs multimedia player, media library manager, YouTube
> frontend")
Otherwise LGTM.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-09 17:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-09 11:46 [bug#72006] [PATCH] gnu: emacs-empv: Update to 4.3.0 revision 2 gemmaro
2024-07-09 13:10 ` bug#72006: " Nicolas Goaziou via Guix-patches via
2024-07-09 17:09 ` [bug#72006] " Liliana Marie Prikler
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).